All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Paul Louvel" <paul.louvel@bootlin.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 2/3] hwmon: (nct6775) Add support for NCT6126D
Date: Wed, 09 Sep 2026 18:41:49 +0000	[thread overview]
Message-ID: <20260909184150.633E91F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260909-bootlin-hwmon-nct6126-v1-2-4e85615fef10@bootlin.com>

> Add support for the hardware monitoring functionality of the NCT6126D
> Super-I/O chip.
> 
> The NCT6126D hardware monitor is nearly identical to the NCT6116D: the
> fan, PWM, temperature, TSI, alarm.
> 
> The differences are:
> 
> - Device IDs 0xd283 (A version) and 0xd284 (B version), which both fall
>   into the NCT6116D ID range (0xd280) when masked with SIO_ID_MASK.
>   Instead, compare the full value to distinguish from NCT6116D.
> 
> - One additional VIN: VHIF scaled at 16 mV/LSB.
> 
> - The fan count limit registers are documented for all five fans.
>   Also expose fan4_min.
> 
> Assisted-by: opencode:z-ai/glm-5.3-flash
> Signed-Off: Paul Louvel <paul.louvel@bootlin.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260909-bootlin-hwmon-nct6126-v1-0-4e85615fef10@bootlin.com?part=2


  reply	other threads:[~2026-09-09 18:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-09 18:25 [PATCH 0/3] hwmon: (nct6775) Add support for NCT6122D and NCT6126D Paul Louvel
2026-09-09 18:25 ` [PATCH 1/3] Documentation: hwmon: (nct6775) Document NCT6116D/NCT6122D/NCT6126D support Paul Louvel
2026-09-09 18:31   ` sashiko-bot
2026-09-09 20:26   ` Guenter Roeck
2026-09-09 18:25 ` [PATCH 2/3] hwmon: (nct6775) Add support for NCT6126D Paul Louvel
2026-09-09 18:41   ` sashiko-bot [this message]
2026-09-09 20:28   ` Guenter Roeck
2026-09-10  7:00     ` Paul Louvel
2026-09-09 18:25 ` [PATCH 3/3] hwmon: (nct6775) Add support for NCT6122D Paul Louvel
2026-09-09 18:34   ` sashiko-bot
2026-09-11  1:02   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260909184150.633E91F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=paul.louvel@bootlin.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.