All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ian Rogers" <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH v2 4/4] objtool: Add explicitly sequenced -lzstd to libopcodes fallback
Date: Wed, 09 Sep 2026 20:45:48 +0000	[thread overview]
Message-ID: <20260909204548.B5DFA1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260909204122.1993010-5-irogers@google.com>

> Distributions like Fedora currently ship a statically compiled binutils
> libbfd (an intrinsic dependency of libopcodes) that internally utilizes
> zstd to decompress sections.
> 
> Because objtool resolves host dependencies sequentially via a manual HOSTCC
> shell loop, build failures will occur (e.g. undefined reference to
> 'ZSTD_decompress') unless the loop probes for it.
> 
> Add the '-lopcodes -lbfd -liberty -lz -lzstd' combination to the fallback
> chain, assuring successful compilation on hosts packaging static binutils.
> 
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260909204122.1993010-1-irogers@google.com?part=4


  reply	other threads:[~2026-09-09 20:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-09 20:41 [PATCH v2 0/4] tools build: Fixes for libbfd -lzstd dependency Ian Rogers
2026-09-09 20:41 ` [PATCH v2 1/4] tools build: Add explicitly sequenced -lzstd to libbfd feature fallback Ian Rogers
2026-09-09 20:49   ` sashiko-bot
2026-09-09 20:41 ` [PATCH v2 2/4] perf " Ian Rogers
2026-09-09 20:48   ` sashiko-bot
2026-09-09 20:41 ` [PATCH v2 3/4] bpftool: " Ian Rogers
2026-09-09 20:44   ` sashiko-bot
2026-09-09 21:30   ` bot+bpf-ci
2026-09-10  9:20   ` Quentin Monnet
2026-09-10 15:37     ` Ian Rogers
2026-09-10 19:53       ` Quentin Monnet
2026-09-09 20:41 ` [PATCH v2 4/4] objtool: Add explicitly sequenced -lzstd to libopcodes fallback Ian Rogers
2026-09-09 20:45   ` sashiko-bot [this message]
2026-09-09 21:30   ` bot+bpf-ci
2026-09-09 22:06   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260909204548.B5DFA1F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=irogers@google.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.