From: sashiko-bot@kernel.org
To: "Aureo Serrano de Souza" <aureo.serrano@arctic.de>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 1/3] hwmon: arctic_fan_controller: default PWM cache to MCU 40%
Date: Thu, 10 Sep 2026 05:10:06 +0000 [thread overview]
Message-ID: <20260910051007.69A601F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260910050401.279868-2-aureo.serrano@arctic.de>
> The device has no GET_REPORT and every OUT report carries all 10
> channels, so the cache has to start at some value. Starting at 0
> means the first sysfs write to a single channel also sends 0% on
> the other nine.
>
> The MCU factory default is 40%. Initialize pwm_duty[] to 102 (40%
> on the 0-255 sysfs scale) at probe and on reset-resume. Any initial
> cache can be stale if the module is reloaded without a device
> reset. 40% matches the hardware after power-on or power-loss
> resume, and a first single-channel write leaves the fans running
> at a safe speed.
>
> PWM is still not taken from periodic IN reports: the device is
> manual-only and the host cache stays authoritative after the first
> successful write.
>
> Signed-off-by: Aureo Serrano de Souza <aureo.serrano@arctic.de>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260910050401.279868-1-aureo.serrano@arctic.de?part=1
next prev parent reply other threads:[~2026-09-10 5:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 5:03 [PATCH 0/3] hwmon: arctic_fan_controller: PWM default, dual license, maintainer contact Aureo Serrano de Souza
2026-09-10 5:03 ` [PATCH 1/3] hwmon: arctic_fan_controller: default PWM cache to MCU 40% Aureo Serrano de Souza
2026-09-10 5:10 ` sashiko-bot [this message]
2026-09-11 0:55 ` Guenter Roeck
2026-09-10 5:04 ` [PATCH 2/3] hwmon: arctic_fan_controller: dual-license GPL-2.0-or-later OR BSD-2-Clause Aureo Serrano de Souza
2026-09-10 5:07 ` sashiko-bot
2026-09-11 0:56 ` Guenter Roeck
2026-09-10 5:04 ` [PATCH 3/3] hwmon: arctic_fan_controller: use shared maintainer address Aureo Serrano de Souza
2026-09-11 0:57 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910051007.69A601F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=aureo.serrano@arctic.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.