From: Christoph Hellwig <hch@lst.de>
To: Julian Sun <sunjunchao@bytedance.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me,
kch@nvidia.com, armenx.baloyan@intel.com,
james.p.freyensee@intel.com, ming.l@ssi.samsung.com
Subject: Re: [PATCH 2/2] nvmet: reject enabling a namespace without a device path
Date: Thu, 10 Sep 2026 07:42:35 +0200 [thread overview]
Message-ID: <20260910054235.GC27511@lst.de> (raw)
In-Reply-To: <20260908033519.2721210-2-sunjunchao@bytedance.com>
On Tue, Sep 08, 2026 at 11:35:19AM +0800, Julian Sun wrote:
> With buffered I/O enabled, nvmet_bdev_ns_enable() returns -ENOTBLK
> before validating the device path. Enabling a namespace without setting
> device_path therefore passes NULL to filp_open() and crashes in
> getname_kernel().
>
> Reject enabling a namespace if no device path has been configured.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
Can you add test for this to blktests?
next prev parent reply other threads:[~2026-09-10 5:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 3:35 [PATCH 1/2] nvmet: preserve device path on allocation failure Julian Sun
2026-09-08 3:35 ` [PATCH 2/2] nvmet: reject enabling a namespace without a device path Julian Sun
2026-09-10 5:42 ` Christoph Hellwig [this message]
2026-09-10 5:47 ` Julian Sun
2026-09-10 5:25 ` [PATCH 1/2] nvmet: preserve device path on allocation failure Christoph Hellwig
2026-09-10 5:35 ` Julian Sun
2026-09-10 5:37 ` Christoph Hellwig
2026-09-10 5:42 ` Christoph Hellwig
2026-09-11 14:45 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910054235.GC27511@lst.de \
--to=hch@lst.de \
--cc=armenx.baloyan@intel.com \
--cc=james.p.freyensee@intel.com \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.l@ssi.samsung.com \
--cc=sagi@grimberg.me \
--cc=sunjunchao@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.