Re: [PATCH v3 1/2] dt-bindings: hwmon: pmbus: Add Infineon tda38740 and tda38725

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The `compatible` property description advises violating Devicetree hardware description principles, and the schema incorrectly restricts standard fallback usage.
- [Low] The generic node name in the example does not reflect the primary function of the device.
--

commit 082d97c0bf8403a18b54faadfc2b22f3ff1da139
Author: Colin Huang <u8813345@gmail.com>

dt-bindings: hwmon: pmbus: Add Infineon tda38740 and tda38725
    
Add devicetree bindings for the Infineon TDA38740 and TDA38725
single-voltage synchronous buck regulators with PMBus interface.

> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38740.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38740.yaml
> new file mode 100644
> index 0000000000000..28e6ff9d9d9c1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38740.yaml
> @@ -0,0 +1,87 @@
[ ... ]
> +properties:
> +  compatible:
> +    oneOf:
> +      - const: infineon,tda38740
> +      - const: infineon,tda38725
> +    description: |
> +      The Infineon TDA38740 and TDA38725 share the same PMBus programming
> +      model. Use infineon,tda38740 as the preferred compatible string;
> +      infineon,tda38725 is kept as a compatibility alias.

[Severity: Medium]
Is the guidance to use infineon,tda38740 for TDA38725 hardware correct?
Devicetree typically requires accurately describing the specific hardware
present.

Also, does this oneOf with const restrict standard compatible string
fallbacks? If an author tries to use a standard fallback like:

    compatible = "infineon,tda38725", "infineon,tda38740";

it would fail schema validation because it restricts the property to a
single string instead of an array.

Shouldn't a simple list of allowed single strings use enum instead of oneOf
per dt-schema rules?

[ ... ]
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        sensor@40 {

[Severity: Low]
Does the generic node name sensor@40 reflect the primary function of this
synchronous buck regulator? According to the Devicetree Specification, the
node name should describe the primary function (e.g., regulator@40).

> +            compatible = "infineon,tda38740";
> +            reg = <0x40>;
> +            infineon,vout-scale-micro = <1071000>;
> +        };
> +    };
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910-add-tda38740-and-tda38725-v3-0-3e87637da3d6@gmail.com?part=1