Re: [PATCH v3 1/2] dt-bindings: iio: light: add as7343

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The generic LED property `led-max-microamp` was incorrectly added with a vendor prefix (`ams,led-max-microamp`), contradicting the commit message and standard property conventions.
--

commit bc94ab43a595b8c728d510d6725b14dbeb5f151f
Author: Chang Yu <marcus.yu.56@gmail.com>

dt-bindings: iio: light: add as7343

Add binding for AMS AS7343 which is a 14-channel multi-spectral sensor
with i2c address of 0x39.

> diff --git a/Documentation/devicetree/bindings/iio/light/ams,as7343.yaml b/Documentation/devicetree/bindings/iio/light/ams,as7343.yaml
> new file mode 100644
> index 0000000000000..6b8a05be00430
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/ams,as7343.yaml
[ ... ]
> +  vdd-supply: true
> +
> +  ams,led-max-microamp:

[Severity: Medium]
Should this property be defined without the vendor prefix?

The generic LED property led-max-microamp is added here with a vendor
prefix (ams,led-max-microamp), which contradicts standard property
conventions and the stated intent in the patch version changelog.

Device trees written for this device will use this vendor-prefixed
property, creating permanent ABI baggage. If a driver later implements
this feature and correctly parses the standard led-max-microamp, it will
break compatibility with these early device trees or force the driver to
parse both properties.

> +    description:
> +      The driver current for the external LED connected to the LDR pin.
> +    minimum: 4000
> +    maximum: 258000
> +    multipleOf: 2000
> +    default: 12000
> +
[ ... ]
> +        multispectral-sensor@39 {
> +            compatible = "ams,as7343";
> +            reg = <0x39>;
> +            interrupts = <7 IRQ_TYPE_LEVEL_LOW>;
> +            vdd-supply = <&vdd_regulator>;
> +            ams,led-max-microamp = <14000>;

[Severity: Medium]
Would it be better to also remove the vendor prefix from this property in the
device tree example?

> +            sync-gpios = <&gpio0 6 GPIO_ACTIVE_LOW>;
> +        };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910063813.56419-1-marcus.yu.56@gmail.com?part=1