From: sashiko-bot@kernel.org
To: "Sergio Melas" <sergiomelas@gmail.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v3] Documentation: hwmon: (yogafan) adjust table alignment for long model name
Date: Thu, 10 Sep 2026 07:49:16 +0000 [thread overview]
Message-ID: <20260910074916.93F211F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260910074505.1077544-1-sergiomelas@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch silently introduces undocumented model additions and modifications to the hardware support table, which contradicts the commit message.
--
commit ecc05eb9d5cd9f6474be8ef3ef43d5a812bf701e
Author: Sergio Melas <sergiomelas@gmail.com>
Documentation: hwmon: (yogafan) adjust table alignment for long model name
This commit updates the reStructuredText table layout in the yogafan
documentation to accommodate a longer product family string for the newly
added IdeaPad 3 15ALC6 Ub model, preventing Sphinx build warnings.
> Update the reStructuredText table layout and column separators to
> accommodate the longer product family string for the newly added IdeaPad
> model (IdeaPad 3 15ALC6 Ub). This prevents Sphinx build warnings and
> maintains proper visual alignment.
> diff --git a/Documentation/hwmon/yogafan.rst b/Documentation/hwmon/yogafan.rst
> index 9ff5db5dc08ce..239c7b5761caf 100644
> --- a/Documentation/hwmon/yogafan.rst
> +++ b/Documentation/hwmon/yogafan.rst
> @@ -85,28 +85,30 @@ immediately to ensure the user knows the fan has stopped.
>
> ::
>
> - MODEL (DMI PN) | FAMILY / SERIES | EC OFFSET | FULL ACPI OBJECT PATH | WIDTH | MULTiplier
> - ----------------------------------------------------------------------------------------------------
> - 82N7 | Yoga 14cACN | 0x06 | \_SB.PCI0.LPC0.EC0.FANS | 8-bit | 100
> - 80V2 / 81C3 | Yoga 710/720 | 0x06 | \_SB.PCI0.LPC0.EC0.FAN0 | 8-bit | 100
[ ... ]
> + MODEL (DMI PN) | FAMILY / SERIES | EC OFFSET | FULL ACPI OBJECT PATH | WIDTH | MULTiplier
> + -------------------------------------------------------------------------------------------------------
> + 82N7 | Yoga 14cACN 2021 | 0x06 | \_SB.PCI0.LPC0.EC0.FANS | 8-bit | 100
> + 81TD | Yoga 740-15IML | 0x06 | \_SB.PCI0.LPCB.EC0.FANS | 8-bit | 100
> + 82KU | IdeaPad 3 15ALC6 Ub | 0x06 | \_SB.PCI0.LPC0.EC0.FANS/FA2S | 8-bit | 100
[Severity: Medium]
The commit message states this patch only adjusts table alignment to
accommodate the newly added IdeaPad 3 15ALC6 Ub model. However, it appears
this patch also silently adds an entirely new model (81TD | Yoga 740-15IML)
and modifies the name of an existing model (Yoga 14cACN to Yoga 14cACN 2021).
Should these unrelated hardware support additions and modifications be split
into a separate patch or explicitly mentioned in the commit message to
accurately reflect the changes made?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260910074505.1077544-1-sergiomelas@gmail.com?part=1
next prev parent reply other threads:[~2026-09-10 7:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 7:45 [PATCH v3] Documentation: hwmon: (yogafan) adjust table alignment for long model name Sergio Melas
2026-09-10 7:49 ` sashiko-bot [this message]
2026-09-10 15:20 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910074916.93F211F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sergiomelas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.