From: Peter Zijlstra <peterz@infradead.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: x86@kernel.org, linux-um@lists.infradead.org,
linux-raid@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v5 6/8] x86/fpu: Remove cpu_has_xfeatures()
Date: Thu, 10 Sep 2026 10:38:01 +0200 [thread overview]
Message-ID: <20260910083801.GU4121339@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20260901145740.42337-7-ebiggers@kernel.org>
On Tue, Sep 01, 2026 at 07:57:38AM -0700, Eric Biggers wrote:
> The only remaining caller of cpu_has_xfeatures() is
> print_xstate_features(), which uses it only to check and get the name of
> a single feature.
>
> Remove it and just inline the needed code into print_xstate_features().
>
> This also makes the "unknown xstate feature" entry at index XFEATURE_MAX
> of xfeature_names[] unnecessary, so remove that too.
>
> Acked-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
Turns out there are a few new ones in tip/perf/core, so if you merge
tip/x86/fpu and tip/perf/core things no longer build.
I'm not entirely sure how to go about fixing this. Some seem trivial
enough, but others, like XFEATURE_MASK_OPMASK I don't readily see a
replacement for.
Boris, can you have a look? For now I'm reverting this patch locally.
next prev parent reply other threads:[~2026-09-10 8:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 14:57 [PATCH v5 0/8] x86: Remove cpu_has_xfeatures() and add AVX-512 xor_gen() Eric Biggers
2026-09-01 14:57 ` [PATCH v5 1/8] x86/fpu: Check for missing AVX and AVX-512 xstate bits Eric Biggers
2026-09-01 14:57 ` [PATCH v5 2/8] um: " Eric Biggers
2026-09-01 15:11 ` sashiko-bot
2026-09-01 14:57 ` [PATCH v5 3/8] crypto: x86 - Stop using cpu_has_xfeatures() Eric Biggers
2026-09-01 14:57 ` [PATCH v5 4/8] lib/crypto: x86: " Eric Biggers
2026-09-01 14:57 ` [PATCH v5 5/8] lib/crc: " Eric Biggers
2026-09-01 14:57 ` [PATCH v5 6/8] x86/fpu: Remove cpu_has_xfeatures() Eric Biggers
2026-09-10 8:38 ` Peter Zijlstra [this message]
2026-09-10 14:23 ` Borislav Petkov
2026-09-10 14:59 ` Eric Biggers
2026-09-10 15:44 ` Borislav Petkov
2026-09-01 14:57 ` [PATCH v5 7/8] xor: Remove redundant X86_FEATURE_OSXSAVE check Eric Biggers
2026-09-01 14:57 ` [PATCH v5 8/8] xor: Add AVX-512 optimized xor_gen() Eric Biggers
2026-09-02 17:11 ` [PATCH v5 0/8] x86: Remove cpu_has_xfeatures() and add AVX-512 xor_gen() Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910083801.GU4121339@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=ebiggers@kernel.org \
--cc=hch@lst.de \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.