From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C13CF36C5B4 for ; Thu, 10 Sep 2026 09:35:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789032914; cv=none; b=neT1o4K6P9SpghD44E3dKGkNqYRUepT7a9WCp8bKVRsDrSqHbzrBBiNkhwciLtOKdUSOEyFb35av+2cfNAyxLkiBmurdDv+fASoq26iIF/thYZkT6r0uKAVIcKSz8uczrA14ZBAy2JI3hFSwF0NpI5N21+/wlO9CxH3AZJI2j1I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789032914; c=relaxed/simple; bh=H0BXrity824CdrnSWHHo+JxTAKF1tP1krJwYkKcmQp4=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=pAkoe4RIrBkx+DB/Qx/3fIpH8gqwbuq0dGTjOXAs4CRklSUMbyrpvqHEGg3mObH3jYYFY7s2YEun3nAcoCB1M2UMBlPUqReXCmELOUHgOCNNhKkJItbkwHN43RRV3wbkdiRGtlA1HFOXW5yZ4+xiPzlrsthIwXUm3OCbqAztVbw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=T14sobBz; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T14sobBz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1AF2E1F000FF; Thu, 10 Sep 2026 09:35:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789032912; bh=8Nrqvf9ZUOw7Ek+ftup4a1e0+6fM3t6Iq3bdnj7iZjs=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=T14sobBzIzIWI/bDHdIRbvufMwvgHyakiFGYUWzzq4RbZo1m8rnmgHiKwzsfVUktl z4D9XUpEoW9EQkFCjiGTuU/I0FDLooVWiaO7aIi7a7aq6pg13Q5e75WQuDvw6kVD43 OFEmcLjJiqvElIgH1NzJoiuoRIIZ5Stc96HCwOxby2lhe9PdNiQ1nTTIGIjiFIR1Od OztFoC4wNGCLdRuxkYWNj/zDOSS9uUddhiaF1yASvUZirCwR3RBcTJqJPpoBSnQdKC 1XYCejUFcfnwfDIkW98BBfYYHgJEh+DGLbOn43cLN0blToFwpP5c+m9Hd8sQxuvUFu yOXG8GHrz+KYA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 08/12] phy: phy-mtk-dp: Add support for digital and analog calibration Reply-To: sashiko-reviews@lists.linux.dev To: "AngeloGioacchino Del Regno" Cc: dri-devel@lists.freedesktop.org, vkoul@kernel.org, neil.armstrong@linaro.org, devicetree@vger.kernel.org, robh@kernel.org, olteanv@gmail.com, linux-phy@lists.infradead.org, conor+dt@kernel.org In-Reply-To: <20260910092038.48291-9-angelogioacchino.delregno@collabora.com> References: <20260910092038.48291-1-angelogioacchino.delregno@collabora.com> <20260910092038.48291-9-angelogioacchino.delregno@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 10 Sep 2026 09:35:11 +0000 Message-Id: <20260910093512.1AF2E1F000FF@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 3 potential issue(= s) to consider: - [Medium] Silent ignoring of hardware write failures during PHY initializa= tion. - [Medium] False positive error logs emitted when optional eFuse calibratio= n data is missing. - [Low] Unused variables left over from refactoring (`dev` and `ret`). -- commit 7b4b9550381f2fc0574d6e28361a57bed4016c26 Author: AngeloGioacchino Del Regno phy: phy-mtk-dp: Add support for digital and analog calibration This commit adds support for reading DP PHY calibration values from eFuse. If calibration values are present, they are written to the PHY; otherwise, the driver falls back to default SoC-specific values. It also adds support for writing the calibration values for the analog part of the PHY. > diff --git a/drivers/phy/mediatek/phy-mtk-dp.c b/drivers/phy/mediatek/phy= -mtk-dp.c > index 692049f788332..2f4cf52d922c1 100644 > --- a/drivers/phy/mediatek/phy-mtk-dp.c > +++ b/drivers/phy/mediatek/phy-mtk-dp.c [ ... ] > -static int mtk_dp_phy_init(struct phy *phy) > +static void mtk_dp_phy_set_digital_drv_params(struct mtk_dp_phy *dp_phy) > { > - struct mtk_dp_phy *dp_phy =3D phy_get_drvdata(phy); > const struct mtk_dp_phy_pdata *pdata =3D dp_phy->pdata; > const u32 reg =3D pdata->regs_dig_lane[DP_PHYD_LAN_DRIVING_PARAM_0]; > - static const u32 driving_params[] =3D { [ ... ] > - }; > int i, ret; [Severity: Low] Is `ret` still needed here? The return checks for regmap bulk writes were removed below, which appears to leave this variable completely unused. > =20 > /* [ ... ] > - for (i =3D 0; i < MTK_DP_PHY_MAX_LANES; i++) { > - ret =3D regmap_bulk_write(dp_phy->regmap, > - pdata->off_dig_lane[i] + reg, > - driving_params, > - ARRAY_SIZE(driving_params)); > - if (ret) > - return ret; > - }; > + for (i =3D 0; i < MTK_DP_PHY_MAX_LANES; i++) > + regmap_bulk_write(dp_phy->regmap, pdata->off_dig_lane[i] + reg, > + pdata->driving_params, > + ARRAY_SIZE(pdata->driving_params)); > +} [Severity: Medium] Does this code introduce a regression by silently ignoring hardware write failures during PHY initialization? Prior to this patch, if regmap_bulk_write() failed, the error was propagated back to the caller. Now that this has been extracted into a void function, any hardware or bus errors during these bulk writes will be silently droppe= d. > + > +static int mtk_dp_phy_init(struct phy *phy) > +{ > + struct mtk_dp_phy *dp_phy =3D phy_get_drvdata(phy); > + struct device *dev =3D &phy->dev; [Severity: Low] Is the `dev` variable used anywhere in this function? It appears to be declared and assigned but never utilized. > + > + mtk_dp_phy_set_digital_drv_params(dp_phy); > + mtk_dp_phy_set_analog_calibration_params(dp_phy); > =20 > return 0; > } [Severity: Medium] Does the PHY initialization now unconditionally succeed regardless of the underlying hardware state? Because the extracted functions mtk_dp_phy_set_digital_drv_params() and mtk_dp_phy_set_analog_calibration_params() return void, any failures during regmap updates will not be caught, and this function will always improperly return 0 on failure. [ ... ] > +static int mtk_dp_phy_get_one_cal_para(struct device *dev, const char *n= ame, u8 max_val) > +{ > + u8 buf_byte; > + u16 buf; > + int ret; > + [ ... ] > + ret =3D nvmem_cell_read_u8(dev, name, &buf_byte); > + if (ret) > + ret =3D nvmem_cell_read_u16(dev, name, &buf); > + else > + buf =3D buf_byte; > + > + if (ret) > + return dev_err_probe(dev, ret, "Cannot get calibration data for %s\n",= name); [Severity: Medium] Will this cause false positive error logs on normal boots? If an NVMEM cell is missing, the nvmem read functions naturally return -ENOENT. This dev_err_probe() triggers a KERN_ERR log here before returning the error to the caller. > + > + if (buf =3D=3D 0) { [ ... ] > +static int mtk_dp_phy_get_calibration_data(struct mtk_dp_phy *dp_phy) > +{ [ ... ] > +end: > + if (ret < 0) { > + /* > + * If any of the calibration values is missing, or if there > + * is no calibration at all in the eFuses, copy the default > + * one entirely (as partial values shall not be mixed!) > + */ > + if (ret =3D=3D -ENOENT) { > + dev_info(dev, "Using calibration default values\n"); > + mtk_dp_phy_get_default_cal_data(dp_phy); > + return 0; > + } [Severity: Medium] Since -ENOENT is explicitly checked and handled gracefully as a benign fallback here, should we avoid logging it as an error in mtk_dp_phy_get_one_cal_para() earlier? Logging an expected missing cell as an error falsely spams the kernel dmesg with an error trace for boards that legitimately omit calibration data. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260910092038.4829= 1-1-angelogioacchino.delregno@collabora.com?part=3D8 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B7F5C79FB9 for ; Thu, 10 Sep 2026 09:35:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XTBiDGFq6PBHnF54gw7Wc2BzMCF6MxPSl2AlcnkGkJI=; b=TgA+96wfQoiH3E gnOQwY+tG9z4PaL/aQA71KlyiwoAxVv5xlVglISBrC0q6BcMymi1DA8pL+L4ekazsPriR8L6a/CVE rUU4ESEiaYuDVlbgKmv7iKzPuuWIEjYGsDOh7xsXPqmt6eaba6A482fsx4SkWpAqyjzvNiCyIsDt5 fRK/pkRrbE1qA/f2b1kM0e76UIPpqHll+EA+sqKr0R0eHHZqHbmvuuOLQut9VFgjuoBKe+KJJJEKw 8KxONn0mQgqFMCb9fYu3OEZx4s/U7fL7qpaL8EkayaY5WqOn7FuQ3t50gcPnLMbbaTc3MyR2/phRQ KkZqdpKS7eCCvRFT8kxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x4bBb-0000000DuOd-02DQ; Thu, 10 Sep 2026 09:35:15 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x4bBZ-0000000DuOL-24LR for linux-phy@lists.infradead.org; Thu, 10 Sep 2026 09:35:13 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id E7DE2600C8; Thu, 10 Sep 2026 09:35:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1AF2E1F000FF; Thu, 10 Sep 2026 09:35:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789032912; bh=8Nrqvf9ZUOw7Ek+ftup4a1e0+6fM3t6Iq3bdnj7iZjs=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=T14sobBzIzIWI/bDHdIRbvufMwvgHyakiFGYUWzzq4RbZo1m8rnmgHiKwzsfVUktl z4D9XUpEoW9EQkFCjiGTuU/I0FDLooVWiaO7aIi7a7aq6pg13Q5e75WQuDvw6kVD43 OFEmcLjJiqvElIgH1NzJoiuoRIIZ5Stc96HCwOxby2lhe9PdNiQ1nTTIGIjiFIR1Od OztFoC4wNGCLdRuxkYWNj/zDOSS9uUddhiaF1yASvUZirCwR3RBcTJqJPpoBSnQdKC 1XYCejUFcfnwfDIkW98BBfYYHgJEh+DGLbOn43cLN0blToFwpP5c+m9Hd8sQxuvUFu yOXG8GHrz+KYA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 08/12] phy: phy-mtk-dp: Add support for digital and analog calibration To: "AngeloGioacchino Del Regno" Cc: dri-devel@lists.freedesktop.org, vkoul@kernel.org, neil.armstrong@linaro.org, devicetree@vger.kernel.org, robh@kernel.org, olteanv@gmail.com, linux-phy@lists.infradead.org, conor+dt@kernel.org In-Reply-To: <20260910092038.48291-9-angelogioacchino.delregno@collabora.com> References: <20260910092038.48291-1-angelogioacchino.delregno@collabora.com> <20260910092038.48291-9-angelogioacchino.delregno@collabora.com> Date: Thu, 10 Sep 2026 09:35:11 +0000 Message-Id: <20260910093512.1AF2E1F000FF@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MyBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gU2lsZW50IGlnbm9y aW5nIG9mIGhhcmR3YXJlIHdyaXRlIGZhaWx1cmVzIGR1cmluZyBQSFkgaW5pdGlhbGl6YXRpb24u Ci0gW01lZGl1bV0gRmFsc2UgcG9zaXRpdmUgZXJyb3IgbG9ncyBlbWl0dGVkIHdoZW4gb3B0aW9u YWwgZUZ1c2UgY2FsaWJyYXRpb24gZGF0YSBpcyBtaXNzaW5nLgotIFtMb3ddIFVudXNlZCB2YXJp YWJsZXMgbGVmdCBvdmVyIGZyb20gcmVmYWN0b3JpbmcgKGBkZXZgIGFuZCBgcmV0YCkuCi0tCgpj b21taXQgN2I0Yjk1NTAzODFmMmZjMDU3NGQ2ZTI4MzYxYTU3YmVkNDAxNmMyNgpBdXRob3I6IEFu Z2Vsb0dpb2FjY2hpbm8gRGVsIFJlZ25vIDxhbmdlbG9naW9hY2NoaW5vLmRlbHJlZ25vQGNvbGxh Ym9yYS5jb20+CgpwaHk6IHBoeS1tdGstZHA6IEFkZCBzdXBwb3J0IGZvciBkaWdpdGFsIGFuZCBh bmFsb2cgY2FsaWJyYXRpb24KClRoaXMgY29tbWl0IGFkZHMgc3VwcG9ydCBmb3IgcmVhZGluZyBE UCBQSFkgY2FsaWJyYXRpb24gdmFsdWVzIGZyb20gZUZ1c2UuCklmIGNhbGlicmF0aW9uIHZhbHVl cyBhcmUgcHJlc2VudCwgdGhleSBhcmUgd3JpdHRlbiB0byB0aGUgUEhZOyBvdGhlcndpc2UsCnRo ZSBkcml2ZXIgZmFsbHMgYmFjayB0byBkZWZhdWx0IFNvQy1zcGVjaWZpYyB2YWx1ZXMuIEl0IGFs c28gYWRkcyBzdXBwb3J0CmZvciB3cml0aW5nIHRoZSBjYWxpYnJhdGlvbiB2YWx1ZXMgZm9yIHRo ZSBhbmFsb2cgcGFydCBvZiB0aGUgUEhZLgoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9waHkvbWVk aWF0ZWsvcGh5LW10ay1kcC5jIGIvZHJpdmVycy9waHkvbWVkaWF0ZWsvcGh5LW10ay1kcC5jCj4g aW5kZXggNjkyMDQ5Zjc4ODMzMi4uMmY0Y2Y1MmQ5MjJjMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L3BoeS9tZWRpYXRlay9waHktbXRrLWRwLmMKPiArKysgYi9kcml2ZXJzL3BoeS9tZWRpYXRlay9w aHktbXRrLWRwLmMKWyAuLi4gXQo+IC1zdGF0aWMgaW50IG10a19kcF9waHlfaW5pdChzdHJ1Y3Qg cGh5ICpwaHkpCj4gK3N0YXRpYyB2b2lkIG10a19kcF9waHlfc2V0X2RpZ2l0YWxfZHJ2X3BhcmFt cyhzdHJ1Y3QgbXRrX2RwX3BoeSAqZHBfcGh5KQo+ICB7Cj4gLQlzdHJ1Y3QgbXRrX2RwX3BoeSAq ZHBfcGh5ID0gcGh5X2dldF9kcnZkYXRhKHBoeSk7Cj4gIAljb25zdCBzdHJ1Y3QgbXRrX2RwX3Bo eV9wZGF0YSAqcGRhdGEgPSBkcF9waHktPnBkYXRhOwo+ICAJY29uc3QgdTMyIHJlZyA9IHBkYXRh LT5yZWdzX2RpZ19sYW5lW0RQX1BIWURfTEFOX0RSSVZJTkdfUEFSQU1fMF07Cj4gLQlzdGF0aWMg Y29uc3QgdTMyIGRyaXZpbmdfcGFyYW1zW10gPSB7ClsgLi4uIF0KPiAtCX07Cj4gIAlpbnQgaSwg cmV0OwoKW1NldmVyaXR5OiBMb3ddCklzIGByZXRgIHN0aWxsIG5lZWRlZCBoZXJlPyBUaGUgcmV0 dXJuIGNoZWNrcyBmb3IgcmVnbWFwIGJ1bGsgd3JpdGVzIHdlcmUKcmVtb3ZlZCBiZWxvdywgd2hp Y2ggYXBwZWFycyB0byBsZWF2ZSB0aGlzIHZhcmlhYmxlIGNvbXBsZXRlbHkgdW51c2VkLgoKPiAg Cj4gIAkvKgpbIC4uLiBdCj4gLQlmb3IgKGkgPSAwOyBpIDwgTVRLX0RQX1BIWV9NQVhfTEFORVM7 IGkrKykgewo+IC0JCXJldCA9IHJlZ21hcF9idWxrX3dyaXRlKGRwX3BoeS0+cmVnbWFwLAo+IC0J CQkJCXBkYXRhLT5vZmZfZGlnX2xhbmVbaV0gKyByZWcsCj4gLQkJCQkJZHJpdmluZ19wYXJhbXMs Cj4gLQkJCQkJQVJSQVlfU0laRShkcml2aW5nX3BhcmFtcykpOwo+IC0JCWlmIChyZXQpCj4gLQkJ CXJldHVybiByZXQ7Cj4gLQl9Owo+ICsJZm9yIChpID0gMDsgaSA8IE1US19EUF9QSFlfTUFYX0xB TkVTOyBpKyspCj4gKwkJcmVnbWFwX2J1bGtfd3JpdGUoZHBfcGh5LT5yZWdtYXAsIHBkYXRhLT5v ZmZfZGlnX2xhbmVbaV0gKyByZWcsCj4gKwkJCQkgIHBkYXRhLT5kcml2aW5nX3BhcmFtcywKPiAr CQkJCSAgQVJSQVlfU0laRShwZGF0YS0+ZHJpdmluZ19wYXJhbXMpKTsKPiArfQoKW1NldmVyaXR5 OiBNZWRpdW1dCkRvZXMgdGhpcyBjb2RlIGludHJvZHVjZSBhIHJlZ3Jlc3Npb24gYnkgc2lsZW50 bHkgaWdub3JpbmcgaGFyZHdhcmUgd3JpdGUKZmFpbHVyZXMgZHVyaW5nIFBIWSBpbml0aWFsaXph dGlvbj8KClByaW9yIHRvIHRoaXMgcGF0Y2gsIGlmIHJlZ21hcF9idWxrX3dyaXRlKCkgZmFpbGVk LCB0aGUgZXJyb3Igd2FzIHByb3BhZ2F0ZWQKYmFjayB0byB0aGUgY2FsbGVyLiBOb3cgdGhhdCB0 aGlzIGhhcyBiZWVuIGV4dHJhY3RlZCBpbnRvIGEgdm9pZCBmdW5jdGlvbiwKYW55IGhhcmR3YXJl IG9yIGJ1cyBlcnJvcnMgZHVyaW5nIHRoZXNlIGJ1bGsgd3JpdGVzIHdpbGwgYmUgc2lsZW50bHkg ZHJvcHBlZC4KCj4gKwo+ICtzdGF0aWMgaW50IG10a19kcF9waHlfaW5pdChzdHJ1Y3QgcGh5ICpw aHkpCj4gK3sKPiArCXN0cnVjdCBtdGtfZHBfcGh5ICpkcF9waHkgPSBwaHlfZ2V0X2RydmRhdGEo cGh5KTsKPiArCXN0cnVjdCBkZXZpY2UgKmRldiA9ICZwaHktPmRldjsKCltTZXZlcml0eTogTG93 XQpJcyB0aGUgYGRldmAgdmFyaWFibGUgdXNlZCBhbnl3aGVyZSBpbiB0aGlzIGZ1bmN0aW9uPyBJ dCBhcHBlYXJzIHRvIGJlCmRlY2xhcmVkIGFuZCBhc3NpZ25lZCBidXQgbmV2ZXIgdXRpbGl6ZWQu Cgo+ICsKPiArCW10a19kcF9waHlfc2V0X2RpZ2l0YWxfZHJ2X3BhcmFtcyhkcF9waHkpOwo+ICsJ bXRrX2RwX3BoeV9zZXRfYW5hbG9nX2NhbGlicmF0aW9uX3BhcmFtcyhkcF9waHkpOwo+ICAKPiAg CXJldHVybiAwOwo+ICB9CgpbU2V2ZXJpdHk6IE1lZGl1bV0KRG9lcyB0aGUgUEhZIGluaXRpYWxp emF0aW9uIG5vdyB1bmNvbmRpdGlvbmFsbHkgc3VjY2VlZCByZWdhcmRsZXNzIG9mCnRoZSB1bmRl cmx5aW5nIGhhcmR3YXJlIHN0YXRlPwoKQmVjYXVzZSB0aGUgZXh0cmFjdGVkIGZ1bmN0aW9ucyBt dGtfZHBfcGh5X3NldF9kaWdpdGFsX2Rydl9wYXJhbXMoKSBhbmQKbXRrX2RwX3BoeV9zZXRfYW5h bG9nX2NhbGlicmF0aW9uX3BhcmFtcygpIHJldHVybiB2b2lkLCBhbnkgZmFpbHVyZXMKZHVyaW5n IHJlZ21hcCB1cGRhdGVzIHdpbGwgbm90IGJlIGNhdWdodCwgYW5kIHRoaXMgZnVuY3Rpb24gd2ls bCBhbHdheXMKaW1wcm9wZXJseSByZXR1cm4gMCBvbiBmYWlsdXJlLgoKWyAuLi4gXQo+ICtzdGF0 aWMgaW50IG10a19kcF9waHlfZ2V0X29uZV9jYWxfcGFyYShzdHJ1Y3QgZGV2aWNlICpkZXYsIGNv bnN0IGNoYXIgKm5hbWUsIHU4IG1heF92YWwpCj4gK3sKPiArCXU4IGJ1Zl9ieXRlOwo+ICsJdTE2 IGJ1ZjsKPiArCWludCByZXQ7Cj4gKwpbIC4uLiBdCj4gKwlyZXQgPSBudm1lbV9jZWxsX3JlYWRf dTgoZGV2LCBuYW1lLCAmYnVmX2J5dGUpOwo+ICsJaWYgKHJldCkKPiArCQlyZXQgPSBudm1lbV9j ZWxsX3JlYWRfdTE2KGRldiwgbmFtZSwgJmJ1Zik7Cj4gKwllbHNlCj4gKwkJYnVmID0gYnVmX2J5 dGU7Cj4gKwo+ICsJaWYgKHJldCkKPiArCQlyZXR1cm4gZGV2X2Vycl9wcm9iZShkZXYsIHJldCwg IkNhbm5vdCBnZXQgY2FsaWJyYXRpb24gZGF0YSBmb3IgJXNcbiIsIG5hbWUpOwoKW1NldmVyaXR5 OiBNZWRpdW1dCldpbGwgdGhpcyBjYXVzZSBmYWxzZSBwb3NpdGl2ZSBlcnJvciBsb2dzIG9uIG5v cm1hbCBib290cz8KCklmIGFuIE5WTUVNIGNlbGwgaXMgbWlzc2luZywgdGhlIG52bWVtIHJlYWQg ZnVuY3Rpb25zIG5hdHVyYWxseSByZXR1cm4KLUVOT0VOVC4gVGhpcyBkZXZfZXJyX3Byb2JlKCkg dHJpZ2dlcnMgYSBLRVJOX0VSUiBsb2cgaGVyZSBiZWZvcmUgcmV0dXJuaW5nCnRoZSBlcnJvciB0 byB0aGUgY2FsbGVyLgoKPiArCj4gKwlpZiAoYnVmID09IDApIHsKWyAuLi4gXQo+ICtzdGF0aWMg aW50IG10a19kcF9waHlfZ2V0X2NhbGlicmF0aW9uX2RhdGEoc3RydWN0IG10a19kcF9waHkgKmRw X3BoeSkKPiArewpbIC4uLiBdCj4gK2VuZDoKPiArCWlmIChyZXQgPCAwKSB7Cj4gKwkJLyoKPiAr CQkgKiBJZiBhbnkgb2YgdGhlIGNhbGlicmF0aW9uIHZhbHVlcyBpcyBtaXNzaW5nLCBvciBpZiB0 aGVyZQo+ICsJCSAqIGlzIG5vIGNhbGlicmF0aW9uIGF0IGFsbCBpbiB0aGUgZUZ1c2VzLCBjb3B5 IHRoZSBkZWZhdWx0Cj4gKwkJICogb25lIGVudGlyZWx5IChhcyBwYXJ0aWFsIHZhbHVlcyBzaGFs bCBub3QgYmUgbWl4ZWQhKQo+ICsJCSAqLwo+ICsJCWlmIChyZXQgPT0gLUVOT0VOVCkgewo+ICsJ CQlkZXZfaW5mbyhkZXYsICJVc2luZyBjYWxpYnJhdGlvbiBkZWZhdWx0IHZhbHVlc1xuIik7Cj4g KwkJCW10a19kcF9waHlfZ2V0X2RlZmF1bHRfY2FsX2RhdGEoZHBfcGh5KTsKPiArCQkJcmV0dXJu IDA7Cj4gKwkJfQoKW1NldmVyaXR5OiBNZWRpdW1dClNpbmNlIC1FTk9FTlQgaXMgZXhwbGljaXRs eSBjaGVja2VkIGFuZCBoYW5kbGVkIGdyYWNlZnVsbHkgYXMgYSBiZW5pZ24KZmFsbGJhY2sgaGVy ZSwgc2hvdWxkIHdlIGF2b2lkIGxvZ2dpbmcgaXQgYXMgYW4gZXJyb3IgaW4KbXRrX2RwX3BoeV9n ZXRfb25lX2NhbF9wYXJhKCkgZWFybGllcj8KCkxvZ2dpbmcgYW4gZXhwZWN0ZWQgbWlzc2luZyBj ZWxsIGFzIGFuIGVycm9yIGZhbHNlbHkgc3BhbXMgdGhlIGtlcm5lbCBkbWVzZwp3aXRoIGFuIGVy cm9yIHRyYWNlIGZvciBib2FyZHMgdGhhdCBsZWdpdGltYXRlbHkgb21pdCBjYWxpYnJhdGlvbiBk YXRhLgoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRj aHNldC8yMDI2MDkxMDA5MjAzOC40ODI5MS0xLWFuZ2Vsb2dpb2FjY2hpbm8uZGVscmVnbm9AY29s bGFib3JhLmNvbT9wYXJ0PTgKCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LXBoeQo=