Re: [PATCH v2 1/6] ASoC: dt-bindings: qcom: Add Shikra RX and VA macro compatibles

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing `if-then` conditional constraints for the newly added `qcom,shikra-lpass-rx-macro` and `qcom,shikra-lpass-va-macro` compatible strings.
--

commit fd8a851e254921359c89e0a86263375bd7af870d
Author: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>

ASoC: dt-bindings: qcom: Add Shikra RX and VA macro compatibles

Add bindings for Qualcomm shikra rx and va macro codec.
Shikra integrates LPASS codec version 4.1, which is not backwards
compatible with the already described compatibles.

> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
> index 4988e7ed6e34b..d2f68b02566b8 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
> @@ -19,6 +19,7 @@ properties:
>            - qcom,sm8450-lpass-rx-macro
>            - qcom,sm8550-lpass-rx-macro
>            - qcom,sc8280xp-lpass-rx-macro
> +          - qcom,shikra-lpass-rx-macro

[Severity: Medium]
Is there a missing update to the conditional constraints in the allOf section
for this new compatible string?

When validating a device tree containing the qcom,shikra-lpass-rx-macro
node, the schema validation might fall back to the loose top-level limits
instead of strictly enforcing the required clocks for this hardware variant
(e.g. mclk, npl, macro, dcodec, fsgen). Device trees with invalid clock
configurations could silently pass dt_binding_check validation.

Could we ensure the corresponding if-then block is added to enforce
constraints for clocks and clock-names?

>        - items:
>            - enum:
>                - qcom,eliza-lpass-rx-macro
> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
> index aea31fbdad376..23f00de82cd36 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
> @@ -19,6 +19,7 @@ properties:
>            - qcom,sm8450-lpass-va-macro
>            - qcom,sm8550-lpass-va-macro
>            - qcom,sc8280xp-lpass-va-macro
> +          - qcom,shikra-lpass-va-macro

[Severity: Medium]
Similarly, does the new qcom,shikra-lpass-va-macro compatible string also
need a matching conditional constraint block in the allOf section?

Like the rx-macro binding, schema validation could fall back to loose
top-level limits instead of strictly enforcing the required clocks for this
variant. This allows device trees with invalid clock configurations to
silently pass validation.

Should we add the required constraints for this variant as well?

>        - items:
>            - enum:
>                - qcom,eliza-lpass-va-macro

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910-add_shikra_support-v2-0-fdd2129c696c@oss.qualcomm.com?part=1