All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH v4 06/14] system: check security for machine types
Date: Thu, 10 Sep 2026 11:36:20 +0100	[thread overview]
Message-ID: <20260910103628.2326622-7-berrange@redhat.com> (raw)
In-Reply-To: <20260910103628.2326622-1-berrange@redhat.com>

This wires up the machine creation code to apply the compat policy
security check.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 system/vl.c | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/system/vl.c b/system/vl.c
index ca54da26c5..f54449b43e 100644
--- a/system/vl.c
+++ b/system/vl.c
@@ -2201,11 +2201,18 @@ static void qemu_create_machine_containers(Object *machine)
     }
 }
 
-static void qemu_create_machine(QDict *qdict)
+static bool qemu_create_machine(QDict *qdict)
 {
+    Error *local_err = NULL;
     MachineClass *machine_class = select_machine(qdict, &error_fatal);
     object_set_machine_compat_props(machine_class->compat_props);
 
+    if (!object_class_check_security(OBJECT_CLASS(machine_class),
+                                     &local_err)) {
+        error_report_err(local_err);
+        return false;
+    }
+
     current_machine = MACHINE(object_new_with_class(OBJECT_CLASS(machine_class)));
     object_property_add_child(object_get_root(), "machine",
                               OBJECT(current_machine));
@@ -2237,6 +2244,8 @@ static void qemu_create_machine(QDict *qdict)
                                      false, &error_abort);
         qobject_unref(default_opts);
     }
+
+    return true;
 }
 
 static int global_init_func(void *opaque, QemuOpts *opts, Error **errp)
@@ -3790,7 +3799,9 @@ void qemu_init(int argc, char **argv)
     /* Transfer QemuOpts options into machine options */
     parse_memory_options();
 
-    qemu_create_machine(machine_opts_dict);
+    if (!qemu_create_machine(machine_opts_dict)) {
+        exit(1);
+    }
 
     /*
      * Load incoming CPR state before any devices are created, because it
-- 
2.55.0



  parent reply	other threads:[~2026-09-10 10:38 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10 10:36 [PATCH v4 00/14] Encode object type security status in code Daniel P. Berrangé
2026-09-10 10:36 ` [PATCH v4 01/14] qom: add tracking of security state of object types Daniel P. Berrangé
2026-09-14 18:55   ` Richard Henderson
2026-09-16 17:26   ` Daniel P. Berrangé
2026-09-10 10:36 ` [PATCH v4 02/14] qapi: add 'insecure-types' option for -compat argument Daniel P. Berrangé
2026-09-14 18:56   ` Richard Henderson
2026-09-10 10:36 ` [PATCH v4 03/14] qom: add helper API for checking object class security policy compliance Daniel P. Berrangé
2026-09-14 18:58   ` Richard Henderson
2026-09-10 10:36 ` [PATCH v4 04/14] system: check security for accelerator types Daniel P. Berrangé
2026-09-14 19:00   ` Richard Henderson
2026-09-10 10:36 ` [PATCH v4 05/14] system: report acclerator security status in help output Daniel P. Berrangé
2026-09-14 19:21   ` Richard Henderson
2026-09-10 10:36 ` Daniel P. Berrangé [this message]
2026-09-14 19:21   ` [PATCH v4 06/14] system: check security for machine types Richard Henderson
2026-09-10 10:36 ` [PATCH v4 07/14] system: report machine security status in help output Daniel P. Berrangé
2026-09-14 19:22   ` Richard Henderson
2026-09-10 10:36 ` [PATCH v4 08/14] system: check security of device types Daniel P. Berrangé
2026-09-14 19:22   ` Richard Henderson
2026-09-10 10:36 ` [PATCH v4 09/14] system: report device security status in help output Daniel P. Berrangé
2026-09-14 19:23   ` Richard Henderson
2026-09-10 10:36 ` [PATCH v4 10/14] hw/core: report security status in query-machines Daniel P. Berrangé
2026-09-14 19:23   ` Richard Henderson
2026-09-10 10:36 ` [PATCH v4 11/14] qom: refactor data passing for QOM list filtering Daniel P. Berrangé
2026-09-10 10:36 ` [PATCH v4 12/14] qom: report & filter on security status in qom-list-types Daniel P. Berrangé
2026-09-14 19:30   ` Richard Henderson
2026-09-14 20:04     ` Daniel P. Berrangé
2026-09-14 20:12       ` Richard Henderson
2026-09-14 20:20         ` Daniel P. Berrangé
2026-09-14 22:09           ` Richard Henderson
2026-09-15  7:17           ` Markus Armbruster
2026-09-15  7:09         ` Daniel P. Berrangé
2026-09-10 10:36 ` [PATCH v4 13/14] docs: expand security docs with info about security status Daniel P. Berrangé
2026-09-14 19:27   ` Richard Henderson
2026-09-10 10:36 ` [PATCH v4 14/14] machine: add helpers for declaring secure/insecure machine types Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260910103628.2326622-7-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@oss.qualcomm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.