All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Shouping Wang" <allen.wang@hj-micro.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2] perf/arm-cmn: Fix wp_dev_sel2 setting for multi-DTM configurations
Date: Thu, 10 Sep 2026 11:54:09 +0000	[thread overview]
Message-ID: <20260910115410.048CA1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260910114601.165237-1-allen.wang@hj-micro.com>

> When MXP_MULTIPLE_DTM_EN is TRUE, each DTM will monitor at most
> two device ports. In this case, {wp_dev_sel2, wp_dev_sel} will
> only use values 2'b00 and 2'b01 per DTM.
> 
> Previously the setting allowed values beyond the supported range
> per DTM, which could cause each DTM to select invalid ports when
> MXP_MULTIPLE_DTM_EN is TRUE.
> 
> Fix this by only setting CMN_DTM_WPn_CONFIG_WP_DEV_SEL2 when
> !multi_dtm.
> 
> Fixes: 60d1504070c2 ("perf/arm-cmn: Support new IP features")
> Signed-off-by: Shouping Wang <allen.wang@hj-micro.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910114601.165237-1-allen.wang@hj-micro.com?part=1


  reply	other threads:[~2026-09-10 11:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19 10:54 [PATCH] perf/arm-cmn: Fix {wp_dev_sel2, wp_dev_sel} limited to 0/1 when MXP_MULTIPLE_DTM_EN is TRUE Shouping Wang
2026-09-08  8:15 ` allen.wang
2026-09-08 15:04   ` Robin Murphy
2026-09-09  2:01     ` allen.wang
2026-09-09 16:19 ` Robin Murphy
2026-09-10 11:46   ` [PATCH v2] perf/arm-cmn: Fix wp_dev_sel2 setting for multi-DTM configurations Shouping Wang
2026-09-10 11:54     ` sashiko-bot [this message]
2026-09-10 12:37     ` Robin Murphy
2026-09-11 13:44     ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260910115410.048CA1F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=allen.wang@hj-micro.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.