From: Enzo Frese <freseenzo@gmail.com>
To: gregkh@linuxfoundation.org
Cc: "Enzo Frese" <freseenzo@gmail.com>,
"Jennifer Guo" <guojy.bj@gmail.com>,
"Andrei Khomenkov" <khomenkov@mailbox.org>,
"Dan Carpenter" <error27@gmail.com>,
"Dalvin-Ehinoma Noah Aiguobas" <fliegbert2@gmail.com>,
"Michael Straube" <straube.linux@gmail.com>,
"Michael Steinmötzger" <m.steinmoetzger@gmail.com>,
"Navaneeth K" <knavaneeth786@gmail.com>,
"Rodrigo Gobbi" <rodrigo.gobbi.7@gmail.com>,
linux-staging@lists.linux.dev (open list:STAGING SUBSYSTEM),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] staging: rtl8723bs: avoid CamelCase in odm_DynamicBBPowerSaving.c
Date: Thu, 10 Sep 2026 11:38:47 -0300 [thread overview]
Message-ID: <20260910143857.154320-1-freseenzo@gmail.com> (raw)
Rename odm_DynamicBBPowerSavingInit to odm_dynamic_bb_power_saving_init,
and rename local variables and struct ps_t fields (PreCCAState,
CurCCAState, PreRFState, CurRFState, Rssi_val_min, Reg874, RegC70,
Reg85C, RegA74, bForceInNormal, Rssi_Up_bound, Rssi_Low_bound) to
avoid CamelCase, which is not accepted by checkpatch.pl.
Signed-off-by: Enzo Frese <freseenzo@gmail.com>
---
drivers/staging/rtl8723bs/hal/odm.c | 2 +-
.../rtl8723bs/hal/odm_DynamicBBPowerSaving.c | 72 +++++++++----------
.../rtl8723bs/hal/odm_DynamicBBPowerSaving.h | 16 ++---
3 files changed, 45 insertions(+), 45 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/odm.c b/drivers/staging/rtl8723bs/hal/odm.c
index d18df407e365..e61200a5d6d0 100644
--- a/drivers/staging/rtl8723bs/hal/odm.c
+++ b/drivers/staging/rtl8723bs/hal/odm.c
@@ -580,7 +580,7 @@ void ODM_DMInit(struct dm_odm_t *pDM_Odm)
ODM_ClearTxPowerTrackingState(pDM_Odm);
- odm_DynamicBBPowerSavingInit(pDM_Odm);
+ odm_dynamic_bb_power_saving_init(pDM_Odm);
odm_DynamicTxPowerInit(pDM_Odm);
odm_SwAntDetectInit(pDM_Odm);
diff --git a/drivers/staging/rtl8723bs/hal/odm_DynamicBBPowerSaving.c b/drivers/staging/rtl8723bs/hal/odm_DynamicBBPowerSaving.c
index ed743f6678dc..e5011d1043ee 100644
--- a/drivers/staging/rtl8723bs/hal/odm_DynamicBBPowerSaving.c
+++ b/drivers/staging/rtl8723bs/hal/odm_DynamicBBPowerSaving.c
@@ -7,69 +7,69 @@
#include "odm_precomp.h"
-void odm_DynamicBBPowerSavingInit(void *pDM_VOID)
+void odm_dynamic_bb_power_saving_init(void *pDM_VOID)
{
struct dm_odm_t *pDM_Odm = (struct dm_odm_t *)pDM_VOID;
struct ps_t *pDM_PSTable = &pDM_Odm->DM_PSTable;
- pDM_PSTable->PreCCAState = CCA_MAX;
- pDM_PSTable->CurCCAState = CCA_MAX;
- pDM_PSTable->PreRFState = RF_MAX;
- pDM_PSTable->CurRFState = RF_MAX;
- pDM_PSTable->Rssi_val_min = 0;
+ pDM_PSTable->pre_cca_state = CCA_MAX;
+ pDM_PSTable->cur_cca_state = CCA_MAX;
+ pDM_PSTable->pre_rf_state = RF_MAX;
+ pDM_PSTable->cur_rf_state = RF_MAX;
+ pDM_PSTable->rssi_val_min = 0;
pDM_PSTable->initialize = 0;
}
-void ODM_RF_Saving(void *pDM_VOID, u8 bForceInNormal)
+void ODM_RF_Saving(void *pDM_VOID, u8 force_in_normal)
{
struct dm_odm_t *pDM_Odm = (struct dm_odm_t *)pDM_VOID;
struct ps_t *pDM_PSTable = &pDM_Odm->DM_PSTable;
- u8 Rssi_Up_bound = 30;
- u8 Rssi_Low_bound = 25;
+ u8 rssi_up_bound = 30;
+ u8 rssi_low_bound = 25;
if (pDM_Odm->PatchID == 40) { /* RT_CID_819x_FUNAI_TV */
- Rssi_Up_bound = 50;
- Rssi_Low_bound = 45;
+ rssi_up_bound = 50;
+ rssi_low_bound = 45;
}
if (pDM_PSTable->initialize == 0) {
- pDM_PSTable->Reg874 = (PHY_QueryBBReg(pDM_Odm->Adapter, 0x874, bMaskDWord) & 0x1CC000) >> 14;
- pDM_PSTable->RegC70 = (PHY_QueryBBReg(pDM_Odm->Adapter, 0xc70, bMaskDWord) & BIT(3)) >> 3;
- pDM_PSTable->Reg85C = (PHY_QueryBBReg(pDM_Odm->Adapter, 0x85c, bMaskDWord) & 0xFF000000) >> 24;
- pDM_PSTable->RegA74 = (PHY_QueryBBReg(pDM_Odm->Adapter, 0xa74, bMaskDWord) & 0xF000) >> 12;
+ pDM_PSTable->reg874 = (PHY_QueryBBReg(pDM_Odm->Adapter, 0x874, bMaskDWord) & 0x1CC000) >> 14;
+ pDM_PSTable->regc70 = (PHY_QueryBBReg(pDM_Odm->Adapter, 0xc70, bMaskDWord) & BIT(3)) >> 3;
+ pDM_PSTable->reg85c = (PHY_QueryBBReg(pDM_Odm->Adapter, 0x85c, bMaskDWord) & 0xFF000000) >> 24;
+ pDM_PSTable->rega74 = (PHY_QueryBBReg(pDM_Odm->Adapter, 0xa74, bMaskDWord) & 0xF000) >> 12;
/* Reg818 = PHY_QueryBBReg(padapter, 0x818, bMaskDWord); */
pDM_PSTable->initialize = 1;
}
- if (!bForceInNormal) {
+ if (!force_in_normal) {
if (pDM_Odm->RSSI_Min != 0xFF) {
- if (pDM_PSTable->PreRFState == RF_Normal) {
- if (pDM_Odm->RSSI_Min >= Rssi_Up_bound)
- pDM_PSTable->CurRFState = RF_Save;
+ if (pDM_PSTable->pre_rf_state == RF_Normal) {
+ if (pDM_Odm->RSSI_Min >= rssi_up_bound)
+ pDM_PSTable->cur_rf_state = RF_Save;
else
- pDM_PSTable->CurRFState = RF_Normal;
+ pDM_PSTable->cur_rf_state = RF_Normal;
} else {
- if (pDM_Odm->RSSI_Min <= Rssi_Low_bound)
- pDM_PSTable->CurRFState = RF_Normal;
+ if (pDM_Odm->RSSI_Min <= rssi_low_bound)
+ pDM_PSTable->cur_rf_state = RF_Normal;
else
- pDM_PSTable->CurRFState = RF_Save;
+ pDM_PSTable->cur_rf_state = RF_Save;
}
} else {
- pDM_PSTable->CurRFState = RF_MAX;
+ pDM_PSTable->cur_rf_state = RF_MAX;
}
} else {
- pDM_PSTable->CurRFState = RF_Normal;
+ pDM_PSTable->cur_rf_state = RF_Normal;
}
- if (pDM_PSTable->PreRFState != pDM_PSTable->CurRFState) {
- if (pDM_PSTable->CurRFState == RF_Save) {
- /* Reg874[20:18]=3'b010 */
+ if (pDM_PSTable->pre_rf_state != pDM_PSTable->cur_rf_state) {
+ if (pDM_PSTable->cur_rf_state == RF_Save) {
+ /* reg874[20:18]=3'b010 */
PHY_SetBBReg(pDM_Odm->Adapter, 0x874, 0x1C0000, 0x2);
- /* RegC70[3]= 1'b0 */
+ /* regc70[3]= 1'b0 */
PHY_SetBBReg(pDM_Odm->Adapter, 0xc70, BIT(3), 0);
- /* Reg85C[31:24]= 0x63 */
+ /* reg85c[31:24]= 0x63 */
PHY_SetBBReg(pDM_Odm->Adapter, 0x85c, 0xFF000000, 0x63);
- /* Reg874[15:14]=2'b10 */
+ /* reg874[15:14]=2'b10 */
PHY_SetBBReg(pDM_Odm->Adapter, 0x874, 0xC000, 0x2);
/* RegA75[7:4]= 0x3 */
PHY_SetBBReg(pDM_Odm->Adapter, 0xa74, 0xF000, 0x3);
@@ -78,12 +78,12 @@ void ODM_RF_Saving(void *pDM_VOID, u8 bForceInNormal)
/* Reg818[28]= 1'b1 */
PHY_SetBBReg(pDM_Odm->Adapter, 0x818, BIT(28), 0x1);
} else {
- PHY_SetBBReg(pDM_Odm->Adapter, 0x874, 0x1CC000, pDM_PSTable->Reg874);
- PHY_SetBBReg(pDM_Odm->Adapter, 0xc70, BIT(3), pDM_PSTable->RegC70);
- PHY_SetBBReg(pDM_Odm->Adapter, 0x85c, 0xFF000000, pDM_PSTable->Reg85C);
- PHY_SetBBReg(pDM_Odm->Adapter, 0xa74, 0xF000, pDM_PSTable->RegA74);
+ PHY_SetBBReg(pDM_Odm->Adapter, 0x874, 0x1CC000, pDM_PSTable->reg874);
+ PHY_SetBBReg(pDM_Odm->Adapter, 0xc70, BIT(3), pDM_PSTable->regc70);
+ PHY_SetBBReg(pDM_Odm->Adapter, 0x85c, 0xFF000000, pDM_PSTable->reg85c);
+ PHY_SetBBReg(pDM_Odm->Adapter, 0xa74, 0xF000, pDM_PSTable->rega74);
PHY_SetBBReg(pDM_Odm->Adapter, 0x818, BIT(28), 0x0);
}
- pDM_PSTable->PreRFState = pDM_PSTable->CurRFState;
+ pDM_PSTable->pre_rf_state = pDM_PSTable->cur_rf_state;
}
}
diff --git a/drivers/staging/rtl8723bs/hal/odm_DynamicBBPowerSaving.h b/drivers/staging/rtl8723bs/hal/odm_DynamicBBPowerSaving.h
index 3ebbbfd1dd1f..0b0765ff8e15 100644
--- a/drivers/staging/rtl8723bs/hal/odm_DynamicBBPowerSaving.h
+++ b/drivers/staging/rtl8723bs/hal/odm_DynamicBBPowerSaving.h
@@ -9,23 +9,23 @@
#define __ODMDYNAMICBBPOWERSAVING_H__
struct ps_t { /* _Dynamic_Power_Saving_ */
- u8 PreCCAState;
- u8 CurCCAState;
+ u8 pre_cca_state;
+ u8 cur_cca_state;
- u8 PreRFState;
- u8 CurRFState;
+ u8 pre_rf_state;
+ u8 cur_rf_state;
- int Rssi_val_min;
+ int rssi_val_min;
u8 initialize;
- u32 Reg874, RegC70, Reg85C, RegA74;
+ u32 reg874, regc70, reg85c, rega74;
};
#define dm_RF_Saving ODM_RF_Saving
-void ODM_RF_Saving(void *pDM_VOID, u8 bForceInNormal);
+void ODM_RF_Saving(void *pDM_VOID, u8 force_in_normal);
-void odm_DynamicBBPowerSavingInit(void *pDM_VOID);
+void odm_dynamic_bb_power_saving_init(void *pDM_VOID);
#endif
--
2.43.0
reply other threads:[~2026-09-10 14:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910143857.154320-1-freseenzo@gmail.com \
--to=freseenzo@gmail.com \
--cc=error27@gmail.com \
--cc=fliegbert2@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=guojy.bj@gmail.com \
--cc=khomenkov@mailbox.org \
--cc=knavaneeth786@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=m.steinmoetzger@gmail.com \
--cc=rodrigo.gobbi.7@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.