From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Christoph Hellwig <hch@lst.de>,
Robin Murphy <robin.murphy@arm.com>,
Sasha Levin <sashal@kernel.org>
Subject: [PATCH 5.15.y 03/10] dma-direct: fail allocations that can't be made coherent
Date: Thu, 10 Sep 2026 10:39:24 -0400 [thread overview]
Message-ID: <20260910143932.771351-3-sashal@kernel.org> (raw)
In-Reply-To: <20260910143932.771351-1-sashal@kernel.org>
From: Christoph Hellwig <hch@lst.de>
[ Upstream commit 955f58f7406ad912825fc344c7825fd904b124a0 ]
If the architecture can't remap or set an address uncached there is no way
to fullfill a request for a coherent allocation. Return NULL in that case.
Note that this case currently does not happen, so this is a theoretical
fixup and/or a preparation for eventually supporting platforms that
can't support coherent allocations with the generic code.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Stable-dep-of: 94a04ad732c9 ("dma-direct: return struct page from dma_direct_alloc_from_pool()")
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
kernel/dma/direct.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c
index 517ca0e61a57c..0d6467b6553b7 100644
--- a/kernel/dma/direct.c
+++ b/kernel/dma/direct.c
@@ -236,8 +236,9 @@ void *dma_direct_alloc(struct device *dev, size_t size,
return dma_direct_alloc_from_pool(dev, size,
dma_handle, gfp);
} else {
- if (IS_ENABLED(CONFIG_ARCH_HAS_DMA_SET_UNCACHED))
- set_uncached = true;
+ if (!IS_ENABLED(CONFIG_ARCH_HAS_DMA_SET_UNCACHED))
+ return NULL;
+ set_uncached = true;
}
}
--
2.53.0
next prev parent reply other threads:[~2026-09-10 14:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 13:21 FAILED: patch "[PATCH] dma-direct: return struct page from" failed to apply to 5.15-stable tree gregkh
2026-09-10 14:39 ` [PATCH 5.15.y 01/10] dma-direct: clean up the remapping checks in dma_direct_alloc Sasha Levin
2026-09-10 14:39 ` [PATCH 5.15.y 02/10] dma-direct: refactor the !coherent " Sasha Levin
2026-09-10 14:39 ` Sasha Levin [this message]
2026-09-10 14:39 ` [PATCH 5.15.y 04/10] dma-direct: warn if there is no pool for force unencrypted allocations Sasha Levin
2026-09-10 14:39 ` [PATCH 5.15.y 05/10] dma-direct: drop two CONFIG_DMA_RESTRICTED_POOL conditionals Sasha Levin
2026-09-10 14:39 ` [PATCH 5.15.y 06/10] dma-direct: factor the swiotlb code out of __dma_direct_alloc_pages Sasha Levin
2026-09-10 14:39 ` [PATCH 5.15.y 07/10] dma-direct: add a dma_direct_use_pool helper Sasha Levin
2026-09-10 14:39 ` [PATCH 5.15.y 08/10] dma-direct: cleanup parameters to dma_direct_optimal_gfp_mask Sasha Levin
2026-09-10 14:39 ` [PATCH 5.15.y 09/10] dma-direct: simplify the use atomic pool logic in dma_direct_alloc Sasha Levin
2026-09-10 14:39 ` [PATCH 5.15.y 10/10] dma-direct: return struct page from dma_direct_alloc_from_pool() Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910143932.771351-3-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=hch@lst.de \
--cc=robin.murphy@arm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.