From: Mehmet Fide <mehmet.fide@gmail.com>
To: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Peng Fan <peng.fan@nxp.com>, Vincent Jardin <vjardin@free.fr>,
Ye Li <ye.li@nxp.com>, Michal Simek <michal.simek@amd.com>,
Aristo Chen <aristo.chen@canonical.com>,
u-boot@lists.u-boot-project.org,
Mehmet Fide <mehmet.fide@screeningeagle.com>
Subject: Re: [PATCH 4/4] test: dm: check the fixed regulator claims its GPIO at probe time
Date: Thu, 10 Sep 2026 16:58:33 +0200 [thread overview]
Message-ID: <20260910145833.1276051-1-mehmet.fide@gmail.com> (raw)
In-Reply-To: <CAFLszTgX_s5OB7dXP_FY933yBMRNN79wCQGpXC6wzhFw80U=QA@mail.gmail.com>
Hi Simon,
On 2026-09-10 Simon Glass wrote:
> Pin a10 is already used by hog_input_active_low further down in this
> file.
I picked a10 after grepping for '&gpio_a 10' and the hogs address their
pins by bare number, so I missed it. Bank a has no free offset at all:
all 25 are taken between the phandle users and the hogs on 10 to 13,
and a15 to a18 are in use as well. Rather than grow the bank (three
gpio tests assert its size), v2 moves the regulator to c8 in the
pinmux-gpios bank, whose two cells also let the node carry the flags
the way a real regulator-fixed does.
> The node name regulator-fixed matches the compatible
Will rename it fixed-gpio-reg and look it up under that name.
> Patch 2 moves the same claim-in-probe pattern into gpio-regulator and
> fixed-clock, but only fixed-regulator is covered here.
fixed-clock drops out of patch 2 (see that thread). For gpio-regulator
v2 adds a node with two states on c9 and a test that mirrors this one:
unclaimed after of_to_plat(), output after probe(), voltage switching
the pin.
> gpio_get_function() returns GPIOF_UNUSED whenever the pin is not
> claimed via the DM name table, regardless of the sandbox pad state.
Good point. v2 also asserts sandbox_gpio_get_direction() is still input
after of_to_plat() and becomes output only after probe(), so the test
watches the pad and not just the name table.
Regards,
Mehmet
next prev parent reply other threads:[~2026-09-10 14:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 10:52 [PATCH 0/4] dm: gpio: read GPIOs in of_to_plat(), request them in probe() Mehmet Fide
2026-08-28 10:52 ` [PATCH 1/4] gpio: add a way to parse a GPIO now and request it later Mehmet Fide
2026-09-10 14:06 ` Simon Glass
2026-09-10 14:58 ` Mehmet Fide
2026-08-28 10:52 ` [PATCH 2/4] regulator: claim the enable GPIO at probe time, not in of_to_plat() Mehmet Fide
2026-09-10 14:08 ` Simon Glass
2026-09-10 14:58 ` Mehmet Fide
2026-08-28 10:52 ` [PATCH 3/4] doc: driver-model: state that of_to_plat() must not probe or claim Mehmet Fide
2026-09-10 14:09 ` Simon Glass
2026-09-10 14:58 ` Mehmet Fide
2026-08-28 10:52 ` [PATCH 4/4] test: dm: check the fixed regulator claims its GPIO at probe time Mehmet Fide
2026-09-10 14:09 ` Simon Glass
2026-09-10 14:58 ` Mehmet Fide [this message]
2026-09-10 14:10 ` [0/4] dm: gpio: read GPIOs in of_to_plat(), request them in probe() Simon Glass
2026-09-10 14:58 ` [PATCH 0/4] " Mehmet Fide
2026-09-10 15:08 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910145833.1276051-1-mehmet.fide@gmail.com \
--to=mehmet.fide@gmail.com \
--cc=aristo.chen@canonical.com \
--cc=jh80.chung@samsung.com \
--cc=mehmet.fide@screeningeagle.com \
--cc=michal.simek@amd.com \
--cc=peng.fan@nxp.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.u-boot-project.org \
--cc=vjardin@free.fr \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.