Re: [PATCH 1/5] ARM: dts: stm32: add TAMP backup register in stm32mp131.dtsi

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Adding child nodes and properties to a syscon node that has `additionalProperties: false` in its schema causes immediate validation failure.
--

commit fd4960b03c2c4e269bdd41d3965ee803d12b57df
Author: Simeon Marijon <simeon.marijon@foss.st.com>

ARM: dts: stm32: add TAMP backup register in stm32mp131.dtsi

This commit adds TAMP backup registers as nvmem cells in the stm32mp131
device tree to allow information sharing between different software
components.

> diff --git a/arch/arm/boot/dts/st/stm32mp131.dtsi b/arch/arm/boot/dts/st/stm32mp131.dtsi
> index 83ae59b73dd09..b37c22b1379cc 100644
> --- a/arch/arm/boot/dts/st/stm32mp131.dtsi
> +++ b/arch/arm/boot/dts/st/stm32mp131.dtsi
> @@ -1918,5 +1918,39 @@ gpioi: gpio@5000a000 {

[ ... ]

> +
> +		tamp: tamp@5c00a000 {
> +			compatible = "st,stm32-tamp", "syscon", "simple-mfd";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			reg = <0x5c00a000 0x400>;
> +			ranges;
> +
> +			nvram: nvram@5c00a100 {

[Severity: Low]
Will this introduce a schema validation regression when running make
dtbs_check?

The matching schema in
Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml dictates
additionalProperties: false and does not define #address-cells, #size-cells,
ranges, or child nodes like nvram.

Does the schema need to be updated to support these new properties, or
should they be structured differently?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910-upstream_tamp_nvram_dts_part-v1-0-e2bca58a65f4@foss.st.com?part=1