Re: [PATCH v3 4/4] vfio: selftests: Allow a size for vfio_dma_mapping_perf_test

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Silent failure on invalid or unrecognized command-line options due to missing usage print.
--

commit 6144d66da4643ccf9bc4b7ab3160a7d8485045d3
Author: Aaron Lewis <aaronlewis@google.com>

vfio: selftests: Allow a size for vfio_dma_mapping_perf_test

This commit introduces a mechanism in the selftest harness to parse custom
command-line options. It uses this new functionality to add a '-b' option 
to vfio_dma_mapping_perf_test for specifying the DMA region size.

> diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h
> index 29a19bc870846..5065eb7144bce 100644
> --- a/tools/testing/selftests/kselftest_harness.h
> +++ b/tools/testing/selftests/kselftest_harness.h
[ ... ]
> @@ -1118,7 +1156,6 @@ static int test_harness_argv_check(int argc, char **argv)
>  			ksft_debug_enabled = true;
>  			break;
>  		case 'h':
> -		default:
>  			fprintf(stderr,
>  				"Usage: %s [-h|-l|-d] [-t|-T|-v|-V|-f|-F|-r name]\n"
>  				"\t-h       print help\n"
> @@ -1139,7 +1176,14 @@ static int test_harness_argv_check(int argc, char **argv)
>  				"include all tests from variant 'bla'\n"
>  				"but not test 'foo' specify '-T foo -v bla'.\n"
>  				"", argv[0]);
> -			return opt == 'h' ? KSFT_SKIP : KSFT_FAIL;
> +			if (opts && opts->help)
> +				opts->help();
> +			return KSFT_SKIP;
> +		default:
> +			if (opts && opts->handler &&
> +			    opts->handler(opt, optarg) == KSFT_PASS)
> +				break;
> +			return KSFT_FAIL;

[Severity: Medium]
Is it intended to silently fail here in test_harness_argv_check() without 
printing the usage string?

Previously, unrecognized options would fall through to the 'h' case and print
the help text before returning KSFT_FAIL. By removing the default fallthrough
to the 'h' case, passing an invalid option to the test binary now exits
silently, which might make it harder for users to realize they've provided an
invalid flag.

>  		}
>  	}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910153326.3085937-1-aaronlewis@google.com?part=4