All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeffin Philip <jeffinphilip14@gmail.com>
To: dgc@kernel.org
Cc: cem@kernel.org, linux-kernel@vger.kernel.org,
	linux-xfs@vger.kernel.org,
	syzbot+a4fde844548510369112@syzkaller.appspotmail.com,
	syzkaller-bugs@googlegroups.com, jeffinphilip14@gmail.com
Subject: Re: [syzbot] [xfs?] KASAN: slab-use-after-free Write in xlog_cil_ail_insert
Date: Thu, 10 Sep 2026 21:17:25 +0530	[thread overview]
Message-ID: <20260910154725.18960-1-jeffinphilip14@gmail.com> (raw)
In-Reply-To: <aqI6v-_dc2DDSbgB@dread>

On Wed, Sep 09, 2026, Dave Chinner wrote:

>The short term fix is to slap a bandaid on xfs_buf_submit() to wait
>for unpin before erroring out a pinned buffer on shutdown. That,
>however, doesn't fix the underlying lack of full lifecycle reference
>counts for log items.
>
>The long term fix is have the AIL require a reference count to be
>held on log items it tracks, and only have that refcount removed
>when the item is removed from the AIL. That's a much bigger rework
>of the code. 
>
>FYI, I've attached two document below - the design for
>generic full lifecycle log item reference counting, and the design
>for converting the inode log item to be dynamic similar to the buf
>log item so we don't end up with millions of ILIs that are never
>used left sitting around in memory until it's owner inode is
>reclaimed.

I read the documents and have started writing the wrappers. Is anyone
else working on it?

Thanks,
Jeffin.

  reply	other threads:[~2026-09-10 15:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10  0:16 [syzbot] [xfs?] KASAN: slab-use-after-free Write in xlog_cil_ail_insert syzbot
2026-09-10  5:06 ` Dave Chinner
2026-09-10 15:47   ` Jeffin Philip [this message]
2026-09-10 16:19     ` Carlos Maiolino
2026-09-11  0:26     ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260910154725.18960-1-jeffinphilip14@gmail.com \
    --to=jeffinphilip14@gmail.com \
    --cc=cem@kernel.org \
    --cc=dgc@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=syzbot+a4fde844548510369112@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.