Re: [PATCH v1 3/3] perf header: Transition WARN macros to debug.h equivalents

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing newline character at the end of the pr_warning format string.
--

commit 4a0b2ee01b018f0849023322af221ce512de09c8
Author: Ian Rogers <irogers@google.com>

perf header: Transition WARN macros to debug.h equivalents

This commit avoids a checkpatch.pl warning on the use of asm/bug.h by
switching the use of WARN macros to explicit tests and using pr_warning from
debug.h.

> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> index 78b16a098148a..a3e6c334a2894 100644
> --- a/tools/perf/util/header.c
> +++ b/tools/perf/util/header.c
[ ... ]
> @@ -1108,9 +1113,10 @@ static int write_dir_format(struct feat_fd *ff,
>  	session = container_of(ff->ph, struct perf_session, header);
>  	data = session->data;
>  
> -	if (WARN_ON(!perf_data__is_dir(data)))
> +	if (!perf_data__is_dir(data)) {
> +		pr_warning("Expected data to be a directory");

[Severity: Low]
Does this pr_warning() need a newline character at the end of the format
string?

Unlike some kernel-space printk variants, the user-space pr_warning() does
not automatically append a newline. If perf attempts to write the directory
format but perf_data__is_dir(data) evaluates to false, this could result in
consecutive diagnostic messages, error logs, or the user's shell prompt
improperly concatenating to the end of this warning message.

>  		return -1;
> -
> +	}
>  	return do_write(ff, &data->dir.version, sizeof(data->dir.version));
>  }
[ ... ]
> @@ -3714,9 +3720,10 @@ static int process_dir_format(struct feat_fd *ff,
>  	session = container_of(ff->ph, struct perf_session, header);
>  	data = session->data;
>  
> -	if (WARN_ON(!perf_data__is_dir(data)))
> +	if (!perf_data__is_dir(data)) {
> +		pr_warning("Expected data to be a directory");

[Severity: Low]
Similarly here in process_dir_format(), should this warning string include a
trailing newline to prevent visual formatting glitches on the console when
processing a malformed directory format?

>  		return -1;
> -
> +	}
>  	return do_read_u64(ff, &data->dir.version);
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910173715.2996571-1-irogers@google.com?part=3