From: Jakub Kicinski <kuba@kernel.org>
To: netdev-bot+sashiko@kernel.org
Cc: elb12345@hotmail.co.uk, sd@queasysnail.net,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net] macsec: require CAP_NET_ADMIN in the device netns for changelink
Date: Thu, 10 Sep 2026 17:52:36 -0700 [thread overview]
Message-ID: <20260910175236.3ef872ec@kernel.org> (raw)
In-Reply-To: <178904284935.219967.10266742419018601309@kernel.org>
On Thu, 10 Sep 2026 12:20:49 +0000 netdev-bot+sashiko@kernel.org wrote:
> > An unconditional gate also denies the third case, which is a needless
> > uAPI change; hence the narrower condition.
>
> Does the narrower condition still deny that same class of purely local
> request? Would comparing nla_get_u8(data[IFLA_MACSEC_OFFLOAD]) against
> macsec->offload, so the gate fires only on an actual transition, keep that
> case working?
Sounds reasonable. Let's factor the checks out to a separate helper
function to avoid building very complex conditions in place.
--
pw-bot: cr
next prev parent reply other threads:[~2026-09-11 0:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 12:20 [PATCH net] macsec: require CAP_NET_ADMIN in the device netns for changelink netdev-bot+sashiko
2026-09-11 0:52 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-09-05 21:20 Aamir Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910175236.3ef872ec@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elb12345@hotmail.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.