Re: [LTP] [PATCH 1/9] doc: Fix examples and generated links

[Petr Vorel <pvorel@suse.cz>]

Hi Andrea,

Good catches, thanks!

Reviewed-by: Petr Vorel <pvorel@suse.cz>

...
>          'inotify_add_watch': f'{ltp_syscalls_path}/inotify',
>          'inotify_init': f'{ltp_syscalls_path}/inotify',
>          'inotify_rm_watch': f'{ltp_syscalls_path}/inotify',
> @@ -293,7 +293,7 @@ def _generate_tags_table(tags):
>          "linux-git": "https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=",
>          "linux-stable-git": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=",
>          "glibc-git": "https://sourceware.org/git/?p=glibc.git;a=commit;h=",
> -        "musl-git": "https://git.musl-libc.org/cgit/musl/commit/src/linux/clone.c?id=",
> +        "musl-git": "https://git.musl-libc.org/cgit/musl/commit/?id=",
Interestingly, the old link also works (cgit v1.2.1 apparently ignores any path
after /commit/ when there is id parameter), but it's of course good to fix it.

>          "CVE": cve_url + 'CVE-',
>      }

> diff --git a/doc/developers/api_shell_tests.rst b/doc/developers/api_shell_tests.rst
> index 937ffee2e..22cab6803 100644
> --- a/doc/developers/api_shell_tests.rst
> +++ b/doc/developers/api_shell_tests.rst
> @@ -41,10 +41,11 @@ when it's empty.
>     #  "needs_root": true,
>     #  "needs_tmpdir": true,
>     #  "needs_kconfigs": ["CONFIG_NUMA=y"],
> -   #  "tags": {
> +   #  "tags": [
>     #   ["linux-git", "432fd03240fa"]
Could you, please, change  before merge this line to:
      #   ["linux-git", "cf01fb9985e8deb25ccf0ea54d916b8871ae0e62"]

(1) longer hash 2) hash which actually exists in kernel tree.)
thanks!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp