Re: [PATCH net-next v6 06/12] gve: simplify reset logic

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Silent state loss of AF_XDP configuration and hardware flow rules after device reset.
--

commit bcda352ad7c739e9f63ce9eefb6fb5309a234230
Author: Joshua Washington <joshwash@google.com>

gve: simplify reset logic

This commit simplifies the GVE reset logic by removing recursive resets,
avoiding resets during teardown, and decomposing allocation/teardown of
control plane resources.

> diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ethernet/google/gve/gve_main.c
> --- a/drivers/net/ethernet/google/gve/gve_main.c
> +++ b/drivers/net/ethernet/google/gve/gve_main.c
[ ... ]
> @@ -590,7 +594,22 @@ static void gve_free_notify_blocks(struct gve_priv *priv)
>  	priv->msix_vectors = NULL;
>  }
>  
> -static int gve_setup_device_resources(struct gve_priv *priv)
> +static void gve_free_control_plane_resources(struct gve_priv *priv)
> +{
> +	bitmap_free(priv->xsk_pools);
> +	priv->xsk_pools = NULL;

[Severity: High]
This is a pre-existing issue, but does this cause a silent state loss of
AF_XDP configuration after a device reset?

Because the driver clears xsk_pools without restoring the state, any active
AF_XDP applications could silently stop receiving traffic and require a
manual restart to recover after a routine reset (such as from a TX timeout
or an ethtool reset). This breaks the ABI contract for AF_XDP, making the
networking features permanently unusable after a transparent recovery.

> +
> +	kvfree(priv->ptype_lut_dqo);
> +	priv->ptype_lut_dqo = NULL;
> +
> +	gve_free_stats_report(priv);
> +	gve_free_notify_blocks(priv);
> +	gve_free_counter_array(priv);
> +	gve_free_rss_config_cache(priv);
> +	gve_free_flow_rule_caches(priv);

[Severity: High]
This is a pre-existing issue, but does this destroy the software cache of
ethtool flow rules without restoring them?

User-configured hardware flow rules appear to be permanently deleted from
both the hardware and the software cache upon a device reset. They are never
restored to the hardware, requiring manual user intervention to reapply
them.

> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260909191136.3811892-1-hramamurthy@google.com?part=6