From: Shuicheng Lin <shuicheng.lin@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Shuicheng Lin <shuicheng.lin@intel.com>,
Sk Anirban <sk.anirban@intel.com>,
Matthew Brost <matthew.brost@intel.com>
Subject: [PATCH] drm/xe/tlb_inval: Squash wedged error in GGTT TLB invalidation
Date: Thu, 10 Sep 2026 23:27:34 +0000 [thread overview]
Message-ID: <20260910232734.93054-1-shuicheng.lin@intel.com> (raw)
A GGTT TLB invalidation issued on a wedged device fails with
-ENOTRECOVERABLE. xe_tlb_inval_issue_op_wait() only squashes -ECANCELED,
so the error reaches ggtt_invalidate_gt_tlb() and trips its
xe_gt_WARN(). The resulting taint turns an otherwise passing
igt@xe_exec_reset@gt-reset-fault-injection run into an abort:
*ERROR* SIGID=102 FATAL (-EIO) WEDGED: Device declared wedged!
Tile0: GT1: Failed to invalidate GGTT (-ENOTRECOVERABLE)
WARNING: drivers/gpu/drm/xe/xe_ggtt.c:588 at ggtt_invalidate_gt_tlb
Workqueue: xe-guc-destroy-wq __guc_exec_queue_destroy_async [xe]
ggtt_node_remove+0xe3/0x100 [xe]
xe_ggtt_node_remove+0x3f/0xa0 [xe]
xe_ggtt_remove_bo+0x89/0x2c0 [xe]
xe_ttm_bo_destroy+0xcb/0x330 [xe]
...
xe_lrc_destroy+0x74/0x90 [xe]
xe_exec_queue_fini+0x2d/0x60 [xe]
send_tlb_inval_ggtt() only checks that the CT is enabled, not that the
device is usable, so a wedged device still takes the CT send path. There
__guc_ct_send_locked() tests xe_device_wedged() before it looks at the
CT state and drops the message. It can never be delivered, so report it
as cancelled instead.
Fixes: 50fa9acac26f ("drm/xe/guc: distinguish wedged from recoverable cancellation")
Assisted-by: Claude:claude-opus-5
Cc: Sk Anirban <sk.anirban@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
---
drivers/gpu/drm/xe/xe_guc_tlb_inval.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_guc_tlb_inval.c b/drivers/gpu/drm/xe/xe_guc_tlb_inval.c
index 111fef781b2a..578cafa5526d 100644
--- a/drivers/gpu/drm/xe/xe_guc_tlb_inval.c
+++ b/drivers/gpu/drm/xe/xe_guc_tlb_inval.c
@@ -75,8 +75,14 @@ static int send_tlb_inval_ggtt(struct xe_tlb_inval *tlb_inval, u32 seqno)
seqno,
MAKE_INVAL_OP(XE_GUC_TLB_INVAL_GUC),
};
+ int ret;
- return send_tlb_inval(guc, action, ARRAY_SIZE(action));
+ ret = send_tlb_inval(guc, action, ARRAY_SIZE(action));
+ /* Device wedged: message not delivered */
+ if (ret == -ENOTRECOVERABLE)
+ return -ECANCELED;
+
+ return ret;
} else if (xe_device_uc_enabled(xe) && !xe_device_wedged(xe)) {
struct xe_mmio *mmio = >->mmio;
--
2.43.0
next reply other threads:[~2026-09-10 23:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 23:27 Shuicheng Lin [this message]
2026-09-10 23:35 ` ✓ CI.KUnit: success for drm/xe/tlb_inval: Squash wedged error in GGTT TLB invalidation Patchwork
2026-09-10 23:41 ` [PATCH] " sashiko-bot
2026-09-11 0:31 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-09-11 9:56 ` ✓ Xe.CI.FULL: " Patchwork
2026-09-14 21:53 ` [PATCH v2] drm/xe/tlb_inval: Treat wedged-device invalidations as complete Shuicheng Lin
2026-09-17 18:48 ` Matthew Brost
2026-09-14 22:01 ` ✓ CI.KUnit: success for drm/xe/tlb_inval: Squash wedged error in GGTT TLB invalidation (rev2) Patchwork
2026-09-14 22:41 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-15 3:25 ` ✓ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910232734.93054-1-shuicheng.lin@intel.com \
--to=shuicheng.lin@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
--cc=sk.anirban@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.