From: Greg KH <gregkh@linuxfoundation.org>
To: Jiazi Liu <jiazi.liu1984@gmail.com>
Cc: Thinh.Nguyen@synopsys.com, frode@meta.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v4] usb: dwc3: gadget: fix IRQ storm on invalid event buffer count
Date: Thu, 10 Sep 2026 17:01:12 +0200 [thread overview]
Message-ID: <2026091053-unstylish-punctured-9ad6@gregkh> (raw)
In-Reply-To: <20260907073756.22329-1-jiazi.liu1984@gmail.com>
On Mon, Sep 07, 2026 at 03:37:56PM +0800, Jiazi Liu wrote:
> When dwc3_check_event_buf() reads a GEVNTCOUNT value exceeding the
> event buffer length, commit 63ccd26cd1f6 ("usb: dwc3: gadget: check
> that event count does not exceed event buffer length") returns IRQ_NONE
> without writing back GEVNTCOUNT. Since the DWC3 interrupt is
> level-triggered, the uncleared IRQ source keeps the line asserted,
> causing a tight IRQ storm that accumulates 99,900 unhandled interrupts
> and triggers spurious.c:184 BUG -> kernel panic.
>
> The resulting call stack:
> __report_bad_irq+0xac/0xc8
> note_interrupt+0x340/0x468
> handle_irq_event+0xac/0xc0
> handle_fasteoi_irq+0x120/0x228
> gic_handle_irq+0x68/0x108
> ...
> kernel BUG at kernel/irq/spurious.c:184
>
> To reproduce, write a bogus value exceeding the event buffer length
> directly to the GEVNTCOUNT register:
>
> devmem <DWC3_BASE + 0xc40c> 4 0x1004
>
> Write the bogus count back to GEVNTCOUNT to clear the IRQ source,
> consistent with the stale event clearing pattern in
> dwc3_event_buffers_setup(), and schedule error recovery to
> reinitialize the controller.
>
> Fixes: 63ccd26cd1f6 ("usb: dwc3: gadget: check that event count does not exceed event buffer length")
> Cc: stable@vger.kernel.org
> Co-developed-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
> Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
I missed where Thinh signed off on this, where did that happen?
confused,
greg k-h
next prev parent reply other threads:[~2026-09-10 15:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260727092258.1121-1-liujiazi@amazon.com>
2026-08-12 8:21 ` [PATCH v2 1/1] usb: dwc3: gadget: fix IRQ storm on invalid event buffer count Jiazi Liu
2026-08-12 9:48 ` Krishna Kurapati
2026-08-28 2:36 ` Thinh Nguyen
2026-08-28 9:48 ` Liu Jiazi
2026-08-29 0:31 ` Thinh Nguyen
2026-09-02 4:14 ` Liu Jiazi
2026-09-04 1:56 ` Thinh Nguyen
2026-09-04 9:49 ` [PATCH v3] " Jiazi Liu
2026-09-04 23:55 ` Thinh Nguyen
2026-09-07 7:16 ` Jiazi Liu
2026-09-07 7:37 ` [PATCH v4] " Jiazi Liu
2026-09-10 15:01 ` Greg KH [this message]
2026-09-10 22:30 ` Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026091053-unstylish-punctured-9ad6@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=frode@meta.com \
--cc=jiazi.liu1984@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.