From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF408C88E58 for ; Fri, 11 Sep 2026 15:05:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 245AB10F675; Fri, 11 Sep 2026 15:05:19 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=suse.com header.i=@suse.com header.b="UV/uHAvo"; dkim-atps=neutral Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9BB9C10F676 for ; Fri, 11 Sep 2026 15:05:17 +0000 (UTC) Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-485850cf499so831817f8f.3 for ; Fri, 11 Sep 2026 08:05:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1789139116; x=1789743916; darn=lists.freedesktop.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=a258DNEK6aR0v+xDimWu2caaAUdwCvMljBObmnBjN5k=; b=UV/uHAvowqaPOP/yltYPgD6G7/52L93IXQWZ1gWg9DdYCUFHxm32mFE4FCBMO1QR6X z2V24Xq7aysMfqTsIbqJod0nDJ0xs29IHne1Qdfii/1KimKSaF3KZrt0veE5/gwgeV6u VTvXEE+/t7Cc0VwNzGsH2MeC+AcS44l7UkMW3d3QL5RaGmqP2yUNfkP5aMT8XP0Jy4ZG Y2hiQt5xAEOOHVFOORwxr6lzwdqwZQkx++VkmwcC/Djx+tS/vJrmJEJkxW2cFoE+b2OF nmKM9Jgr0Bg7wyGz/Go+6MMw/JfMyKYQeW5I8tKb/XmXmRlUeO2LGhfB6iaAbnolpyyS BDcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789139116; x=1789743916; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=a258DNEK6aR0v+xDimWu2caaAUdwCvMljBObmnBjN5k=; b=MIRigTbAjdwDWPEprUYSirv6dQP4cOFaQzXqhVr0D17zrRcg/ahe2RRhGEyOFR37Lv 3oLQ4CEflo9BnxSX5agPHdbIaHtkA2+fvxJR0y3v2DtRrd2/4wSIFbcB9WA5o+I0MkHO 2MMmpfc1EuP5tWotxF0+tSz1pfjQ6am5bb3EjuyS02mQQnHgPkGPWM2ZfoWKl1SWxpZC d6RJy0PIiFubg6h8xET9pr7ObsSBJmWsjnDQA9Y76Mo1h9V/S9x7Z9/7BL3DxjJRheg/ 38vshFqUX8jmRMgjHFic1+cnJXXb3Ep5XgSWbDCX5e6GG8LsJO2tK+M8FfxwBjga7k1F e9Gg== X-Forwarded-Encrypted: i=1; AKwUvBwRaKF0HAMjLJPLOVNLH3HJzWLwUE2g14r1Z5l3ftm9S/Kg0sjpoBCm6mbAih2iOnL1n9Pxoddt3WY=@lists.freedesktop.org X-Gm-Message-State: AFuF++nbM1VuENe8l5O9awwDMhZRa+Y6caTCLBHOu2qd+jjR7JZ9UkeM Ga00GawKdA6qTYVjWvE1YypbbLuR6FLu7k7TZy8TgULU1seuQ1Milp0MqpnXQKv6Kp8= X-Gm-Gg: AYBFou0JSROGAiPPvMB76ukoohI38GZssiTIKlawRAaHS4wE7CXNIFWb5tgthudVcAp T8qt25+SyGgA1c6AevnfgfX2hjNw+Wmb5Upwi7WxaVUYVeuY6MJslPq6jnSl94c153bQgXt1SHm yyyKuMO1dUsShLSqpaywrTlxnHDQmmzHvJXn1AJMziH854Eg81LeOQPj4JgVVyPu0DZiyM7uruZ FRX09RclHRGVOk8cDGNLMzscyM4xu0nUThHh4PyOaqjV0dKtF8W6ORwUVcdUDD7JxewCgNMHeV9 SHosjzrZk2/N4XeeyvO/C9bmCqHBAzlo5jmFiWll9yiGYppT89kw00TqBjlcdEIXUVbdVAIKdja RGVhIN/pZSXg+VpSEZaILlakfTWHIsSVJdAazcokTRkctv0qc0GbSx767XMM3TsiUJFjeveoKiX 1qT4L+221SCWmsUWmItU5k0m8wGJuyPYSzUw8mtIBHhTJ+pl82dpIsVDzGlLYQYtjr9/aNxjSSK z4GcE8= X-Received: by 2002:a05:6000:491e:b0:486:f4b6:3bce with SMTP id ffacd0b85a97d-486f4b63c4fmr559176f8f.24.1789139115924; Fri, 11 Sep 2026 08:05:15 -0700 (PDT) Received: from localhost.localdomain ([2001:af0:8000:1409:193:86:92:181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-486eb350686sm6853579f8f.27.2026.09.11.08.05.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2026 08:05:15 -0700 (PDT) From: Petr Pavlu To: Jens Axboe , Jakub Kicinski , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Matthew Brost , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= Cc: Simon Horman , David Airlie , Simona Vetter , Francois Dugast , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , linux-block@vger.kernel.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 6/6] module: Remove the error-injection.h include from linux/module.h Date: Fri, 11 Sep 2026 17:04:06 +0200 Message-ID: <20260911-module-include-error_injection-v1-6-5da895d8c84d@suse.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260911-module-include-error_injection-v1-0-5da895d8c84d@suse.com> References: <20260911-module-include-error_injection-v1-0-5da895d8c84d@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" linux/module.h appears in roughly 15k #include directives across the kernel. This makes it a "hot" header, so it should avoid pulling in unnecessary definitions. The header currently includes linux/error-injection.h to obtain the definition of `struct error_injection_entry`. However, this is unnecessary because the type is only referenced in the file as a pointer, for which an incomplete type is sufficient. Remove the linux/error-injection.h include from linux/module.h and add it to kernel/module/main.c instead, where `sizeof(struct error_injection_entry)` is actually needed. Signed-off-by: Petr Pavlu --- include/linux/module.h | 1 - kernel/module/main.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/module.h b/include/linux/module.h index 96cc98568eea..b3a3d5827384 100644 --- a/include/linux/module.h +++ b/include/linux/module.h @@ -24,7 +24,6 @@ #include #include #include -#include #include #include #include diff --git a/kernel/module/main.c b/kernel/module/main.c index d0e1e0bd2ad0..f1392c10907a 100644 --- a/kernel/module/main.c +++ b/kernel/module/main.c @@ -60,6 +60,7 @@ #include #include #include +#include #include #include "internal.h" -- 2.55.0