Re: [PATCH 1/2] remoteproc: qcom_q6v5_pas: Add QMI TMD cooling support for Shikra

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Compilation errors due to missing fields in `struct qcom_pas_data` and undeclared identifiers for TMD names.
--

commit b0cce49cb204b7f4f532f2034375d026df2ba65c
Author: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>

remoteproc: qcom_q6v5_pas: Add QMI TMD cooling support for Shikra

This commit adds QMI TMD instance IDs and cooling device name arrays for
CDSP and MPSS subsystems on Shikra to enable thermal mitigation support.

> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index a005546c265d0..3daaed6ca5963 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -1660,6 +1660,9 @@ static const struct qcom_pas_data shikra_cdsp_resource = {
>  	.sysmon_name = "cdsp",
>  	.ssctl_id = 0x17,
>  	.smem_host_id = 5,
> +	.tmd_instance_id = 0x43,
> +	.tmd_name = cdsp_tmd_name,
> +	.num_tmd = ARRAY_SIZE(cdsp_tmd_name),

[Severity: Low]
Is this patch missing a prerequisite dependency? It appears the
tmd_instance_id, tmd_name, and num_tmd fields do not exist in the local
definition of struct qcom_pas_data, and cdsp_tmd_name is undeclared. This
currently results in a build regression.

[ ... ]

> @@ -1688,6 +1691,9 @@ static const struct qcom_pas_data shikra_mpss_resource = {
>  	.ssr_name = "mpss",
>  	.sysmon_name = "modem",
>  	.ssctl_id = 0x12,
> +	.tmd_instance_id = 0x0,
> +	.tmd_name = modem_tmd_name,
> +	.num_tmd = ARRAY_SIZE(modem_tmd_name),

[Severity: Low]
Similarly, does this rely on an unmerged patch? The modem_tmd_name array
is undeclared here as well.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260911-shikra_qmi_tmd-v1-0-96c1cca82f30@oss.qualcomm.com?part=1