Re: [PATCH v4 1/3] dt-bindings: mfd: mediatek: mt6397: add mt6323 PMIC EFUSE

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `efuse` object sets `unevaluatedProperties: false` but omits a `$ref` to the base NVMEM schema, preventing the use of standard NVMEM properties.
--

commit 564a77c7b7cc8f4b6a33fd5c7430ae49a1709346
Author: Roman Vivchar <rva333@protonmail.com>

dt-bindings: mfd: mediatek: mt6397: add mt6323 PMIC EFUSE

The MediaTek mt6323 PMIC includes an EFUSE used for storing calibration
data. This commit adds the corresponding devicetree binding documentation.

> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
> index 3cbc0dc12c319..d2de227ae7a6d 100644
> --- a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
> +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
> @@ -159,6 +159,23 @@ properties:
>      required:
>        - compatible
>  
> +  efuse:
> +    type: object
> +    unevaluatedProperties: false

[Severity: Low]
Does this efuse object also need a $ref: /schemas/nvmem/nvmem.yaml# included?

Because unevaluatedProperties is set to false in properties.efuse without a 
reference to the base nvmem schema, could this cause a schema validation 
regression? It appears any device tree attempting to use standard nvmem 
properties (such as read-only, wp-gpios, or #address-cells and #size-cells 
for static cells) in the efuse node will incorrectly fail schema validation.

> +    description:
> +      The efuse is responsible for storing calibration data, such as thermal
> +      sensor calibration.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260911-mt6323-nvmem-v4-0-626dd17531dc@protonmail.com?part=1