All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: <linux-wireless@vger.kernel.org>
Cc: <timlee@realtek.com>
Subject: [PATCH rtw-next] wifi: rtw89: pci: disable D3cold on ASUS ExpertBook B3/P3 series
Date: Fri, 11 Sep 2026 14:53:58 +0800	[thread overview]
Message-ID: <20260911065358.34375-1-pkshih@realtek.com> (raw)

From: Chin-Yen Lee <timlee@realtek.com>

ASUS ExpertBook models (B3406CMA, B3606CMA, P3406CMA, and P3606CMA) may
encounter PCIe link loss or recovery issues after entering the L2 low-power
state associated with D3cold.

Prevent these affected platforms from entering D3cold to avoid the
problematic PCIe L2 state transition.

Add a DMI quirk match table so that other non-affected platforms can
continue utilizing D3cold power saving.

Signed-off-by: Chin-Yen Lee <timlee@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
 drivers/net/wireless/realtek/rtw89/pci.c | 44 ++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/drivers/net/wireless/realtek/rtw89/pci.c b/drivers/net/wireless/realtek/rtw89/pci.c
index 8c3f4eb52cc5..941fb5ca15b6 100644
--- a/drivers/net/wireless/realtek/rtw89/pci.c
+++ b/drivers/net/wireless/realtek/rtw89/pci.c
@@ -4766,6 +4766,49 @@ static const struct rtw89_hci_ops rtw89_pci_ops = {
 	.rst_bdram	= rtw89_pci_reset_bdram,
 };
 
+static void rtw89_pci_d3cold_quirks(struct rtw89_dev *rtwdev, struct pci_dev *pdev)
+{
+	static const struct dmi_system_id d3cold_quirks[] = {
+		{
+			.ident = "ASUS EXPERTBOOK B3406CMA",
+			.matches = {
+				DMI_MATCH(DMI_BOARD_VENDOR, "ASUS"),
+				DMI_MATCH(DMI_BOARD_NAME, "B3406CMA"),
+			},
+		},
+		{
+			.ident = "ASUS EXPERTBOOK B3606CMA",
+			.matches = {
+				DMI_MATCH(DMI_BOARD_VENDOR, "ASUS"),
+				DMI_MATCH(DMI_BOARD_NAME, "B3606CMA"),
+			},
+		},
+		{
+			.ident = "ASUS EXPERTBOOK P3406CMA",
+			.matches = {
+				DMI_MATCH(DMI_BOARD_VENDOR, "ASUS"),
+				DMI_MATCH(DMI_BOARD_NAME, "P3406CMA"),
+			},
+		},
+		{
+			.ident = "ASUS EXPERTBOOK P3606CMA",
+			.matches = {
+				DMI_MATCH(DMI_BOARD_VENDOR, "ASUS"),
+				DMI_MATCH(DMI_BOARD_NAME, "P3606CMA"),
+			},
+		},
+		{},
+	};
+	const struct dmi_system_id *match;
+
+	match = dmi_first_match(d3cold_quirks);
+	if (!match)
+		return;
+
+	rtw89_debug(rtwdev, RTW89_DBG_STATE, "Disable D3Cold on %s\n", match->ident);
+	pci_d3cold_disable(pdev);
+}
+
 int rtw89_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 {
 	struct rtw89_dev *rtwdev;
@@ -4791,6 +4834,7 @@ int rtw89_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 	rtwdev->hci.rpwm_addr = pci_info->rpwm_addr;
 	rtwdev->hci.cpwm_addr = pci_info->cpwm_addr;
 
+	rtw89_pci_d3cold_quirks(rtwdev, pdev);
 	rtw89_check_quirks(rtwdev, info->quirks);
 	rtw89_check_pci_ssid_quirks(rtwdev, pdev, pci_info->ssid_quirks);
 

base-commit: f71dd599a98182d6bc34dce39977f928068ecd64
-- 
2.25.1


             reply	other threads:[~2026-09-11  6:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11  6:53 Ping-Ke Shih [this message]
2026-09-16  5:19 ` [PATCH rtw-next] wifi: rtw89: pci: disable D3cold on ASUS ExpertBook B3/P3 series Ping-Ke Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260911065358.34375-1-pkshih@realtek.com \
    --to=pkshih@realtek.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=timlee@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.