From: Chuck Zmudzinski <brchuckz@aol.com>
To: qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org, xen-devel@lists.xenproject.org,
Stefano Stabellini <sstabellini@kernel.org>,
Anthony PERARD <anthony@xenproject.org>,
"Edgar E . Iglesias" <edgar.iglesias@gmail.com>,
Tomita Moeko <tomitamoeko@gmail.com>
Subject: [PATCH v6 2/7] xen/igd: don't register rom bar twice
Date: Fri, 11 Sep 2026 03:24:48 -0400 [thread overview]
Message-ID: <20260911072453.46256-3-brchuckz@aol.com> (raw)
In-Reply-To: <20260911072453.46256-1-brchuckz@aol.com>
This also fixes a failed assertion in pci [1] for Qemu
version 10 and higher when passing through an Intel
IGD with an option ROM to the guest.
[1] f6fc01c78666 ("hw/pci: Assert a bar is not registered multiple times")
Fixes: 881213f1b9c5 ("xen, gfx passthrough: retrieve VGA BIOS to work")
Signed-off-by: Chuck Zmudzinski <brchuckz@aol.com>
---
Changes in v6:
- No changes to this patch
Changes in v5:
- No changes to this patch
Changes in v4:
- Use 12 digits for commit hashes
hw/xen/xen_pt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
index c8f08b5..4d159a2 100644
--- a/hw/xen/xen_pt.c
+++ b/hw/xen/xen_pt.c
@@ -459,6 +459,7 @@ static int xen_pt_register_regions(XenPCIPassthroughState *s, uint16_t *cmd)
{
int i = 0;
XenHostPCIDevice *d = &s->real_device;
+ const pcibus_t romsize = s->dev.io_regions[PCI_ROM_SLOT].size;
/* Register PIO/MMIO BARs */
for (i = 0; i < PCI_ROM_SLOT; i++) {
@@ -495,7 +496,7 @@ static int xen_pt_register_regions(XenPCIPassthroughState *s, uint16_t *cmd)
}
/* Register expansion ROM address */
- if (d->rom.base_addr && d->rom.size) {
+ if (!romsize && d->rom.base_addr && d->rom.size) {
uint32_t bar_data = 0;
/* Re-set BAR reported by OS, otherwise ROM can't be read. */
--
2.52.0
next prev parent reply other threads:[~2026-09-11 7:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260911072453.46256-1-brchuckz.ref@aol.com>
2026-09-11 7:24 ` [PATCH v6 0/7] xen/igd: fixes for Intel IGD passthrough Chuck Zmudzinski
2026-09-11 7:24 ` [PATCH v6 1/7] xen/igd: get PCH info from host sysfs Chuck Zmudzinski
2026-09-11 7:24 ` Chuck Zmudzinski [this message]
2026-09-11 7:24 ` [PATCH v6 3/7] xen/igd: fixup device id before registering rom Chuck Zmudzinski
2026-09-11 7:24 ` [PATCH v6 4/7] xen/igd: enable guest creation when ROM read fails Chuck Zmudzinski
2026-09-11 7:24 ` [PATCH v6 5/7] xen/igd: use igd header for IGD related definitions Chuck Zmudzinski
2026-09-11 7:24 ` [PATCH v6 6/7] xen/igd: implement support for extended VBT Chuck Zmudzinski
2026-09-13 15:30 ` Chuck Zmudzinski
2026-09-11 7:24 ` [PATCH v6 7/7] xen/igd: use custom option ROM if provided Chuck Zmudzinski
2026-09-13 15:27 ` [PATCH v6 0/7] xen/igd: fixes for Intel IGD passthrough Chuck Zmudzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260911072453.46256-3-brchuckz@aol.com \
--to=brchuckz@aol.com \
--cc=anthony@xenproject.org \
--cc=edgar.iglesias@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=tomitamoeko@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.