From: sashiko-bot@kernel.org
To: "Johan Hovold" <johan@kernel.org>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: amiserial: fix broken TIOCMIWAIT
Date: Fri, 11 Sep 2026 09:17:18 +0000 [thread overview]
Message-ID: <20260911091719.119821F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260911090132.723531-1-johan@kernel.org>
> A change replacing interruptible_sleep_on() inadvertently broke the
> TIOCMIWAIT implementation which now immediately returns -EIO (unless
> there is a racing modem status update).
>
> Replace the old hangup (and signal) detection with a check for the
> TTY_IO_ERROR flag which is set on hangup.
>
> Fixes: 591cee0a3563 ("tty/amiserial: avoid interruptible_sleep_on")
> Reported-by: sashiko-bot@kernel.org
> Link: https://lore.kernel.org/20260910132029.D80801F00898@smtp.kernel.org
> Cc: stable@vger.kernel.org # 3.14
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Johan Hovold <johan@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260911090132.723531-1-johan@kernel.org?part=1
prev parent reply other threads:[~2026-09-11 9:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 9:01 [PATCH] tty: amiserial: fix broken TIOCMIWAIT Johan Hovold
2026-09-11 9:06 ` Jiri Slaby
2026-09-11 9:17 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260911091719.119821F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=johan@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.