From: sashiko-bot@kernel.org
To: "Mahanta Jambigi" <mjambigi@linux.ibm.com>
Cc: "Heiko Carstens" <hca@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>
Subject: Re: [PATCH net v4] net/smc: fix lgr/lnk lifetime vs diag reader race
Date: Fri, 11 Sep 2026 09:30:19 +0000 [thread overview]
Message-ID: <20260911093019.EF0DD1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260911090906.1949163-1-mjambigi@linux.ibm.com>
> The diag dump walks the socket hash table under a read_lock and dereferences
> conn->lgr and conn->lnk. Two terminal teardown paths drop those references via
> smc_conn_free() while the socket is still hashed:
>
> - smc_conn_kill() -> smc_close_active_abort() -> smc_conn_free()
> - smc_close_passive_work() -> smc_conn_free()
>
> This allows the diag reader to dereference a freed lgr or lnk.
>
> Fix it by unhashing the socket before smc_conn_free() is called at each of these
> two sites. Any socket visible to the diag reader under the hash read_lock then
> has valid conn->lgr and conn->lnk pointers.
>
> Fixes: f16a7dd5cf27 ("smc: netlink interface for SMC sockets")
> Fixes: 9dbe086c69b8 ("net/smc: fix invalid link access in dumping SMC-R connections")
> Signed-off-by: Mahanta Jambigi <mjambigi@linux.ibm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260911090906.1949163-1-mjambigi@linux.ibm.com?part=1
prev parent reply other threads:[~2026-09-11 9:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 9:09 [PATCH net v4] net/smc: fix lgr/lnk lifetime vs diag reader race Mahanta Jambigi
2026-09-11 9:30 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260911093019.EF0DD1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjambigi@linux.ibm.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.