From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
James Burton <jamesburton@meta.com>
Subject: Re: [PATCH net] netlink: do not free nlk->groups while lockless readers can use it
Date: Fri, 11 Sep 2026 09:49:31 -0700 [thread overview]
Message-ID: <20260911094931.12e0339e@kernel.org> (raw)
In-Reply-To: <20260911160804.917099-1-edumazet@google.com>
On Fri, 11 Sep 2026 16:08:04 +0000 Eric Dumazet wrote:
> + /* Publish the new bitmap and its content: pairs with the address
> + * dependency in lockless readers, which can pick up the new pointer
> + * while still seeing the old (smaller) nlk->ngroups.
> + */
What do you think about the value of these comments, Eric?
> + smp_store_release(&nlk->groups, new_groups);
next prev parent reply other threads:[~2026-09-11 16:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 16:08 [PATCH net] netlink: do not free nlk->groups while lockless readers can use it Eric Dumazet
2026-09-11 16:49 ` Jakub Kicinski [this message]
2026-09-11 16:59 ` Eric Dumazet
2026-09-16 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260911094931.12e0339e@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=jamesburton@meta.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.