Re: [LTP] [PATCH v2] lib: Check minimal supported kernel version

[Petr Vorel <pvorel@suse.cz>]

> Hi!
> > > +
> > > +	if (tst_kvercmp(v1, v2, v3) < 0)
> > > +		tst_brk(TWARN, "Kernel is older than minimal supported %s", TST_MIN_KVER);
> > > +}

> > @Cyril @Petr I'm wondering if this should be tst_res(TWARN, ..) instead.

> Sorry missed that, yes, that was the point I was trying to make, that
> this shouldn't exit the test. Only produce a message.

As I pointed in v1 even tst_res(TWARN) might be too aggressive as it makes all
tests exit with 4 (=> non-zero) due TWARN.

tst_res(TINFO, "WARNING: ...") would not do that and still warn users.

But since we at SUSE are probably the users of the oldest kernels we don't have
to worry that much. (+ I know it's already merged.)

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp