From: Simon Horman <horms@kernel.org>
To: Mohsin Bashir <mohsin.bashr@gmail.com>
Cc: netdev@vger.kernel.org, alexanderduyck@fb.com, kuba@kernel.org,
kernel-team@meta.com, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com,
mike.marciniszyn@gmail.com, lee@trager.us,
jacob.e.keller@intel.com, leitao@debian.org,
vadim.fedorenko@linux.dev, daskald@meta.com,
bobbyeshleman@meta.com, asml.silence@gmail.com
Subject: Re: [PATCH net-next] eth: fbnic: Make Rx completion coalescing configurable
Date: Fri, 11 Sep 2026 11:19:21 +0100 [thread overview]
Message-ID: <20260911101921.GA48209@horms.kernel.org> (raw)
In-Reply-To: <20260909211111.1795726-1-mohsin.bashr@gmail.com>
On Wed, Sep 09, 2026 at 02:11:11PM -0700, Mohsin Bashir wrote:
> From: Mohsin Bashir <hmohsin@meta.com>
>
> The Rx completion queue writeback coalescing window controls how long
> the queue manager may defer writing completions to host memory.
>
> Expose this window through the standard rx-cqe-nsecs ethtool
> parameter. Preserve the existing 2000 ns default and accept values
> from 1000 ns through the device maximum (~109 us).
>
> Hardware expresses COAL_WAIT in 600 MHz core clock cycles, or 1.667 ns
> per cycle. Programming rounds the configured value to the nearest clock
> cycle, resulting in an error of less than 1 ns. Retain the requested
> value for get_coalesce() because this error is below the one-nanosecond
> resolution of the ethtool interface.
>
> Signed-off-by: Mohsin Bashir <hmohsin@meta.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-09-11 10:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 21:11 [PATCH net-next] eth: fbnic: Make Rx completion coalescing configurable Mohsin Bashir
2026-09-11 10:19 ` Simon Horman [this message]
2026-09-12 0:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260911101921.GA48209@horms.kernel.org \
--to=horms@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=asml.silence@gmail.com \
--cc=bobbyeshleman@meta.com \
--cc=daskald@meta.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=lee@trager.us \
--cc=leitao@debian.org \
--cc=mike.marciniszyn@gmail.com \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.