diff for duplicates of <202609111050.oiut4oST-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 566f865..df3db82 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,14 +1,6 @@ -BCC: lkp@intel.com -CC: oe-kbuild-all@lists.linux.dev -CC: linux-arm-kernel@lists.infradead.org -CC: arm@kernel.org -TO: Arnd Bergmann <arnd@arndb.de> - tree: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git board-remove-7.3 head: cf983087c51a9c74c3d4d3b353eb811ae5030823 commit: 4df92b98525f08e1eab92a25f5da2045c78403e8 [182/295] hwmon: asd7828: remove pdata based probing -:::::: branch date: 15 hours ago -:::::: commit date: 15 hours ago config: arm-randconfig-r071-20260911 (https://download.01.org/0day-ci/archive/20260911/202609111050.oiut4oST-lkp@intel.com/config) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) smatch: v0.5.0-9187-g5189e3fb @@ -24,22 +16,6 @@ drivers/hwmon/ads7828.c:121 ads7828_probe() warn: if statement not indented vim +121 drivers/hwmon/ads7828.c -bea0bab0fcf5a0 Guenter Roeck 2015-01-16 100 -673afe466166cd Stephen Kitt 2020-08-21 101 static int ads7828_probe(struct i2c_client *client) -7347cb388e5aec Jean Delvare 2008-07-16 102 { -f82b2c344994f2 Axel Lin 2014-06-17 103 struct device *dev = &client->dev; -7347cb388e5aec Jean Delvare 2008-07-16 104 struct ads7828_data *data; -f82b2c344994f2 Axel Lin 2014-06-17 105 struct device *hwmon_dev; -7f444bf0a28c03 Guenter Roeck 2015-01-16 106 unsigned int vref_mv = ADS7828_INT_VREF_MV; -fddb5ceaf901b0 Qingshuang Fu 2026-08-05 107 int vref_uv; -7f444bf0a28c03 Guenter Roeck 2015-01-16 108 bool diff_input = false; -7f444bf0a28c03 Guenter Roeck 2015-01-16 109 bool ext_vref = false; -7a18afe8097731 Akshay Bhat 2016-04-18 110 unsigned int regval; -2d688f1413aba3 Javier Martinez Canillas 2017-02-24 111 enum ads7828_chips chip; -5812f9283e6213 Steve Hardy 2008-01-22 112 -f82b2c344994f2 Axel Lin 2014-06-17 113 data = devm_kzalloc(dev, sizeof(struct ads7828_data), GFP_KERNEL); -34e3f7f5a283c5 Guenter Roeck 2012-06-02 114 if (!data) -34e3f7f5a283c5 Guenter Roeck 2012-06-02 115 return -ENOMEM; 5812f9283e6213 Steve Hardy 2008-01-22 116 a8ddfea09566c3 Sam Povilus 2017-03-29 117 diff_input = of_property_read_bool(dev->of_node, a8ddfea09566c3 Sam Povilus 2017-03-29 118 "ti,differential-input"); @@ -47,6 +23,9 @@ fddb5ceaf901b0 Qingshuang Fu 2026-08-05 119 vref_uv = devm_regulat fddb5ceaf901b0 Qingshuang Fu 2026-08-05 120 if (vref_uv < 0) { fddb5ceaf901b0 Qingshuang Fu 2026-08-05 @121 if (vref_uv != -ENODEV) fddb5ceaf901b0 Qingshuang Fu 2026-08-05 122 return vref_uv; + +Add another tab before the return. + fddb5ceaf901b0 Qingshuang Fu 2026-08-05 123 } else { a8ddfea09566c3 Sam Povilus 2017-03-29 124 vref_mv = DIV_ROUND_CLOSEST(vref_uv, 1000); a8ddfea09566c3 Sam Povilus 2017-03-29 125 if (vref_mv < ADS7828_EXT_VREF_MV_MIN || @@ -54,53 +33,6 @@ a8ddfea09566c3 Sam Povilus 2017-03-29 126 vref_mv > ADS7828 a8ddfea09566c3 Sam Povilus 2017-03-29 127 return -EINVAL; a8ddfea09566c3 Sam Povilus 2017-03-29 128 ext_vref = true; a8ddfea09566c3 Sam Povilus 2017-03-29 129 } -46d784629202c5 Vivien Didelot 2012-10-03 130 -ec6755630773bb Andrew Davis 2024-04-03 131 chip = (uintptr_t)i2c_get_match_data(client); -2d688f1413aba3 Javier Martinez Canillas 2017-02-24 132 -7f444bf0a28c03 Guenter Roeck 2015-01-16 133 /* Bound Vref with min/max values */ -7f444bf0a28c03 Guenter Roeck 2015-01-16 134 vref_mv = clamp_val(vref_mv, ADS7828_EXT_VREF_MV_MIN, -46d784629202c5 Vivien Didelot 2012-10-03 135 ADS7828_EXT_VREF_MV_MAX); -46d784629202c5 Vivien Didelot 2012-10-03 136 -0962e0f1a5634b Guillaume Roguez 2012-10-03 137 /* ADS7828 uses 12-bit samples, while ADS7830 is 8-bit */ -2d688f1413aba3 Javier Martinez Canillas 2017-02-24 138 if (chip == ads7828) { -7f444bf0a28c03 Guenter Roeck 2015-01-16 139 data->lsb_resol = DIV_ROUND_CLOSEST(vref_mv * 1000, 4096); -bea0bab0fcf5a0 Guenter Roeck 2015-01-16 140 data->regmap = devm_regmap_init_i2c(client, -bea0bab0fcf5a0 Guenter Roeck 2015-01-16 141 &ads2828_regmap_config); -0962e0f1a5634b Guillaume Roguez 2012-10-03 142 } else { -7f444bf0a28c03 Guenter Roeck 2015-01-16 143 data->lsb_resol = DIV_ROUND_CLOSEST(vref_mv * 1000, 256); -bea0bab0fcf5a0 Guenter Roeck 2015-01-16 144 data->regmap = devm_regmap_init_i2c(client, -bea0bab0fcf5a0 Guenter Roeck 2015-01-16 145 &ads2830_regmap_config); -0962e0f1a5634b Guillaume Roguez 2012-10-03 146 } -46d784629202c5 Vivien Didelot 2012-10-03 147 -d9ef72cd1c15c2 Axel Lin 2015-02-10 148 if (IS_ERR(data->regmap)) -d9ef72cd1c15c2 Axel Lin 2015-02-10 149 return PTR_ERR(data->regmap); -d9ef72cd1c15c2 Axel Lin 2015-02-10 150 -7f444bf0a28c03 Guenter Roeck 2015-01-16 151 data->cmd_byte = ext_vref ? ADS7828_CMD_PD1 : ADS7828_CMD_PD3; -7f444bf0a28c03 Guenter Roeck 2015-01-16 152 if (!diff_input) -46d784629202c5 Vivien Didelot 2012-10-03 153 data->cmd_byte |= ADS7828_CMD_SD_SE; -46d784629202c5 Vivien Didelot 2012-10-03 154 -7a18afe8097731 Akshay Bhat 2016-04-18 155 /* -7a18afe8097731 Akshay Bhat 2016-04-18 156 * Datasheet specifies internal reference voltage is disabled by -7a18afe8097731 Akshay Bhat 2016-04-18 157 * default. The internal reference voltage needs to be enabled and -7a18afe8097731 Akshay Bhat 2016-04-18 158 * voltage needs to settle before getting valid ADC data. So perform a -7a18afe8097731 Akshay Bhat 2016-04-18 159 * dummy read to enable the internal reference voltage. -7a18afe8097731 Akshay Bhat 2016-04-18 160 */ -7a18afe8097731 Akshay Bhat 2016-04-18 161 if (!ext_vref) -7a18afe8097731 Akshay Bhat 2016-04-18 162 regmap_read(data->regmap, data->cmd_byte, ®val); -7a18afe8097731 Akshay Bhat 2016-04-18 163 -f82b2c344994f2 Axel Lin 2014-06-17 164 hwmon_dev = devm_hwmon_device_register_with_groups(dev, client->name, -f82b2c344994f2 Axel Lin 2014-06-17 165 data, -f82b2c344994f2 Axel Lin 2014-06-17 166 ads7828_groups); -f82b2c344994f2 Axel Lin 2014-06-17 167 return PTR_ERR_OR_ZERO(hwmon_dev); -5812f9283e6213 Steve Hardy 2008-01-22 168 } -5812f9283e6213 Steve Hardy 2008-01-22 169 - -:::::: The code at line 121 was first introduced by commit -:::::: fddb5ceaf901b050ed2a1a7deeecbf97e003435a hwmon: (ads7828) Fix external VREF regulator handling - -:::::: TO: Qingshuang Fu <fuqingshuang@kylinos.cn> -:::::: CC: Guenter Roeck <linux@roeck-us.net> - -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki diff --git a/a/content_digest b/N1/content_digest index a5b97ed..d1f5c84 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,22 +1,17 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <error27@gmail.com>\0" "Subject\0[soc:board-remove-7.3 182/295] drivers/hwmon/ads7828.c:121 ads7828_probe() warn: if statement not indented\0" - "Date\0Fri, 11 Sep 2026 10:52:40 +0200\0" - "To\0oe-kbuild@lists.linux.dev\0" + "Date\0Fri, 11 Sep 2026 15:23:28 +0300\0" + "To\0oe-kbuild@lists.linux.dev" + " Arnd Bergmann <arnd@arndb.de>\0" "Cc\0lkp@intel.com" - " Dan Carpenter <error27@gmail.com>\0" + oe-kbuild-all@lists.linux.dev + linux-arm-kernel@lists.infradead.org + " arm@kernel.org\0" "\00:1\0" "b\0" - "BCC: lkp@intel.com\n" - "CC: oe-kbuild-all@lists.linux.dev\n" - "CC: linux-arm-kernel@lists.infradead.org\n" - "CC: arm@kernel.org\n" - "TO: Arnd Bergmann <arnd@arndb.de>\n" - "\n" "tree: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git board-remove-7.3\n" "head: cf983087c51a9c74c3d4d3b353eb811ae5030823\n" "commit: 4df92b98525f08e1eab92a25f5da2045c78403e8 [182/295] hwmon: asd7828: remove pdata based probing\n" - ":::::: branch date: 15 hours ago\n" - ":::::: commit date: 15 hours ago\n" "config: arm-randconfig-r071-20260911 (https://download.01.org/0day-ci/archive/20260911/202609111050.oiut4oST-lkp@intel.com/config)\n" "compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)\n" "smatch: v0.5.0-9187-g5189e3fb\n" @@ -32,22 +27,6 @@ "\n" "vim +121 drivers/hwmon/ads7828.c\n" "\n" - "bea0bab0fcf5a0 Guenter Roeck 2015-01-16 100 \n" - "673afe466166cd Stephen Kitt 2020-08-21 101 static int ads7828_probe(struct i2c_client *client)\n" - "7347cb388e5aec Jean Delvare 2008-07-16 102 {\n" - "f82b2c344994f2 Axel Lin 2014-06-17 103 \tstruct device *dev = &client->dev;\n" - "7347cb388e5aec Jean Delvare 2008-07-16 104 \tstruct ads7828_data *data;\n" - "f82b2c344994f2 Axel Lin 2014-06-17 105 \tstruct device *hwmon_dev;\n" - "7f444bf0a28c03 Guenter Roeck 2015-01-16 106 \tunsigned int vref_mv = ADS7828_INT_VREF_MV;\n" - "fddb5ceaf901b0 Qingshuang Fu 2026-08-05 107 \tint vref_uv;\n" - "7f444bf0a28c03 Guenter Roeck 2015-01-16 108 \tbool diff_input = false;\n" - "7f444bf0a28c03 Guenter Roeck 2015-01-16 109 \tbool ext_vref = false;\n" - "7a18afe8097731 Akshay Bhat 2016-04-18 110 \tunsigned int regval;\n" - "2d688f1413aba3 Javier Martinez Canillas 2017-02-24 111 \tenum ads7828_chips chip;\n" - "5812f9283e6213 Steve Hardy 2008-01-22 112 \n" - "f82b2c344994f2 Axel Lin 2014-06-17 113 \tdata = devm_kzalloc(dev, sizeof(struct ads7828_data), GFP_KERNEL);\n" - "34e3f7f5a283c5 Guenter Roeck 2012-06-02 114 \tif (!data)\n" - "34e3f7f5a283c5 Guenter Roeck 2012-06-02 115 \t\treturn -ENOMEM;\n" "5812f9283e6213 Steve Hardy 2008-01-22 116 \n" "a8ddfea09566c3 Sam Povilus 2017-03-29 117 \tdiff_input = of_property_read_bool(dev->of_node,\n" "a8ddfea09566c3 Sam Povilus 2017-03-29 118 \t\t\t\t\t \"ti,differential-input\");\n" @@ -55,6 +34,9 @@ "fddb5ceaf901b0 Qingshuang Fu 2026-08-05 120 \tif (vref_uv < 0) {\n" "fddb5ceaf901b0 Qingshuang Fu 2026-08-05 @121 \t\tif (vref_uv != -ENODEV)\n" "fddb5ceaf901b0 Qingshuang Fu 2026-08-05 122 \t\treturn vref_uv;\n" + "\n" + "Add another tab before the return.\n" + "\n" "fddb5ceaf901b0 Qingshuang Fu 2026-08-05 123 \t} else {\n" "a8ddfea09566c3 Sam Povilus 2017-03-29 124 \t\tvref_mv = DIV_ROUND_CLOSEST(vref_uv, 1000);\n" "a8ddfea09566c3 Sam Povilus 2017-03-29 125 \t\tif (vref_mv < ADS7828_EXT_VREF_MV_MIN ||\n" @@ -62,55 +44,8 @@ "a8ddfea09566c3 Sam Povilus 2017-03-29 127 \t\t\treturn -EINVAL;\n" "a8ddfea09566c3 Sam Povilus 2017-03-29 128 \t\text_vref = true;\n" "a8ddfea09566c3 Sam Povilus 2017-03-29 129 \t}\n" - "46d784629202c5 Vivien Didelot 2012-10-03 130 \n" - "ec6755630773bb Andrew Davis 2024-04-03 131 \tchip = (uintptr_t)i2c_get_match_data(client);\n" - "2d688f1413aba3 Javier Martinez Canillas 2017-02-24 132 \n" - "7f444bf0a28c03 Guenter Roeck 2015-01-16 133 \t/* Bound Vref with min/max values */\n" - "7f444bf0a28c03 Guenter Roeck 2015-01-16 134 \tvref_mv = clamp_val(vref_mv, ADS7828_EXT_VREF_MV_MIN,\n" - "46d784629202c5 Vivien Didelot 2012-10-03 135 \t\t\t ADS7828_EXT_VREF_MV_MAX);\n" - "46d784629202c5 Vivien Didelot 2012-10-03 136 \n" - "0962e0f1a5634b Guillaume Roguez 2012-10-03 137 \t/* ADS7828 uses 12-bit samples, while ADS7830 is 8-bit */\n" - "2d688f1413aba3 Javier Martinez Canillas 2017-02-24 138 \tif (chip == ads7828) {\n" - "7f444bf0a28c03 Guenter Roeck 2015-01-16 139 \t\tdata->lsb_resol = DIV_ROUND_CLOSEST(vref_mv * 1000, 4096);\n" - "bea0bab0fcf5a0 Guenter Roeck 2015-01-16 140 \t\tdata->regmap = devm_regmap_init_i2c(client,\n" - "bea0bab0fcf5a0 Guenter Roeck 2015-01-16 141 \t\t\t\t\t\t &ads2828_regmap_config);\n" - "0962e0f1a5634b Guillaume Roguez 2012-10-03 142 \t} else {\n" - "7f444bf0a28c03 Guenter Roeck 2015-01-16 143 \t\tdata->lsb_resol = DIV_ROUND_CLOSEST(vref_mv * 1000, 256);\n" - "bea0bab0fcf5a0 Guenter Roeck 2015-01-16 144 \t\tdata->regmap = devm_regmap_init_i2c(client,\n" - "bea0bab0fcf5a0 Guenter Roeck 2015-01-16 145 \t\t\t\t\t\t &ads2830_regmap_config);\n" - "0962e0f1a5634b Guillaume Roguez 2012-10-03 146 \t}\n" - "46d784629202c5 Vivien Didelot 2012-10-03 147 \n" - "d9ef72cd1c15c2 Axel Lin 2015-02-10 148 \tif (IS_ERR(data->regmap))\n" - "d9ef72cd1c15c2 Axel Lin 2015-02-10 149 \t\treturn PTR_ERR(data->regmap);\n" - "d9ef72cd1c15c2 Axel Lin 2015-02-10 150 \n" - "7f444bf0a28c03 Guenter Roeck 2015-01-16 151 \tdata->cmd_byte = ext_vref ? ADS7828_CMD_PD1 : ADS7828_CMD_PD3;\n" - "7f444bf0a28c03 Guenter Roeck 2015-01-16 152 \tif (!diff_input)\n" - "46d784629202c5 Vivien Didelot 2012-10-03 153 \t\tdata->cmd_byte |= ADS7828_CMD_SD_SE;\n" - "46d784629202c5 Vivien Didelot 2012-10-03 154 \n" - "7a18afe8097731 Akshay Bhat 2016-04-18 155 \t/*\n" - "7a18afe8097731 Akshay Bhat 2016-04-18 156 \t * Datasheet specifies internal reference voltage is disabled by\n" - "7a18afe8097731 Akshay Bhat 2016-04-18 157 \t * default. The internal reference voltage needs to be enabled and\n" - "7a18afe8097731 Akshay Bhat 2016-04-18 158 \t * voltage needs to settle before getting valid ADC data. So perform a\n" - "7a18afe8097731 Akshay Bhat 2016-04-18 159 \t * dummy read to enable the internal reference voltage.\n" - "7a18afe8097731 Akshay Bhat 2016-04-18 160 \t */\n" - "7a18afe8097731 Akshay Bhat 2016-04-18 161 \tif (!ext_vref)\n" - "7a18afe8097731 Akshay Bhat 2016-04-18 162 \t\tregmap_read(data->regmap, data->cmd_byte, ®val);\n" - "7a18afe8097731 Akshay Bhat 2016-04-18 163 \n" - "f82b2c344994f2 Axel Lin 2014-06-17 164 \thwmon_dev = devm_hwmon_device_register_with_groups(dev, client->name,\n" - "f82b2c344994f2 Axel Lin 2014-06-17 165 \t\t\t\t\t\t\t data,\n" - "f82b2c344994f2 Axel Lin 2014-06-17 166 \t\t\t\t\t\t\t ads7828_groups);\n" - "f82b2c344994f2 Axel Lin 2014-06-17 167 \treturn PTR_ERR_OR_ZERO(hwmon_dev);\n" - "5812f9283e6213 Steve Hardy 2008-01-22 168 }\n" - "5812f9283e6213 Steve Hardy 2008-01-22 169 \n" - "\n" - ":::::: The code at line 121 was first introduced by commit\n" - ":::::: fddb5ceaf901b050ed2a1a7deeecbf97e003435a hwmon: (ads7828) Fix external VREF regulator handling\n" - "\n" - ":::::: TO: Qingshuang Fu <fuqingshuang@kylinos.cn>\n" - ":::::: CC: Guenter Roeck <linux@roeck-us.net>\n" - "\n" "--\n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -b8e87839138033e37de2dc549f23f5b98d0f0993d7783ee189c95e2a0033e2c1 +1bbd5b37704597df178e23eb11d94c05c4f5be7d68a80b4ea39ad3539ef90bb0
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.