From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Samuel Holland <samuel@sholland.org>,
Maxime Ripard <mripard@kernel.org>, Sean Young <sean@mess.org>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Sasha Levin <sashal@kernel.org>
Subject: [PATCH 5.10.y 1/2] media: sunxi-cir: Clean up dead register writes
Date: Fri, 11 Sep 2026 08:29:48 -0400 [thread overview]
Message-ID: <20260911122949.555717-1-sashal@kernel.org> (raw)
In-Reply-To: <2026090910-petal-cupcake-2b81@gregkh>
From: Samuel Holland <samuel@sholland.org>
[ Upstream commit 586bb700b3256a1cb38935f83c76e6522ac53d64 ]
The register writes during driver removal occur after the device is
already put back in reset, so they never had any effect.
Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Samuel Holland <samuel@sholland.org>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Stable-dep-of: 479aa6fa8c50 ("media: rc: sunxi-cir: Unregister rc device on probe failure")
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/media/rc/sunxi-cir.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/media/rc/sunxi-cir.c b/drivers/media/rc/sunxi-cir.c
index 4afc5895bee74..7a67e79d637a3 100644
--- a/drivers/media/rc/sunxi-cir.c
+++ b/drivers/media/rc/sunxi-cir.c
@@ -310,22 +310,12 @@ static int sunxi_ir_probe(struct platform_device *pdev)
static int sunxi_ir_remove(struct platform_device *pdev)
{
- unsigned long flags;
struct sunxi_ir *ir = platform_get_drvdata(pdev);
clk_disable_unprepare(ir->clk);
clk_disable_unprepare(ir->apb_clk);
reset_control_assert(ir->rst);
- spin_lock_irqsave(&ir->ir_lock, flags);
- /* disable IR IRQ */
- writel(0, ir->base + SUNXI_IR_RXINT_REG);
- /* clear All Rx Interrupt Status */
- writel(REG_RXSTA_CLEARALL, ir->base + SUNXI_IR_RXSTA_REG);
- /* disable IR */
- writel(0, ir->base + SUNXI_IR_CTL_REG);
- spin_unlock_irqrestore(&ir->ir_lock, flags);
-
rc_unregister_device(ir->rc);
return 0;
}
--
2.53.0
next prev parent reply other threads:[~2026-09-11 12:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 10:48 FAILED: patch "[PATCH] media: rc: sunxi-cir: Unregister rc device on probe failure" failed to apply to 5.10-stable tree gregkh
2026-09-11 12:29 ` Sasha Levin [this message]
2026-09-11 12:29 ` [PATCH 5.10.y 2/2] media: rc: sunxi-cir: Unregister rc device on probe failure Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260911122949.555717-1-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mripard@kernel.org \
--cc=samuel@sholland.org \
--cc=sean@mess.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.