From: sashiko-bot@kernel.org
To: "Thomas Zimmermann" <tzimmermann@suse.de>
Cc: linux-hyperv@vger.kernel.org,
"Eugenio Perez" <eperezma@redhat.com>,
intel-gfx@lists.freedesktop.org, ojeda@kernel.org,
virtualization@lists.linux.dev, imx@lists.linux.dev,
wsa+renesas@sang-engineering.com, gary@garyguo.net,
dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
"Michael S. Tsirkin" <mst@redhat.com>,
Frank.Li@kernel.org
Subject: Re: [PATCH v5 01/14] drm/panic: Do not use un-escaped URL as format string
Date: Fri, 11 Sep 2026 12:54:25 +0000 [thread overview]
Message-ID: <20260911125425.EFC8A1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260911124540.279841-2-tzimmermann@suse.de>
> Replace the direct use of DRM_PANIC_SCREEN_QR_CODE_URL in snprintf()
> with a %s conversion specifier. Avoids a possible vulnerabilty from
> a crafted URL string.
>
> As the attacker needs to control the kernel at the Kconfig level, the
> potential for an exploit is likely low.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260911124540.279841-1-tzimmermann@suse.de?part=1
next prev parent reply other threads:[~2026-09-11 12:54 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 12:43 [PATCH v5 00/14] drm/panic: Split into core and helpers Thomas Zimmermann
2026-09-11 12:43 ` Thomas Zimmermann
2026-09-11 12:43 ` [PATCH v5 01/14] drm/panic: Do not use un-escaped URL as format string Thomas Zimmermann
2026-09-11 12:43 ` Thomas Zimmermann
2026-09-11 12:54 ` sashiko-bot [this message]
2026-09-11 12:43 ` [PATCH v5 02/14] drm/panic: Test address from kmap op for NULL Thomas Zimmermann
2026-09-11 12:43 ` Thomas Zimmermann
2026-09-11 12:58 ` sashiko-bot
2026-09-11 12:43 ` [PATCH v5 03/14] drm/panic: Return -EINVAL if font is not available Thomas Zimmermann
2026-09-11 12:43 ` Thomas Zimmermann
2026-09-11 12:53 ` sashiko-bot
2026-09-11 12:43 ` [PATCH v5 04/14] drm/panic: Return errno codes if panic output fails Thomas Zimmermann
2026-09-11 12:43 ` Thomas Zimmermann
2026-09-11 12:56 ` sashiko-bot
2026-09-11 12:43 ` [PATCH v5 05/14] drm/panic: Pass colors to draw_panic_dispatch() Thomas Zimmermann
2026-09-11 12:43 ` Thomas Zimmermann
2026-09-11 12:54 ` sashiko-bot
2026-09-11 12:43 ` [PATCH v5 06/14] drm/panic: Pass global module parameters to drm_panic_dispatch() Thomas Zimmermann
2026-09-11 12:43 ` Thomas Zimmermann
2026-09-11 12:56 ` sashiko-bot
2026-09-11 12:44 ` [PATCH v5 07/14] drm/panic: Return from screen_user if display is too small Thomas Zimmermann
2026-09-11 12:44 ` Thomas Zimmermann
2026-09-11 12:54 ` sashiko-bot
2026-09-11 12:44 ` [PATCH v5 08/14] drm/panic: Retry in dispatch function if panic output fails Thomas Zimmermann
2026-09-11 12:44 ` Thomas Zimmermann
2026-09-11 12:54 ` sashiko-bot
2026-09-11 12:44 ` [PATCH v5 09/14] drm/panic: Split draw_panic_plane() Thomas Zimmermann
2026-09-11 12:44 ` Thomas Zimmermann
2026-09-11 12:53 ` sashiko-bot
2026-09-11 12:44 ` [PATCH v5 10/14] drm/panic: Restrict to primary planes Thomas Zimmermann
2026-09-11 12:44 ` Thomas Zimmermann
2026-09-11 12:55 ` sashiko-bot
2026-09-11 12:44 ` [PATCH v5 11/14] drm/panic: Display panic screen via per-plane callback Thomas Zimmermann
2026-09-11 12:44 ` Thomas Zimmermann
2026-09-11 12:59 ` sashiko-bot
2026-09-11 12:44 ` [PATCH v5 12/14] drm/panic: Internalize panic locking in DRM core and helpers Thomas Zimmermann
2026-09-11 12:44 ` Thomas Zimmermann
2026-09-11 12:59 ` sashiko-bot
2026-09-11 12:44 ` [PATCH v5 13/14] drm/panic: Move panic display code into helper library Thomas Zimmermann
2026-09-11 12:44 ` Thomas Zimmermann
2026-09-11 12:59 ` sashiko-bot
2026-09-11 12:44 ` [PATCH v5 14/14] drm/panic: Compile KUnit tests as module Thomas Zimmermann
2026-09-11 12:44 ` Thomas Zimmermann
2026-09-11 13:01 ` sashiko-bot
2026-09-11 13:19 ` ✗ CI.checkpatch: warning for drm/panic: Split into core and helpers (rev5) Patchwork
2026-09-11 13:21 ` ✓ CI.KUnit: success " Patchwork
2026-09-11 14:02 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-11 17:23 ` ✗ i915.CI.BAT: failure " Patchwork
2026-09-11 22:17 ` ✓ Xe.CI.FULL: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260911125425.EFC8A1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eperezma@redhat.com \
--cc=gary@garyguo.net \
--cc=imx@lists.linux.dev \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=mst@redhat.com \
--cc=ojeda@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.