All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: Linux Test Project <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 1/3] lapi/mmap: add MAP_32BIT fallback
Date: Fri, 11 Sep 2026 15:20:38 +0200	[thread overview]
Message-ID: <20260911132038.GA1488703@pevik> (raw)
In-Reply-To: <20260828-mmap_32bit_coverage-v1-1-7f0b8b589773@suse.com>

Hi Andrea,

> +++ b/include/lapi/mmap.h
> @@ -91,6 +91,10 @@
>  # define MAP_DROPPABLE 0x08
>  #endif

> +#ifndef MAP_32BIT
> +# define MAP_32BIT 0x40

I know you guard the tests with .supported_archs to x86_64, but even that
wouldn't be safer to define 0x40 only for x86_64?

#ifndef MAP_32BIT
# if defined __i386__ || defined(__x86_64__)
#  define MAP_32BIT 0x40
# else
#  define MAP_32BIT 0
# endif
#endif

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2026-09-11 13:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28 15:36 [LTP] [PATCH 0/3] mmap testing suite to cover MAP_32BIT Andrea Cervesato
2026-08-28 15:36 ` [LTP] [PATCH 1/3] lapi/mmap: add MAP_32BIT fallback Andrea Cervesato
2026-08-28 21:10   ` [LTP] " linuxtestproject.agent
2026-08-31  8:02     ` Andrea Cervesato via ltp
2026-09-11 13:20   ` Petr Vorel [this message]
2026-09-11 13:26     ` [LTP] [PATCH 1/3] " Petr Vorel
2026-08-28 15:36 ` [LTP] [PATCH 2/3] mmap23: add test for MAP_32BIT oversized mapping Andrea Cervesato
2026-09-11 14:08   ` Petr Vorel
2026-08-28 15:36 ` [LTP] [PATCH 3/3] mmap24: add test for MAP_32BIT address limit Andrea Cervesato
2026-09-10 14:38   ` Cyril Hrubis
2026-09-11 13:59   ` Petr Vorel
2026-09-11 15:16     ` Andrea Cervesato via ltp
2026-09-11 16:03       ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260911132038.GA1488703@pevik \
    --to=pvorel@suse.cz \
    --cc=andrea.cervesato@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.