All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Petr Pavlu" <petr.pavlu@suse.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
	"Heiko Carstens" <hca@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>,
	"Vasily Gorbik" <gor@linux.ibm.com>,
	linux-modules@vger.kernel.org,
	"Alexander Gordeev" <agordeev@linux.ibm.com>
Subject: Re: [PATCH v2 2/6] s390: Avoid indirect includes through linux/module.h -> linux/elf.h
Date: Fri, 11 Sep 2026 14:45:00 +0000	[thread overview]
Message-ID: <20260911144500.97E861F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260911-module-include-elf-v2-2-954c732975fb@suse.com>

> Several s390 files use declarations that are provided indirectly through
> linux/module.h -> linux/elf.h:
> 
> * arch/s390/kernel/nospec-branch.c: s390_kernel_write() -> linux/uaccess.h,
> * drivers/s390/char/uvdevice.c: copy_to_user(), copy_from_user(),
>   put_user(), get_user() -> linux/uaccess.h; file_operations -> linux/fs.h.
> 
> Add the missing includes to these files in preparation for removing the
> linux/elf.h include from linux/module.h.
> 
> Signed-off-by: Petr Pavlu <petr.pavlu@suse.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260911-module-include-elf-v2-0-954c732975fb@suse.com?part=2


  reply	other threads:[~2026-09-11 14:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11 14:40 [PATCH v2 0/6] module: Limit ELF includes in linux/module.h to uapi/linux/elf.h Petr Pavlu
2026-09-11 14:40 ` [PATCH v2 1/6] x86: Avoid indirect includes through linux/module.h -> linux/elf.h Petr Pavlu
2026-09-11 14:44   ` sashiko-bot
2026-09-11 14:40 ` [PATCH v2 2/6] s390: " Petr Pavlu
2026-09-11 14:45   ` sashiko-bot [this message]
2026-09-11 14:40 ` [PATCH v2 3/6] drivers: Include linux/slab.h for kmalloc() functions Petr Pavlu
2026-09-11 14:44   ` sashiko-bot
2026-09-11 14:40 ` [PATCH v2 4/6] s390: Remove the asm/mmu_context.h include from asm/elf.h Petr Pavlu
2026-09-11 14:48   ` sashiko-bot
2026-09-11 14:40 ` [PATCH v2 5/6] cpufeature: Include asm/elf.h for ELF_PLATFORM Petr Pavlu
2026-09-11 14:46   ` sashiko-bot
2026-09-11 14:40 ` [PATCH v2 6/6] module: Limit ELF includes in linux/module.h to uapi/linux/elf.h Petr Pavlu
2026-09-11 14:55   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260911144500.97E861F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=petr.pavlu@suse.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.