All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konstantin Shkolnyy <kshk@linux.ibm.com>
To: mjrosato@linux.ibm.com
Cc: alifm@linux.ibm.com, farman@linux.ibm.com,
	richard.henderson@linaro.org, iii@linux.ibm.com,
	david@kernel.org, cohuck@redhat.com, pasic@linux.ibm.com,
	borntraeger@linux.ibm.com, qemu-s390x@nongnu.org,
	qemu-devel@nongnu.org, Konstantin Shkolnyy <kshk@linux.ibm.com>
Subject: [PATCH v8 13/16] s390x/pci: Add a comment explaining S390PCIIOMMU purpose
Date: Fri, 11 Sep 2026 10:21:34 -0500	[thread overview]
Message-ID: <20260911152137.676602-14-kshk@linux.ibm.com> (raw)
In-Reply-To: <20260911152137.676602-1-kshk@linux.ibm.com>

Now that S390PCIIOMMU had been reduced to only the IOMMU container
information needed by the PCI layer for the associated slot, add a
comment explaining the purpose of the structure.

Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
Signed-off-by: Konstantin Shkolnyy <kshk@linux.ibm.com>
---
 include/hw/s390x/s390-pci-bus.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/include/hw/s390x/s390-pci-bus.h b/include/hw/s390x/s390-pci-bus.h
index e3cbee2695..0a59be1fd0 100644
--- a/include/hw/s390x/s390-pci-bus.h
+++ b/include/hw/s390x/s390-pci-bus.h
@@ -271,6 +271,14 @@ typedef struct S390PCIDMACount {
     QTAILQ_ENTRY(S390PCIDMACount) link;
 } S390PCIDMACount;
 
+/*
+ * This structure holds the AddressSpace for a PCI device slot. It must be
+ * allocated before PCIDevice registration completes, specifically to satisfy
+ * the get_address_space IOMMU callback invoked by do_pci_register_device().
+ * The root MemoryRegion is otherwise empty; DMA translations only become
+ * functional once the guest configures the device, at which point
+ * s390_pci_iommu_enable() registers the zPCI translation subregions beneath it.
+ */
 struct S390PCIIOMMU {
     Object parent_obj;
     AddressSpace as;
-- 
2.34.1



  parent reply	other threads:[~2026-09-11 15:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11 15:21 [PATCH v8 00/16] s390x/pci: Implement migration for emulated devices Konstantin Shkolnyy
2026-09-11 15:21 ` [PATCH v8 01/16] s390x/pci: implement IOMMU replay Konstantin Shkolnyy
2026-09-11 15:21 ` [PATCH v8 02/16] s390x/pci: Create function to contain translation status check Konstantin Shkolnyy
2026-09-11 15:21 ` [PATCH v8 03/16] s390x/pci: Move iommu_mr from S390PCIIOMMU to S390PCIBusDevice Konstantin Shkolnyy
2026-09-11 15:21 ` [PATCH v8 04/16] s390x/pci: Move dm_mr " Konstantin Shkolnyy
2026-09-11 15:21 ` [PATCH v8 05/16] s390x/pci: Move iotlb " Konstantin Shkolnyy
2026-09-11 15:21 ` [PATCH v8 06/16] s390x/pci: Remove a ptr to S390PCIBusDevice from S390PCIIOMMU Konstantin Shkolnyy
2026-09-11 15:21 ` [PATCH v8 07/16] s390x/pci: Move/rename enabled from S390PCIIOMMU to S390PCIBusDevice Konstantin Shkolnyy
2026-09-11 15:21 ` [PATCH v8 08/16] s390x/pci: Move dma_limit " Konstantin Shkolnyy
2026-09-11 15:21 ` [PATCH v8 09/16] s390x/pci: Move g_iota " Konstantin Shkolnyy
2026-09-11 15:21 ` [PATCH v8 10/16] s390x/pci: Move pba " Konstantin Shkolnyy
2026-09-11 15:21 ` [PATCH v8 11/16] s390x/pci: Move pal " Konstantin Shkolnyy
2026-09-11 15:21 ` [PATCH v8 12/16] s390x/pci: Move max_dma_limit " Konstantin Shkolnyy
2026-09-11 15:21 ` Konstantin Shkolnyy [this message]
2026-09-11 15:21 ` [PATCH v8 14/16] s390x/pci: Factor ioat sanity checks into a separate function Konstantin Shkolnyy
2026-09-11 15:21 ` [PATCH v8 15/16] s390x/pci: Implement migration for emulated devices Konstantin Shkolnyy
2026-09-11 15:21 ` [PATCH v8 16/16] s390x/pci: Create function to contain fmb_timer start Konstantin Shkolnyy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260911152137.676602-14-kshk@linux.ibm.com \
    --to=kshk@linux.ibm.com \
    --cc=alifm@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@kernel.org \
    --cc=farman@linux.ibm.com \
    --cc=iii@linux.ibm.com \
    --cc=mjrosato@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.