From: Arthur Crepin Leblond <arthur@marmottus.net>
To: netdev-bot+sashiko@kernel.org
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, arnd@arndb.de,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
krzysztof.kozlowski@oss.qualcomm.com
Subject: Re: [PATCH net-next v7 2/3] dt-bindings: net: wiznet,w5100: add link status interrupt
Date: Fri, 11 Sep 2026 17:33:25 +0200 [thread overview]
Message-ID: <20260911153325.GB9585@marmottus.net> (raw)
In-Reply-To: <178895754004.219967.902137420360139647@kernel.org>
On Wed, Sep 09, 2026 at 12:39:00PM +0000, netdev-bot+sashiko@kernel.org wrote:
>Should the item count be tied to the compatible string, for example:
>
> allOf:
> - if:
> properties:
> compatible:
> contains:
> enum:
> - wiznet,w5100
> - wiznet,w5200
> then:
> properties:
> interrupts:
> maxItems: 1
>
>The driver side of the series treats index 1 as w5500-only:
>
>drivers/net/ethernet/wiznet/w5100.c:w5100_probe() {
> ...
> priv->link_irq = ops->chip_id == W5500 ?
> fwnode_irq_get(dev_fwnode(dev), 1) : -ENODEV;
> ...
>}
>
>with w5100_get_link() returning a hardcoded 1 for the parts that have no
>PHYCFGR link-status register. So for w5100/w5200 a second interrupt in DT
>would validate but then be silently ignored, since fwnode_irq_get() is
>never called for index 1 on those chip ids.
Let me update this and have it conditional and re-request a review
from the devicetree people.
Arthur
next prev parent reply other threads:[~2026-09-11 15:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 12:35 [PATCH net-next v7 0/3] w5100: restore GPIO-based link detection Arthur Crepin Leblond
2026-09-04 12:35 ` [PATCH net-next v7 1/3] dt-bindings: net: wiznet,w5100: convert to DT schema Arthur Crepin Leblond
2026-09-05 12:36 ` sashiko-bot
2026-09-09 12:38 ` netdev-bot+sashiko
2026-09-11 15:30 ` Arthur Crepin Leblond
2026-09-04 12:35 ` [PATCH net-next v7 2/3] dt-bindings: net: wiznet,w5100: add link status interrupt Arthur Crepin Leblond
2026-09-09 12:39 ` netdev-bot+sashiko
2026-09-11 15:33 ` Arthur Crepin Leblond [this message]
2026-09-11 15:56 ` Arthur Crepin Leblond
2026-09-04 12:36 ` [PATCH net-next v7 3/3] w5100: detect carrier state using link status bit and optional interrupt Arthur Crepin Leblond
2026-09-05 12:36 ` sashiko-bot
2026-09-11 15:40 ` Arthur Crepin Leblond
2026-09-09 12:39 ` netdev-bot+sashiko
2026-09-10 11:27 ` Paolo Abeni
2026-09-10 12:28 ` Arthur Crepin Leblond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260911153325.GB9585@marmottus.net \
--to=arthur@marmottus.net \
--cc=andrew+netdev@lunn.ch \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.