From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: aalbersh@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/9] mkfs: print config file for a given mkfs configuration
Date: Fri, 11 Sep 2026 09:08:38 -0700 [thread overview]
Message-ID: <20260911160838.GJ6265@frogsfrogsfrogs> (raw)
In-Reply-To: <aqQa1cuREZufaWnT@infradead.org>
On Fri, Sep 11, 2026 at 08:14:29AM -0700, Christoph Hellwig wrote:
> On Tue, Sep 08, 2026 at 11:00:46PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Add a -c makecfg= switch to mkfs to emit a mkfs.xfs configuration file
> > documenting the user-visible filesystem featuresets of the configured
>
> featuresets sounds German :) Wouldn't english spelling split this
> into two words?
Some English speakers do, some don't. I'll make that "feature sets".
> > filesystem. This can be used to emit default configuration files as we
> > do once a year for each LTS.
> >
> > Note that geometry information is not written to the configuration file.
>
> I guess this is implied by "This file will contain only user-visible
> features" but maybe the man page could state this just as explіctly?
<nod> I'll add "Filesystem geometry information is not written to the
configuration file." to the manpage.
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thank you!
--D
next prev parent reply other threads:[~2026-09-11 16:08 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 6:00 [PATCHSET v3] xfsprogs: generate mkfs.xfs config files Darrick J. Wong
2026-09-09 6:00 ` [PATCH 1/9] mkfs: automatically upgrade autofsck earlier Darrick J. Wong
2026-09-11 15:12 ` Christoph Hellwig
2026-09-09 6:00 ` [PATCH 2/9] mkfs: print config file for a given mkfs configuration Darrick J. Wong
2026-09-11 15:14 ` Christoph Hellwig
2026-09-11 16:08 ` Darrick J. Wong [this message]
2026-09-09 6:01 ` [PATCH 3/9] xfs_db: print configuration file for mounted filesystems Darrick J. Wong
2026-09-11 15:14 ` Christoph Hellwig
2026-09-09 6:01 ` [PATCH 4/9] xfs_spaceman: " Darrick J. Wong
2026-09-11 15:15 ` Christoph Hellwig
2026-09-09 6:01 ` [PATCH 5/9] makecfg: handle metadir quota options Darrick J. Wong
2026-09-09 13:15 ` Andrey Albershteyn
2026-09-11 15:48 ` Christoph Hellwig
2026-09-11 17:58 ` Darrick J. Wong
2026-09-09 6:01 ` [PATCH 6/9] makecfg: handle old V4 options that are almost always on by default Darrick J. Wong
2026-09-09 13:15 ` Andrey Albershteyn
2026-09-11 15:49 ` Christoph Hellwig
2026-09-11 16:03 ` Darrick J. Wong
2026-09-09 6:02 ` [PATCH 7/9] makecfg: add a few more file related options Darrick J. Wong
2026-09-09 13:16 ` Andrey Albershteyn
2026-09-11 15:49 ` Christoph Hellwig
2026-09-11 16:04 ` Darrick J. Wong
2026-09-09 6:02 ` [PATCH 8/9] xfs_admin: print configuration file for mounted filesystems Darrick J. Wong
2026-09-11 15:50 ` Christoph Hellwig
2026-09-09 6:02 ` [PATCH 9/9] mkfs: allow specification of default options via configuration file Darrick J. Wong
2026-09-10 11:23 ` Andrey Albershteyn
2026-09-10 15:17 ` Darrick J. Wong
2026-09-10 15:37 ` Andrey Albershteyn
2026-09-10 16:06 ` Darrick J. Wong
2026-09-10 16:38 ` Andrey Albershteyn
2026-09-11 4:43 ` [PATCH v3.1 " Darrick J. Wong
2026-09-11 15:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260911160838.GJ6265@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=aalbersh@kernel.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.