All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Connor Kite" <connorkite@gmail.com>,
	qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
	"Stefano Garzarella" <sgarzare@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Mathieu Poirier" <mathieu.poirier@linaro.org>,
	"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
	"Raphael Norwitz" <rnorwitz@nvidia.com>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Hanna Reitz" <hreitz@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Fam Zheng" <fam@euphon.net>,
	"Milan Zamazal" <mzamazal@redhat.com>,
	"Akihiko Odaki" <odaki@rsg.ci.i.u-tokyo.ac.jp>,
	"Dmitry Osipenko" <dmitry.osipenko@collabora.com>,
	qemu-block@nongnu.org, virtio-fs@lists.linux.dev,
	"Gonglei (Arei)" <arei.gonglei@huawei.com>,
	"zhenwei pi" <zhenwei.pi@linux.dev>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Eric Blake" <eblake@redhat.com>,
	"Jason Wang" <jasowangio@gmail.com>,
	"Peter Xu" <peterx@redhat.com>,
	"Eugenio Pérez" <eperezma@redhat.com>,
	"Alyssa Ross" <hi@alyssa.is>,
	"Demi Marie Obenour" <demiobenour@gmail.com>
Subject: Re: [PATCH RFC v2 13/13] net/vhost-user: add memory isolation
Date: Fri, 11 Sep 2026 12:25:47 -0400	[thread overview]
Message-ID: <20260911162547.GA157639@fedora> (raw)
In-Reply-To: <87lda010j1.fsf@pond.sub.org>

[-- Attachment #1: Type: text/plain, Size: 2002 bytes --]

On Fri, Aug 21, 2026 at 07:54:26AM +0200, Markus Armbruster wrote:
> Connor Kite <connorkite@gmail.com> writes:
> 
> > On Thu, Aug 20, 2026 at 2:02 AM Markus Armbruster <armbru@redhat.com> wrote:
> >>
> >>
> >> Any guidance on when to enable it?
> >>
> > ...
> >
> >> Likewise.
> >>
> >
> > In both cases, you would enable this for added security.  There's
> > obviously a performance hit, but it prevents a potentially misbehaving
> > vhost-user backend from reading or modifying undesired portions of
> > guest memory, since data transfer occurs wholly via bounce buffers.
> > This may be more useful in the generic netdev vhost user case than it
> > is with the passt version, but the goal is for the mode to be
> > accessible for any vhost-user device.
> 
> Work this into the commit message, please.
> 
> > Do you think guidance is needed here in net.json?  I was thinking
> > that, if isolation-mode gets to a point of being merged, then
> > information like this would make sense somewhere in the online
> > documentation, but I'm happy to add something here as well.  I was
> > just trying to be similarly short and to-the-point as the other option
> > descriptions for these structs.
> 
> I think it needs to be somewhere in the user documentation.  We have so
> many configuration options, and so little guidance on what to do with
> them.
> 
> The doc comments in the QAPI schema are reference documentation (they go
> into the "QEMU QMP Reference Manual").  Reference documentation should
> be concise and to the point.  When you have more useful things to say
> than fit there, you need to find nother place, and maybe link to it from
> the reference docs.
> 
> I suggest to try adding brief guidance to the doc comment, and then we
> see how we feel about it.
> 

Here is the vhost-user documentation:
docs/system/devices/virtio/vhost-user.rst

You could add a section to this document explaining the memory isolation
feature.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2026-09-11 16:26 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18  5:12 [PATCH RFC v2 00/13] vhost-user: isolated memory Connor Kite
2026-08-18  5:12 ` [PATCH RFC v2 01/13] vhost-user: Consolidate chardev property definitions Connor Kite
2026-08-18  5:12 ` [PATCH RFC v2 02/13] util/iova-tree: g_tree_foreach wrapper Connor Kite
2026-08-18  5:12 ` [PATCH RFC v2 03/13] hw/virtio: iova_tree_foreach wrapper Connor Kite
2026-08-18  5:12 ` [PATCH RFC v2 04/13] hw/virtio/vhost-shadow-virtqueue: used callback Connor Kite
2026-08-19  6:23   ` Akihiko Odaki
2026-08-20  1:06     ` Connor Kite
2026-08-20  5:15       ` Akihiko Odaki
2026-08-20 23:42         ` Connor Kite
2026-08-21  7:21           ` Akihiko Odaki
2026-08-18  5:12 ` [PATCH RFC v2 05/13] hw/virtio/vhost-shadow-virtqueue: specified vring placement Connor Kite
2026-08-25 14:26   ` Hanna Czenczek
2026-08-28 12:15   ` Eugenio Perez Martin
2026-09-01 19:09     ` Connor Kite
2026-09-02  8:24       ` Eugenio Perez Martin
2026-08-18  5:12 ` [PATCH RFC v2 06/13] vhost-user: add memory_isolation to VhostUserState Connor Kite
2026-08-18  5:12 ` [PATCH RFC v2 07/13] hw/virtio/vhost-user: create isolation region Connor Kite
2026-08-19  7:36   ` Akihiko Odaki
2026-08-21  2:57     ` Connor Kite
2026-08-25 14:34   ` Hanna Czenczek
2026-08-18  5:12 ` [PATCH RFC v2 08/13] hw/virtio/vhost-user: send isolation regions to device Connor Kite
2026-08-18 11:31   ` Akihiko Odaki
2026-08-25 14:36   ` Hanna Czenczek
2026-08-28 12:29   ` Eugenio Perez Martin
2026-08-18  5:12 ` [PATCH RFC v2 09/13] hw/virtio/vhost-user: add shadow virtqueues and eventfd intercepts Connor Kite
2026-08-18 12:34   ` Akihiko Odaki
2026-08-20 20:38     ` Connor Kite
2026-08-25 14:48   ` Hanna Czenczek
2026-08-18  5:12 ` [PATCH RFC v2 10/13] hw/virtio/vhost-user: handle data movement with shadow vqs Connor Kite
2026-08-19  7:37   ` Akihiko Odaki
2026-08-28 12:24   ` Eugenio Perez Martin
2026-08-18  5:12 ` [PATCH RFC v2 11/13] vhost-user: Add memory-isolation qdev property to vhost-user devices Connor Kite
2026-08-18  5:12 ` [PATCH RFC v2 12/13] backends/cryptodev-vhost-user: add memory isolation bool Connor Kite
2026-08-20  9:00   ` Markus Armbruster
2026-08-18  5:12 ` [PATCH RFC v2 13/13] net/vhost-user: add memory isolation Connor Kite
2026-08-19  7:37   ` Akihiko Odaki
2026-08-20  1:22     ` Connor Kite
2026-08-20  9:02   ` Markus Armbruster
2026-08-21  0:39     ` Connor Kite
2026-08-21  5:54       ` Markus Armbruster
2026-09-11 16:25         ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260911162547.GA157639@fedora \
    --to=stefanha@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=arei.gonglei@huawei.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=connorkite@gmail.com \
    --cc=demiobenour@gmail.com \
    --cc=dmitry.osipenko@collabora.com \
    --cc=eblake@redhat.com \
    --cc=eperezma@redhat.com \
    --cc=fam@euphon.net \
    --cc=hi@alyssa.is \
    --cc=hreitz@redhat.com \
    --cc=jasowangio@gmail.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=manos.pitsidianakis@linaro.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=mst@redhat.com \
    --cc=mzamazal@redhat.com \
    --cc=odaki@rsg.ci.i.u-tokyo.ac.jp \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rnorwitz@nvidia.com \
    --cc=sgarzare@redhat.com \
    --cc=viresh.kumar@linaro.org \
    --cc=virtio-fs@lists.linux.dev \
    --cc=zhenwei.pi@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.