From: Jakub Kicinski <kuba@kernel.org>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
Cc: netdev@vger.kernel.org, Donald Hunter <donald.hunter@gmail.com>,
Danielle Ratson <danieller@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org,
Daniel Borkmann <daniel@iogearbox.net>,
Nikolay Aleksandrov <razor@blackwall.org>
Subject: Re: [PATCH net-next 04/10] netlink: specs: rt-link: fix netkit-policy names
Date: Fri, 11 Sep 2026 17:36:48 -0700 [thread overview]
Message-ID: <20260911173649.49474ab5@kernel.org> (raw)
In-Reply-To: <20260911152629.490a47c7@kernel.org>
On Fri, 11 Sep 2026 15:26:29 -0700 Jakub Kicinski wrote:
> On Fri, 11 Sep 2026 21:41:30 +0000 Asbjørn Sloth Tønnesen wrote:
> > Correct the names of these `enum netkit_action` constants:
> >
> > - NETKIT_PASS is 0, so "pass", not "forward".
> > - NETKIT_DROP is 2, so "drop", not "blackhole".
> >
> > Note, the other enum members are not used in netlink, and
> > are not allowed by netkit_check_policy().
>
> Looks right tho may be intentional, so the other option would be to add
> #define aliases for the spec names.
Ah, looks like some of the selftests use "forward" by name
You'll have to fix those
--
pw-bot: cr
next prev parent reply other threads:[~2026-09-12 0:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 21:41 [PATCH net-next 00/10] netlink: specs: enum alignment fixes Asbjørn Sloth Tønnesen
2026-09-11 21:41 ` [PATCH net-next 01/10] netlink: specs: rt-link: re-align IPv4 devconf Asbjørn Sloth Tønnesen
2026-09-11 21:41 ` [PATCH net-next 02/10] netlink: specs: rt-link: re-align ifla-inet6-stats Asbjørn Sloth Tønnesen
2026-09-11 21:41 ` [PATCH net-next 03/10] netlink: specs: rt-link: fix ifinfo-flags names Asbjørn Sloth Tønnesen
2026-09-11 21:41 ` [PATCH net-next 04/10] netlink: specs: rt-link: fix netkit-policy names Asbjørn Sloth Tønnesen
2026-09-11 22:26 ` Jakub Kicinski
2026-09-12 0:36 ` Jakub Kicinski [this message]
2026-09-11 21:41 ` [PATCH net-next 05/10] netlink: specs: devlink: fix resource-scope type Asbjørn Sloth Tønnesen
2026-09-11 21:41 ` [PATCH net-next 06/10] netlink: specs: ethtool: re-align c33-pse-ext-state Asbjørn Sloth Tønnesen
2026-09-11 21:41 ` [PATCH net-next 07/10] netlink: specs: ethtool: re-align module-fw-flash-status Asbjørn Sloth Tønnesen
2026-09-11 21:41 ` [PATCH net-next 08/10] netlink: specs: nl80211: fix naming of enum members Asbjørn Sloth Tønnesen
2026-09-11 21:41 ` [PATCH net-next 09/10] netlink: specs: tc: fix typo in cls-flags Asbjørn Sloth Tønnesen
2026-09-12 8:25 ` Toke Høiland-Jørgensen
2026-09-11 21:41 ` [PATCH net-next 10/10] netlink: specs: fix incorrect name-prefixes Asbjørn Sloth Tønnesen
2026-09-11 22:29 ` [PATCH net-next 00/10] netlink: specs: enum alignment fixes Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260911173649.49474ab5@kernel.org \
--to=kuba@kernel.org \
--cc=ast@fiberby.net \
--cc=daniel@iogearbox.net \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.