From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7ED5E4AC163 for ; Fri, 11 Sep 2026 17:52:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789149147; cv=none; b=fUbZxSZq3pVkNFnLZMJm3JLaDLbEb1cAawzjYa8MevkQu7hrORwFt3x5kT8cUDGvQU7QRrvbNWJc4bH5ajTlcCyPkV9BOL6iEM7x4SuaYLaBWwbE7dhz9agrQTa9AKgXeW/ajDqRG5zKVgqsM/cJMJ2DLUka+ShAEM1XrsNpxoY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789149147; c=relaxed/simple; bh=alLddwqKdsvyKlyQDlXZ0V6orFF7Xfz8ZIQ49PozOfc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g29gf5ioJSVA7wrEdmbyPWhyWHTfuNA5d9+9HypuYS+YoWXDPF9DecFDztQ1gKDl7ySk52aAgkcxprCtjU14IIT2JaLq00X59BWUUd4fO8W6YgrN69effDWZHCAcutUUEA0DK8oD0R1FaIqPko1Ev70ZnPnjIxgarKwahyAEWrg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GS6R1cwz; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GS6R1cwz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C4381F00898; Fri, 11 Sep 2026 17:52:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789149145; bh=j5Mz4TDXlDf416xAAxWMnZIlooWCGqv6stA4FjSXK+c=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=GS6R1cwz5YufUMNsZU5ETcjvUPKLurbkhxr9jG23ZwdNkGTrATFqCn6wUQSptp4nI 8hdJ8CZUO1t9qczhVHemzAbMlhRDksQqDOOCypoi+iDqcWRz7XNypUkBfUbX7OGZP3 NqTMSbXoFCEuDDEQzYoC+4OfRyzJCiES69Si0Wsn15GKfebwAJ3e/eyd3Swhae8LP6 gvSHan3j17BZ2nGdAAAvYfUzhYG+BBj4UFVHjapRC2ROHNhzM82VxwM15XgXGTrLKg upuVBZP/a+uYaALCNtW0pMJpjqWXhdQlaN3k9ilTj3IKjXaA9klFdqnR0xsj+ShTft /fliAojTGfGhg== From: Sasha Levin To: stable@vger.kernel.org Cc: Nilesh Javali , Sashiko , "Martin K. Petersen (Oracle)" , Sasha Levin Subject: [PATCH 5.15.y] scsi: qla2xxx: Quiesce response IRQ before freeing request queue Date: Fri, 11 Sep 2026 13:52:23 -0400 Message-ID: <20260911175223.1277131-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026090925-anointer-haggler-c959@gregkh> References: <2026090925-anointer-haggler-c959@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Nilesh Javali [ Upstream commit 505753ec2594c6af09a601f0dd60be7d840c1d2d ] qla2xxx_delete_qpair() deletes the request queue before the response queue. qla25xx_delete_req_que() frees the request queue memory (kfree(req) in qla25xx_free_req_que()), but the response-queue MSI-X is only released later, in qla25xx_free_rsp_que(). In that window the response interrupt can still fire, qla2xxx_msix_rsp_q() queues qpair->q_work, and qla_do_work() -> qla24xx_process_response_queue() dereferences the now-freed rsp->req (LOGINOUT/CT/ELS entries and the status path), a use-after-free. The cancel_work_sync() added for the qpair teardown lives in the response free path, which runs after the request queue is already freed, so it does not protect rsp->req. Release the response-queue interrupt and flush qpair->q_work before deleting the request queue, so no late completion can reach the freed request queue. Clearing have_irq makes the subsequent qla25xx_free_rsp_que() skip its free_irq(), and the firmware queue-delete order (request then response) is preserved; the request-delete mailbox completes on the default vector and is unaffected by dropping the qpair response interrupt early. Fixes: d74595278f4a ("scsi: qla2xxx: Add multiple queue pair functionality.") Cc: stable@vger.kernel.org Reported-by: Sashiko Signed-off-by: Nilesh Javali Link: https://patch.msgid.link/20260730155838.2119230-18-njavali@marvell.com Signed-off-by: Martin K. Petersen (Oracle) [ adjusted context due to missing qla_free_buf_pool() call ] Signed-off-by: Sasha Levin --- drivers/scsi/qla2xxx/qla_init.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 177b71fae2f89..3804024793c70 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -9904,9 +9904,26 @@ int qla2xxx_delete_qpair(struct scsi_qla_host *vha, struct qla_qpair *qpair) { int ret = QLA_FUNCTION_FAILED; struct qla_hw_data *ha = qpair->hw; + struct rsp_que *rsp = qpair->rsp; qpair->delete_in_progress = 1; + /* + * The response-queue interrupt schedules qla_do_work(), which + * dereferences qpair->rsp->req. Release the interrupt and flush + * any pending work before the request queue is freed below so a + * late completion cannot touch the freed request queue. The + * firmware queue-delete order (request then response) is kept. + */ + if (rsp && rsp->msix && rsp->msix->have_irq) { + free_irq(rsp->msix->vector, rsp->msix->handle); + rsp->msix->have_irq = 0; + rsp->msix->in_use = 0; + rsp->msix->handle = NULL; + } + if (rsp && ha->wq) + cancel_work_sync(&qpair->q_work); + ret = qla25xx_delete_req_que(vha, qpair->req); if (ret != QLA_SUCCESS) goto fail; -- 2.53.0