From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 617D61A6813 for ; Fri, 11 Sep 2026 18:03:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789149810; cv=none; b=J9jW22dZlnhcdRrYJRhJWFatd4t6VDBn5TaS4ofZeZ/UxPUvGK9F4VFgUimXFF2vVdxie6eSg4cvkEAGVIerxb5mJcekArNOVMVzeSA8JCMKkPwjXukx/X7T+T15q4J1asaTlPLMMzVtKHmMy1fdT57/q/+znOvHolVHmRp0r0s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789149810; c=relaxed/simple; bh=m5flHCluNHR2YWS6bDNK+Vb28wmfEuH5NOqYvUGiUII=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Gq7UPKU5X4w+vptVPWcHPmNZFBc3Pt8WzGuaq2QuEILhUzHt0wCpKnnCKReCdLucxU3+aliczEMz6QqzQdBb1hT3e/+De5og/p7jJnZRSbDU58tUmI8SNeoqnHM96JU3x+lQeEGSHLAjJUltuw1HKzjWQa0J/QJdguT374+6umM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RmCTIHOy; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RmCTIHOy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 617A01F000FF; Fri, 11 Sep 2026 18:03:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789149809; bh=xcpWbFQwoE9D9EJpLp0rm/6xX2gMbHCcs1y7MslvqAE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=RmCTIHOylPeyLc1or9cn1tadNNTE3Tbx9X20NnuBvVZxIO0A+n7S32BTZe6/hfoMg K6P4U/gSq51jzB7H0AOSKQamDg3BAYrus0ijEI4r2NZK1JJGGa6n8h936otIklsNmS zecLepSpkLDDaO/weLFyTx9EedOoI1UpRzAT8df7wtgZsf84cAVQLH8QzXFYMl5W8W f7LgBSNKF0GTrSPq2kAVVlO8XkIo0D6m7Vj3ra3vQyEEHXHTcZjlll2Lit+lySsgG3 SSJkQTH5hm6RQCB6WhE6JWRNCxlpiYx1tVM0XgVka/Va1vb6vhdVSw/sBaDdT6oVvv lByvTM0Pjpnsw== From: Sasha Levin To: stable@vger.kernel.org Cc: Nilesh Javali , Sashiko , "Martin K. Petersen (Oracle)" , Sasha Levin Subject: [PATCH 5.10.y] scsi: qla2xxx: Skip vport under deletion in report ID acquisition Date: Fri, 11 Sep 2026 14:03:26 -0400 Message-ID: <20260911180326.1292667-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026090952-claim-flint-7d6d@gregkh> References: <2026090952-claim-flint-7d6d@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Nilesh Javali [ Upstream commit 23582731afa35031c94fadb71a4f3b4afd094649 ] qla24xx_report_id_acquisition() format-1 handling walks ha->vp_list under vport_slock, takes a vref_count on the matching vport and calls qla_update_host_map() to register its port id. A vport teardown via qla24xx_vport_delete() sets VPORT_DELETE, then qla24xx_disable_vp() removes the vport from the host_map btree and zeroes vha->d_id (RESET_AL_PA). The vport is only unlinked from vp_list later, in qla24xx_deallocate_vp_id(), which clears vp_map[idx] (RESET_VP_IDX) but does not touch host_map. In the window in between, report ID acquisition can still find the vport on vp_list and call qla_update_host_map(); with d_id already zeroed it takes the btree_insert32() path and re-inserts the dying vport into host_map. Nothing cleans that entry afterwards, so once scsi_host_put() frees the vha a later host_map lookup dereferences freed memory. Skip a vport that has VPORT_DELETE set before taking the reference, so it is neither re-registered nor scheduled for DPC re-registration. This mirrors the existing guard in qla2x00_alert_all_vps(). Fixes: 41dc529a4602 ("qla2xxx: Improve RSCN handling in driver") Cc: stable@vger.kernel.org Reported-by: Sashiko Signed-off-by: Nilesh Javali Link: https://patch.msgid.link/20260730155838.2119230-22-njavali@marvell.com Signed-off-by: Martin K. Petersen (Oracle) [ Adjusted context to use rptid_entry->vp_idx instead of the missing local vp_idx variable. ] Signed-off-by: Sasha Levin --- drivers/scsi/qla2xxx/qla_mbx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index aa6a68e235c9d..dc83f54acecf0 100644 --- a/drivers/scsi/qla2xxx/qla_mbx.c +++ b/drivers/scsi/qla2xxx/qla_mbx.c @@ -4083,6 +4083,8 @@ qla24xx_report_id_acquisition(scsi_qla_host_t *vha, spin_lock_irqsave(&ha->vport_slock, flags); list_for_each_entry(vp, &ha->vp_list, list) { if (rptid_entry->vp_idx == vp->vp_idx) { + if (test_bit(VPORT_DELETE, &vp->dpc_flags)) + break; found = 1; break; } -- 2.53.0