Re: [PATCH v5 08/10] vfio: selftests: Add mlx5 driver - HW init and command interface

[Jason Gunthorpe <jgg@nvidia.com>]

On Thu, Sep 10, 2026 at 11:58:31PM +0000, sashiko-bot@kernel.org wrote:
> > +static void mlx5st_query_fl_caps(struct mlx5st_device *dev)
> > +{
> > +	u32 out[MLX5_ST_SZ_DW(query_hca_cap_out)] = {};
> > +	u32 in[MLX5_ST_SZ_DW(query_hca_cap_in)] = {};
> > +	bool fl_roce_en, fl_roce_dis;
> > +
> > +	/* Query RoCE capabilities */
> > +	MLX5_SET(query_hca_cap_in, in, opcode, MLX5_CMD_OP_QUERY_HCA_CAP);
> > +	MLX5_SET(query_hca_cap_in, in, op_mod,
> > +		 MLX5_SET_HCA_CAP_OP_MOD_ROCE | HCA_CAP_OPMOD_GET_CUR);
> 
> [Severity: Medium]
> Does the MLX5_SET_HCA_CAP_OP_MOD_ROCE constant need to be shifted left by 1?
> 
> If the constant is defined as 0x4, passing it unshifted results in an op_mod
> of 5. This causes the hardware to interpret bits 15:1 as capability type 2
> (MLX5_CAP_ODP) instead of RoCE, causing the driver to query the wrong
> capabilities.

This looks correct, I will fix it and repost

For the others, the driver does not validate fw information (aka hardening)

Jason