From: Jennifer Guo <guojy.bj@gmail.com>
To: linux-staging@lists.linux.dev
Cc: gregkh@linuxfoundation.org, guojy.bj@gmail.com
Subject: [PATCH 1/2] staging: rtl8723bs: delete empty comment lines in hal/ header files
Date: Fri, 11 Sep 2026 12:33:34 -0700 [thread overview]
Message-ID: <20260911193335.6908-2-guojy.bj@gmail.com> (raw)
In-Reply-To: <20260911193335.6908-1-guojy.bj@gmail.com>
Delete all empty comment lines in hal/ header files. Add back a newline
if needed for spacing, while avoiding multiple blank lines.
Signed-off-by: Jennifer Guo <guojy.bj@gmail.com>
---
drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 17 +-------
.../staging/rtl8723bs/hal/HalBtc8723b1Ant.h | 2 -
.../staging/rtl8723bs/hal/HalBtc8723b2Ant.h | 2 -
drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h | 2 +-
.../staging/rtl8723bs/hal/HalPhyRf_8723B.h | 6 +--
drivers/staging/rtl8723bs/hal/odm.h | 42 ++-----------------
drivers/staging/rtl8723bs/hal/odm_HWConfig.h | 2 -
7 files changed, 7 insertions(+), 66 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/Hal8723BReg.h b/drivers/staging/rtl8723bs/hal/Hal8723BReg.h
index 0b327a70aa15..8142d9cf9ae5 100644
--- a/drivers/staging/rtl8723bs/hal/Hal8723BReg.h
+++ b/drivers/staging/rtl8723bs/hal/Hal8723BReg.h
@@ -19,27 +19,16 @@
#ifndef __INC_HAL8723BREG_H
#define __INC_HAL8723BREG_H
-/* */
-/* */
/* 0x0100h ~ 0x01FFh MACTOP General Configuration */
-/* */
-/* */
#define REG_C2HEVT_CMD_SEQ_88XX 0x01A1
#define REG_C2HEVT_CMD_LEN_88XX 0x01AE
-/* */
-/* */
/* 0x0200h ~ 0x027Fh TXDMA Configuration */
-/* */
-/* */
#define REG_DWBCN1_CTRL_8723B 0x0228
/* spec version 11 */
-/* */
-/* */
+
/* 0x0400h ~ 0x047Fh Protocol Configuration */
-/* */
-/* */
#define REG_FWHW_TXQ_CTRL_8723B 0x0420
#define REG_ARFR0_8723B 0x0444
#define REG_ARFR1_8723B 0x044C
@@ -50,11 +39,7 @@
#define REG_DATA_SC_8723B 0x0483
#define REG_MAX_AGGR_NUM_8723B 0x04CA
-/* */
-/* */
/* 0x0500h ~ 0x05FFh EDCA Configuration */
-/* */
-/* */
#define REG_PIFS_8723B 0x0512
/* 0x0600h ~ 0x07FFh WMAC Configuration */
diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h
index 7a12d92da0a9..b3e6c5f12e8b 100644
--- a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h
+++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h
@@ -164,9 +164,7 @@ struct coex_sta_8723b_1ant {
bool bForceLpsOn;
};
-/* */
/* The following is interface which will notify coex module. */
-/* */
void EXhalbtc8723b1ant_PowerOnSetting(struct btc_coexist *pBtCoexist);
void EXhalbtc8723b1ant_InitHwConfig(struct btc_coexist *pBtCoexist, bool bWifiOnly);
void EXhalbtc8723b1ant_InitCoexDm(struct btc_coexist *pBtCoexist);
diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.h b/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.h
index ebc47f65e8d2..21bb90479e9c 100644
--- a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.h
+++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.h
@@ -126,9 +126,7 @@ struct coex_sta_8723b_2ant {
u8 btInfoExt;
};
-/* */
/* The following is interface which will notify coex module. */
-/* */
void EXhalbtc8723b2ant_PowerOnSetting(struct btc_coexist *pBtCoexist);
void EXhalbtc8723b2ant_InitHwConfig(struct btc_coexist *pBtCoexist, bool bWifiOnly);
void EXhalbtc8723b2ant_InitCoexDm(struct btc_coexist *pBtCoexist);
diff --git a/drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h b/drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h
index 36b0f429dd4c..761763471a68 100644
--- a/drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h
+++ b/drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h
@@ -194,7 +194,7 @@ enum {
BTC_SET_ACT_CTRL_BT_INFO,
BTC_SET_ACT_CTRL_BT_COEX,
BTC_SET_ACT_CTRL_8723B_ANT,
- /* */
+
BTC_SET_MAX
};
diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.h b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.h
index 14b328378b8b..9795bbcf0b35 100644
--- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.h
+++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.h
@@ -13,7 +13,7 @@
#define IQK_DEFERRED_TIME_8723B 4
#define index_mapping_NUM_8723B 15
#define AVG_THERMAL_NUM_8723B 4
-#define RF_T_METER_8723B 0x42 /* */
+#define RF_T_METER_8723B 0x42
void ConfigureTxpowerTrack_8723B(struct txpwrtrack_cfg *pConfig);
@@ -35,14 +35,10 @@ void PHY_IQCalibrate_8723B(
void ODM_SetIQCbyRFpath(struct dm_odm_t *pDM_Odm, u32 RFpath);
-/* */
/* LC calibrate */
-/* */
void PHY_LCCalibrate_8723B(struct dm_odm_t *pDM_Odm);
-/* */
/* AP calibrate */
-/* */
void PHY_DigitalPredistortion_8723B(struct adapter *padapter);
void _PHY_SaveADDARegisters_8723B(
diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h
index b123df98fa22..3532f0d79363 100644
--- a/drivers/staging/rtl8723bs/hal/odm.h
+++ b/drivers/staging/rtl8723bs/hal/odm.h
@@ -197,9 +197,8 @@ struct odm_rate_adaptive {
#define DM_Type_ByFW 0
#define DM_Type_ByDriver 1
-/* */
/* Declare for common info */
-/* */
+
#define MAX_PATH_NUM_8723B 1
#define IQK_THRESHOLD 8
@@ -262,9 +261,7 @@ struct odm_mac_status_info {
u8 test;
};
-/* */
/* 2011/10/20 MH Define Common info enum for all team. */
-/* */
enum odm_cmninfo_e {
/* Fixed value: */
@@ -350,9 +347,7 @@ enum odm_cmninfo_e {
/* 2011/10/20 MH Define ODM support ability. ODM_CMNINFO_ABILITY */
enum { /* _ODM_Support_Ability_Definition */
- /* */
/* BB ODM section BIT 0-15 */
- /* */
ODM_BB_DIG = BIT(0),
ODM_BB_RA_MASK = BIT(1),
ODM_BB_DYNAMIC_TXPWR = BIT(2),
@@ -410,9 +405,7 @@ enum { /* tag_ODM_Fab_Version_Definition */
ODM_UMC = 1,
};
-/* */
/* For example 1T2R (A+AB = BIT0|BIT4|BIT5) */
-/* */
enum { /* tag_ODM_RF_Type_Definition */
ODM_1T1R = 0,
ODM_1T2R = 1,
@@ -424,9 +417,7 @@ enum { /* tag_ODM_RF_Type_Definition */
ODM_4T4R = 7,
};
-/* */
/* ODM Dynamic common info value definition */
-/* */
/* ODM_CMNINFO_WM_MODE */
enum { /* tag_Wireless_Mode_Definition */
@@ -531,8 +522,6 @@ struct odm_rf_cal_t { /* ODM_RF_Calibration_Structure */
u8 DeltaSwingTableIdx_2GA_P_8188E[DELTA_SWINGIDX_SIZE];
u8 DeltaSwingTableIdx_2GA_N_8188E[DELTA_SWINGIDX_SIZE];
- /* */
-
/* for IQK */
u32 RegC04;
u32 Reg874;
@@ -567,10 +556,8 @@ struct odm_rf_cal_t { /* ODM_RF_Calibration_Structure */
u32 TxLOK[2];
};
-/* */
-/* ODM Dynamic common info value definition */
-/* */
+/* ODM Dynamic common info value definition */
struct fat_t { /* _FAST_ANTENNA_TRAINNING_ */
u8 Bssid[6];
u8 antsel_rx_keep_0;
@@ -633,9 +620,7 @@ enum phy_reg_pg_type { /* _BASEBAND_CONFIG_PHY_REG_PG_VALUE_TYPE */
PHY_REG_PG_EXACT_VALUE = 1
};
-/* */
/* Antenna detection information from single tone mechanism, added by Roger, 2012.11.27. */
-/* */
struct ant_detected_info {
bool bAntDetected;
u32 dBForAntA;
@@ -643,9 +628,7 @@ struct ant_detected_info {
u32 dBForAntO;
};
-/* */
/* 2011/09/22 MH Copy from SD4 defined structure. We use to support PHY DM integration. */
-/* */
struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */
struct adapter *Adapter; /* For CE/NIC team */
/* WHen you use Adapter or priv pointer, you must make sure the pointer is ready. */
@@ -668,9 +651,7 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */
/* 1 COMMON INFORMATION */
- /* */
/* Init Value */
- /* */
/* HOOK BEFORE REG INIT----------- */
/* ODM Platform info AP/ADSL/CE/MP = 1/2/3/4 */
u8 SupportPlatform;
@@ -708,9 +689,8 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */
u8 AntDivType;
/* HOOK BEFORE REG INIT----------- */
- /* */
/* Dynamic Value */
- /* */
+
/* POINTER REFERENCE----------- */
u8 u8_temp;
@@ -830,16 +810,13 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */
u8 Adaptivity_IGI_upper;
u8 NHM_cnt_0;
- /* */
/* 2 Define STA info. */
/* _ODM_STA_INFO */
/* 2012/01/12 MH For MP, we need to reduce one array pointer for default port.?? */
PSTA_INFO_T pODM_StaInfo[ODM_ASSOCIATE_ENTRY_NUM];
- /* */
/* 2012/02/14 MH Add to share 88E ra with other SW team. */
/* We need to colelct all support abilit to a proper area. */
- /* */
bool RaSupport88E;
/* Define ........... */
@@ -850,9 +827,7 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */
/* Latest packet phy info (ODM write) */
struct odm_mac_status_info *pMacInfo;
- /* */
/* ODM Structure */
- /* */
struct fat_t DM_FatTable;
struct dig_t DM_DigTable;
struct ps_t DM_PSTable;
@@ -869,9 +844,7 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */
u32 WMMEDCA_BE;
struct pathdiv_t DM_PathDiv;
/* Copy from SD4 structure */
- /* */
/* ================================================== */
- /* */
/* common */
@@ -899,9 +872,7 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */
struct odm_rf_cal_t RFCalibrateInfo;
- /* */
/* TX power tracking */
- /* */
u8 BbSwingIdxOfdm[MAX_RF_PATH];
u8 BbSwingIdxOfdmCurrent;
u8 BbSwingIdxOfdmBase[MAX_RF_PATH];
@@ -924,9 +895,8 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */
bool Modify_TxAGC_Flag_PathA_CCK;
s8 KfreeOffset[MAX_RF_PATH];
- /* */
+
/* ODM system resource. */
- /* */
/* ODM relative time. */
struct timer_list PathDivSwitchTimer;
@@ -1018,16 +988,12 @@ enum { /* tag_RF_Type_Definition */
/* Maximal number of antenna detection mechanism needs to perform, added by Roger, 2011.12.28. */
#define MAX_ANTENNA_DETECTION_CNT 10
-/* */
/* Extern Global Variables. */
-/* */
extern u32 OFDMSwingTable_New[OFDM_TABLE_SIZE];
extern u8 CCKSwingTable_Ch1_Ch13_New[CCK_TABLE_SIZE][8];
extern u8 CCKSwingTable_Ch14_New[CCK_TABLE_SIZE][8];
-/* */
/* check Sta pointer valid or not */
-/* */
#define IS_STA_VALID(pSta) (pSta)
/* 20100514 Joseph: Add definition for antenna switching test after link. */
/* This indicates two different the steps. */
diff --git a/drivers/staging/rtl8723bs/hal/odm_HWConfig.h b/drivers/staging/rtl8723bs/hal/odm_HWConfig.h
index 615145812ed2..ca3380328a72 100644
--- a/drivers/staging/rtl8723bs/hal/odm_HWConfig.h
+++ b/drivers/staging/rtl8723bs/hal/odm_HWConfig.h
@@ -8,9 +8,7 @@
#ifndef __HALHWOUTSRC_H__
#define __HALHWOUTSRC_H__
-/* */
/* structure and define */
-/* */
struct phy_rx_agc_info_t {
#if (ODM_ENDIAN_TYPE == ODM_ENDIAN_LITTLE)
--
2.34.1
next prev parent reply other threads:[~2026-09-11 19:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 19:33 [PATCH 0/2] staging: rtl8723bs: delete more empty comment lines Jennifer Guo
2026-09-11 19:33 ` Jennifer Guo [this message]
2026-09-11 19:33 ` [PATCH 2/2] staging: rtl8723bs: delete empty comment lines in source files Jennifer Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260911193335.6908-2-guojy.bj@gmail.com \
--to=guojy.bj@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.