From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F389598BEF for ; Fri, 11 Sep 2026 20:12:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789157528; cv=none; b=cNl0bY4kcAb/TYPwIxhxl08GDjjHhXI20ojVfdx6fRCaFuAU0yI0DIKi6bQYZCgvLhUs1CxzsdhoSDn7NMwpKnUPOEpMe5550jQTcA5AqqeMYOSbrwUpk8wMGCTwOYmmj8tnsDxqAFYBRYGL/tBZ0/8G9gZu0Rn3cEhlPOyTd7o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789157528; c=relaxed/simple; bh=TX+/5Wo4wtf6WTAbSoVWd2ZJerpeXwwrH+ylaorbFJk=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WjzJ7vJlCURB4V+Gb4McgfFaX6ELS5t5dYXcLsci2+q2iYfpe+yuKm59STgFpvLVP2OCcWrrBqq555smYLSwFATh2q8PCtDmdiDAA9K85I8IY4dlrLwK1r81lgDV5qJz8FtQdTuIha2LlgJZ7D1OchmE3yDUQPCmZbkcbek/nUw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=X2xfMXLI; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="X2xfMXLI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1789157525; x=1820693525; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=TX+/5Wo4wtf6WTAbSoVWd2ZJerpeXwwrH+ylaorbFJk=; b=X2xfMXLIRppXwUcEN1KsqjMREG65vyPs7HJ7woZ5oTTI/DyJwVijJ5zK TBvu157BqnwK1P/4Yo3bOG5LohJ4+zDH8Pu3Najv5Tcro6jfSYmp4CDdM Eg/k/6ifVtMFA56a8DaM+TXtSJNsZW7l++vxSwUfEBwvaKxKdmneNwhpW brLIyIvxO+rOw8achL8dSOOIq8krS8cbFBKCT/9iDiEvD/V2h4FuFI105 vMieBm7XORlSMBssDd2HOEPPEZZT9SNn/Sbt5tzxrRR3M9W9Cw6D039xF ShVxXcnxcATfw8Snp5DUMplRBeqW/RoibjTeH+iKtVeqsssTgoIjuaIU8 Q==; X-CSE-ConnectionGUID: XXRY1wYFSqyg20i87Hd6EQ== X-CSE-MsgGUID: 3s0zlOSDSM6yI6Pi4oFU1w== X-IronPort-AV: E=McAfee;i="6800,10657,11902"; a="115162377" X-IronPort-AV: E=Sophos;i="6.27,97,1787036400"; d="scan'208";a="115162377" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2026 13:11:59 -0700 X-CSE-ConnectionGUID: AMlhmTy0SkOBFeW8/k7Mlg== X-CSE-MsgGUID: wRu8i1abTt6TJBvT2SjE5Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,97,1787036400"; d="scan'208";a="277272081" Received: from mjruhl-vm.amr.corp.intel.com ([10.11.186.166]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2026 13:11:59 -0700 From: "Michael J. Ruhl" To: platform-driver-x86@vger.kernel.org, intel-xe@lists.freedesktop.org, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, matthew.brost@intel.com, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com, airlied@gmail.com, simona@ffwll.ch, david.e.box@linux.intel.com, anoop.c.vijay@intel.com, badal.nilawar@intel.com, matthew.d.roper@intel.com, james.ausmus@intel.com, karthik.poosa@intel.com Subject: [PATCH v8 05/20] platform/x86/intel/pmt: Do not remap when using callbacks Date: Fri, 11 Sep 2026 13:11:53 -0700 Message-ID: <20260911201148.1610547-27-michael.j.ruhl@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260911201148.1610547-22-michael.j.ruhl@intel.com> References: <20260911201148.1610547-22-michael.j.ruhl@intel.com> Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A callback indicates that the parent driver is responsible for accessing the data area. Creating a PMT memory remap is redundant. If a read_telem callback has been provided, do not create a remap. Signed-off-by: Michael J. Ruhl --- drivers/platform/x86/intel/pmt/class.c | 21 +++++++++++++-------- drivers/platform/x86/intel/pmt/class.h | 2 +- 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/platform/x86/intel/pmt/class.c b/drivers/platform/x86/intel/pmt/class.c index 402d51df834a..1c7a372b4fc4 100644 --- a/drivers/platform/x86/intel/pmt/class.c +++ b/drivers/platform/x86/intel/pmt/class.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -373,7 +374,6 @@ static int intel_pmt_dev_register(struct intel_pmt_entry *entry, struct device *parent) { struct intel_vsec_device *ivdev = dev_to_ivdev(parent); - struct resource res = {0}; struct device *dev; int ret; @@ -403,14 +403,19 @@ static int intel_pmt_dev_register(struct intel_pmt_entry *entry, if (!entry->size) return 0; - res.start = entry->base_addr; - res.end = res.start + entry->size - 1; - res.flags = IORESOURCE_MEM; + /* + * The read_telem callback is responsible for this mapping, and may have + * different requirements for use. If the callback is present do not + * create the map. + */ + if (!(entry->cb && entry->cb->read_telem)) { + struct resource res = DEFINE_RES_MEM(entry->base_addr, entry->size); - entry->base = devm_ioremap_resource(dev, &res); - if (IS_ERR(entry->base)) { - ret = PTR_ERR(entry->base); - goto fail_ioremap; + entry->base = devm_ioremap_resource(dev, &res); + if (IS_ERR(entry->base)) { + ret = PTR_ERR(entry->base); + goto fail_ioremap; + } } sysfs_bin_attr_init(&entry->pmt_bin_attr); diff --git a/drivers/platform/x86/intel/pmt/class.h b/drivers/platform/x86/intel/pmt/class.h index 258cb460e61c..aeb04afb67cf 100644 --- a/drivers/platform/x86/intel/pmt/class.h +++ b/drivers/platform/x86/intel/pmt/class.h @@ -48,7 +48,7 @@ struct intel_pmt_entry { const struct attribute_group *attr_grp; struct kobject *kobj; void __iomem *disc_table; - void __iomem *base; + void __iomem *base; /* unused if cb->read_telem is in use */ struct pmt_callbacks *cb; unsigned long base_addr; size_t size; -- 2.43.0