From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Zhao Liu" <zhao1.liu@intel.com>,
"Jason Wang" <jasowangio@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Fabiano Rosas" <farosas@suse.de>,
"Philippe Mathieu-Daudé" <philmd@mailo.com>,
"Hanna Reitz" <hreitz@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Vladimir Sementsov-Ogievskiy" <vsementsov@yandex-team.ru>,
qemu-block@nongnu.org, "John Snow" <jsnow@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Ani Sinha" <anisinha@redhat.com>
Subject: [PATCH 8/9] qapi: split intro sections for data structs
Date: Fri, 11 Sep 2026 16:30:01 -0400 [thread overview]
Message-ID: <20260911203002.305316-9-jsnow@redhat.com> (raw)
In-Reply-To: <20260911203002.305316-1-jsnow@redhat.com>
The structs of concern in this patch are those for which no other QAPI
definition uses as a data type to describe its own arguments or as a
branch of a union: i.e. they are not currently inlined and as such the
precise semantics of their intro/details split is *currently* of less
concern.
Of course, they could be inlined in the future, so the semantics of
this split are still worth investigating.
Review notes: Similar notes as previous patches in this series with
respect to how splits were determined, and why details were not
physically relocated.
Signed-off-by: John Snow <jsnow@redhat.com>
---
qapi/acpi.json | 3 +--
qapi/block-core.json | 5 ++---
qapi/compat.json | 3 +--
qapi/machine.json | 9 ++++-----
4 files changed, 8 insertions(+), 12 deletions(-)
diff --git a/qapi/acpi.json b/qapi/acpi.json
index 291a04a7ea4..82e82d7cf89 100644
--- a/qapi/acpi.json
+++ b/qapi/acpi.json
@@ -13,8 +13,7 @@
##
# @AcpiTableOptions:
-#
-# Specify an ACPI table on the command line to load.
+# Specify an ACPI table on the command line to load.
#
# At most one of @file and @data can be specified. The list of files
# specified by any one of them is loaded and concatenated in order.
diff --git a/qapi/block-core.json b/qapi/block-core.json
index ec052f6bd2d..80f6c41c381 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -803,9 +803,8 @@
##
# @BlockMeasureInfo:
-#
-# Image file size calculation information. This structure describes
-# the size requirements for creating a new image file.
+# Image file size calculation information. This structure
+# describes the size requirements for creating a new image file.
#
# The size requirements depend on the new image file format. File
# size always equals virtual disk size for the 'raw' format, even for
diff --git a/qapi/compat.json b/qapi/compat.json
index ef1853b9acd..b42d142ddcc 100644
--- a/qapi/compat.json
+++ b/qapi/compat.json
@@ -37,8 +37,7 @@
##
# @CompatPolicy:
-#
-# Policy for handling deprecated management interfaces.
+# Policy for handling deprecated management interfaces.
#
# This is intended for testing users of the management interfaces.
#
diff --git a/qapi/machine.json b/qapi/machine.json
index 45e79c18b09..05a2851c0fc 100644
--- a/qapi/machine.json
+++ b/qapi/machine.json
@@ -1606,9 +1606,9 @@
##
# @SMPConfiguration:
-#
-# Schema for CPU topology configuration. A missing value lets QEMU
-# figure out a suitable value based on the ones that are provided.
+# Schema for CPU topology configuration. A missing value lets
+# QEMU figure out a suitable value based on the ones that are
+# provided.
#
# The members other than @cpus and @maxcpus define a topology of
# containers.
@@ -1867,8 +1867,7 @@
##
# @CpuModelInfo:
-#
-# Virtual CPU model.
+# Virtual CPU model.
#
# A CPU model consists of the name of a CPU definition, to which delta
# changes are applied (e.g. features added/removed). Most magic
--
2.55.0
next prev parent reply other threads:[~2026-09-11 20:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 20:29 [PATCH 0/9] qapi: convert/split remaining QAPI/QMP intro sections John Snow
2026-09-11 20:29 ` [PATCH 1/9] qapi: convert remaining simple intros for block-export.json John Snow
2026-09-12 7:02 ` Markus Armbruster
2026-09-11 20:29 ` [PATCH 2/9] qapi: convert multi-paragraph intros (commands) John Snow
2026-09-11 20:29 ` [PATCH 3/9] qapi: convert multi-paragraph intros (enums) John Snow
2026-09-11 20:29 ` [PATCH 4/9] qapi: convert multi-paragraph intros (structs) John Snow
2026-09-11 20:29 ` [PATCH 5/9] qapi: split intro sections for commands John Snow
2026-09-11 20:29 ` [PATCH 6/9] qapi: split intro sections for events John Snow
2026-09-11 20:30 ` [PATCH 7/9] qapi: split intro sections for enums John Snow
2026-09-11 20:30 ` John Snow [this message]
2026-09-11 20:30 ` [PATCH 9/9] qapi: split intro sections for inlinable structs John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260911203002.305316-9-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=anisinha@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=farosas@suse.de \
--cc=hreitz@redhat.com \
--cc=imammedo@redhat.com \
--cc=jasowangio@gmail.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@mailo.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.